From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934045AbbHKLAp (ORCPT ); Tue, 11 Aug 2015 07:00:45 -0400 Received: from mail-by2on0104.outbound.protection.outlook.com ([207.46.100.104]:53297 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932862AbbHKLAn convert rfc822-to-8bit (ORCPT ); Tue, 11 Aug 2015 07:00:43 -0400 From: Madalin-Cristian Bucur To: David Miller CC: "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Scott Wood , Liberman Igal , "ppc@mindchasers.com" , "joe@perches.com" , "pebolle@tiscali.nl" , "joakim.tjernlund@transmode.se" Subject: RE: [v2 8/9] dpaa_eth: add debugfs entries Thread-Topic: [v2 8/9] dpaa_eth: add debugfs entries Thread-Index: AQHQz5WIAZEu4O4l4UyOBHBv10aQd54BJA0AgAWGLLA= Date: Tue, 11 Aug 2015 11:00:39 +0000 Message-ID: References: <1438789289-16304-1-git-send-email-madalin.bucur@freescale.com> <1438789289-16304-9-git-send-email-madalin.bucur@freescale.com> <20150807.153716.1393797980617992919.davem@davemloft.net> In-Reply-To: <20150807.153716.1393797980617992919.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=madalin.bucur@freescale.com; x-originating-ip: [192.88.166.1] x-microsoft-exchange-diagnostics: 1;BL2PR03MB498;5:y0t9KLY2qY2LN+VcqjL/D1Be/3AX6teG2kWVJcvan2sHaSC5h2CIXfjdx3xdMM+eoPYW/ow5C8WNpKk/ABm101hzYPVJLdOQxJ5oN62b3SHqLAGQrielZqVBu/pTP+vgz5d7liF4ohBk+5c2NQ5gEQ==;24:pMOMfEiRVbkpM7hEef2UmtDBaoyZn0r+aCMnZna/NtKp2XsEGux49wwK0bHiLhQHvjbWicxsaEx6fb/Rz3MXNbiKfHXFr86+WpgBuWDx+DQ=;20:qsS5JKfwcBTBLn1EjiHxfU1S1/jDEpHpy67A8a31grz97c5bK5toD4MnoX/zzBFM//76ybUQROBHycCV5DUkvg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB498; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BL2PR03MB498;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB498; x-forefront-prvs: 066517B35B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(199003)(13464003)(54356999)(76576001)(122556002)(50986999)(76176999)(2656002)(10400500002)(5002640100001)(92566002)(5001960100002)(33656002)(110136002)(101416001)(46102003)(5001860100001)(2900100001)(62966003)(102836002)(5001830100001)(19580405001)(2950100001)(189998001)(74316001)(4001540100001)(5003600100002)(19580395003)(81156007)(97736004)(77096005)(68736005)(106356001)(66066001)(106116001)(64706001)(105586002)(86362001)(40100003)(99286002)(87936001)(77156002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR03MB498;H:BL2PR03MB545.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2015 11:00:39.8316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB498 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > > From: Madalin Bucur > Date: Wed, 5 Aug 2015 18:41:28 +0300 > > > Export per CPU counters through debugfs. > > > > Signed-off-by: Madalin Bucur > > This is absolutely inappropriate. > > You can export these just fine via ethtool statistics. There is zero reason > to add ugly debugfs crap for something like this. If you have such a strong adversity about the debugfs, then I'll export these debug counters through ethtool statistics in the next version. Madalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0110.outbound.protection.outlook.com [207.46.100.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 8CB181A039F for ; Tue, 11 Aug 2015 21:00:49 +1000 (AEST) From: Madalin-Cristian Bucur To: David Miller CC: "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Scott Wood , Liberman Igal , "ppc@mindchasers.com" , "joe@perches.com" , "pebolle@tiscali.nl" , "joakim.tjernlund@transmode.se" Subject: RE: [v2 8/9] dpaa_eth: add debugfs entries Date: Tue, 11 Aug 2015 11:00:39 +0000 Message-ID: References: <1438789289-16304-1-git-send-email-madalin.bucur@freescale.com> <1438789289-16304-9-git-send-email-madalin.bucur@freescale.com> <20150807.153716.1393797980617992919.davem@davemloft.net> In-Reply-To: <20150807.153716.1393797980617992919.davem@davemloft.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] >=20 > From: Madalin Bucur > Date: Wed, 5 Aug 2015 18:41:28 +0300 >=20 > > Export per CPU counters through debugfs. > > > > Signed-off-by: Madalin Bucur >=20 > This is absolutely inappropriate. >=20 > You can export these just fine via ethtool statistics. There is zero rea= son > to add ugly debugfs crap for something like this. If you have such a strong adversity about the debugfs, then I'll export the= se debug counters through ethtool statistics in the next version. Madalin