From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mintz, Yuval" Subject: Re: [RFC 02/11] Add RoCE driver framework Date: Tue, 13 Sep 2016 07:18:01 +0000 Message-ID: References: <1473696465-27986-1-git-send-email-Ram.Amrani@qlogic.com> <1473696465-27986-3-git-send-email-Ram.Amrani@qlogic.com> <516b98c7-477a-4890-0d92-529dc32f2c4e@mellanox.com> ,<20160913063806.GP8812@leon.nu> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20160913063806.GP8812@leon.nu> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Leon Romanovsky , Yuval Mintz Cc: Mark Bloch , Ram Amrani , "dledford@redhat.com" , David Miller , Ariel Elior , Michal Kalderon , Rajesh Borundia , "linux-rdma@vger.kernel.org" , netdev List-Id: linux-rdma@vger.kernel.org >> >> +uint debug; >> >> +module_param(debug, uint, 0); > >>> +MODULE_PARM_DESC(debug, "Default debug msglevel"); >> >> >Why are you adding this as a module parameter? >> >> I believe this is mostly to follow same line as qede which also defines > > 'debug' module parameter for allowing easy user control of debug > > prints [& specifically for probe prints, which can't be controlled > > otherwise]. > Can you give us an example where dynamic debug and tracing infrastructure= s > are not enough? > AFAIK, most of these debug module parameters are legacy copy/paste > code which is useless in real life scenarios. Define 'enough'; Using dynamic debug you can provide all the necessary information and at an even better granularity that's achieved by suggested infrastructure, but is harder for an end-user to use. Same goes for tracin= g. The 'debug' option provides an easy grouping for prints related to a specif= ic area in the driver.