All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
To: "mayhs11saini@gmail.com" <mayhs11saini@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: RE: [PATCH 1/2] qed: Replace memset with eth_zero_addr
Date: Mon, 16 Jan 2017 17:05:05 +0000	[thread overview]
Message-ID: <BL2PR07MB23069F2EFE839087FF63AC488D7D0@BL2PR07MB2306.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20170116.114606.1692928906878877115.davem@davemloft.net>

> > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote:
> >>
> >> Please do not ever submit two patches which have the same exact
> >> commit header line, as these two patches do.
> >>
> >> When someone looks into the shortlog of GIT history all they will see
> >> is "qed: Replace memset with eth_zero_addr" twice.
> >>
> >> This gives the reader no idea what might be different between those
> >> two changes.
> >>
> >> Therefore you must give unique a commit header text for each change,
> >> which communicates sufficiently what is different in each change.
> >
> > Thanks a lot for correcting me. I'll take care of this thing.
> >
> > I'm resending these two patches as
> > 	1). qed: Replace memset with eth_zero_addr
> > 	2). qed: Use eth_zero_addr
> >
> > I hope it resolves same commit header line conflict.
> 
> You aren't understanding the point.
> 
> Those two lines still say exactly the same thing.
> 
> What is different about these two changes?  The answer to that question
> must propagate into those lines of text.

Other than the fact these 2 patches change 2 different qed files,
is there any significant difference between what each does?
If not, why not simply do both in a single patch?

  reply	other threads:[~2017-01-16 17:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16  3:44 [PATCH 1/2] qed: Replace memset with eth_zero_addr Shyam Saini
2017-01-16  3:44 ` [PATCH 2/2] " Shyam Saini
2017-01-16  4:38 ` [PATCH 1/2] " David Miller
2017-01-16  9:24   ` Shyam Saini
2017-01-16 16:46     ` David Miller
2017-01-16 17:05       ` Mintz, Yuval [this message]
2017-01-16 17:12         ` David Miller
2017-01-16 17:40       ` Shyam Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL2PR07MB23069F2EFE839087FF63AC488D7D0@BL2PR07MB2306.namprd07.prod.outlook.com \
    --to=yuval.mintz@cavium.com \
    --cc=davem@davemloft.net \
    --cc=mayhs11saini@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.