All of lore.kernel.org
 help / color / mirror / Atom feed
From: John David Anglin <dave.anglin@bell.net>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: linux-parisc List <linux-parisc@vger.kernel.org>
Subject: Re: [PATCH] PARISC: provide __ucmpdi2
Date: Sat, 20 Apr 2013 16:26:01 -0400	[thread overview]
Message-ID: <BLU0-SMTP318334D40E569E5E0E46FF97C90@phx.gbl> (raw)
In-Reply-To: <3572037.nRvXk0Bztd@eto>

On 20-Apr-13, at 4:02 PM, Rolf Eike Beer wrote:

> Am Samstag 20 April 2013, 15:52:59 schrieb John David Anglin:
>> On 20-Apr-13, at 3:51 PM, Rolf Eike Beer wrote:
>>> Am Samstag 20 April 2013, 15:41:06 schrieb John David Anglin:
>>>> Provide __ucmpdi2 to resolve undefined references in 32 bit builds.
>>>>
>>>> The Debian experimental linux source package (3.8.5-1) build fails
>>>> with the following errors:
>>>> ...
>>>> MODPOST 2016 modules
>>>> ERROR: "__ucmpdi2" [fs/btrfs/btrfs.ko] undefined!
>>>> ERROR: "__ucmpdi2" [drivers/md/dm-verity.ko] undefined!
>>>>
>>>> The attached patch resolves this problem.  It is based on the s390
>>>> implementation
>>>> of ucmpdi2.c.
>>>>
>>>> Signed-off-by: John David Anglin <dave.anglin@bell.net>
>>>> Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
>>>> Cc: Helge Deller <deller@gmx.de>
>>>
>>> If this is in 3.8.5 this should also get a Cc:stable@kernel.org
>>
>> It is not in anything.
>
> The function? Or the error? If the function is missing, i.e. the  
> error will
> happen once enabling e.g. btrfs, in a already released kernel we  
> should get
> this into stable.

The error is probably in all active stable branches given that most  
ports provide the function.
GCC generates a call to __ucmpdi2 if the backend doesn't support  
unsigned 64-bit compares.
Normally, the function is resolved by libgcc.  I have no objection to  
pushing the patch back
but Helge and James usually decide this.

Dave
--
John David Anglin	dave.anglin@bell.net




      reply	other threads:[~2013-04-20 20:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-20 19:41 [PATCH] PARISC: provide __ucmpdi2 John David Anglin
2013-04-20 19:51 ` Rolf Eike Beer
2013-04-20 19:52   ` John David Anglin
2013-04-20 20:02     ` Rolf Eike Beer
2013-04-20 20:26       ` John David Anglin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLU0-SMTP318334D40E569E5E0E46FF97C90@phx.gbl \
    --to=dave.anglin@bell.net \
    --cc=eike-kernel@sf-tec.de \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.