From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xili_gchen_5257@hotmail.com>) id 1Zwui4-0001Fv-Om
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 11:26:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xili_gchen_5257@hotmail.com>) id 1Zwui1-0005Qb-GD
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 11:26:52 -0500
Received: from blu004-omc2s8.hotmail.com ([65.55.111.83]:56222)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xili_gchen_5257@hotmail.com>) id 1Zwui1-0005QW-Cz
	for qemu-devel@nongnu.org; Thu, 12 Nov 2015 11:26:49 -0500
Message-ID: <BLU436-SMTP220595EAC1087FE70F196F1B9120@phx.gbl>
Date: Fri, 13 Nov 2015 00:29:20 +0800
From: Chen Gang <xili_gchen_5257@hotmail.com>
MIME-Version: 1.0
References: <COL130-W26C8810524FA22F97ACDECB9160@phx.gbl>
	<COL130-W319D6675665F237C58622EB9160@phx.gbl>
	<5644A3E5.1040904@twiddle.net>
	<BLU437-SMTP825879E16C5695A00D3B62B9120@phx.gbl>
	<5644BBD7.4090109@twiddle.net>
In-Reply-To: <5644BBD7.4090109@twiddle.net>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/4] target-tilegx: Implement fpu single
 floating point
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Peter Maydell <peter.maydell@linaro.org>, Chris Metcalf <cmetcalf@ezchip.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 11/13/15 00:18=2C Richard Henderson wrote:
> On 11/12/2015 05:12 PM=2C Chen Gang wrote:
>> On 11/12/15 22:36=2C Richard Henderson wrote:
>>>> +    if (sfmt.calc =3D=3D TILEGX_F_CALC_CVT) {
>>>> +        if (sfmt.sign)
>>>> +            f.f =3D int32_to_float32(0 - sfmt.mantissa=2C fp_status)=
=3B
>>>> +        else
>>>> +            f.f =3D uint32_to_float32(sfmt.mantissa=2C fp_status)=3B
>>>> +    } else {
>>>
>>> Formatting.
>>>
>>> You really should know better by now.
>>> I'm not even going to look at the rest.
>>>
>>
>> Excuse me=2C my English is not quite well=2C I am not quite understand y=
our
>> meaning.
>>
>> Does the code above have issues?
>>
>=20
> Please read ./CODING_STYLE=2C and use ./scripts/checkpatch.pl.
>=20

Oh=2C sorry.



Thanks.
--=20
Chen Gang (=E9=99=88=E5=88=9A)

Open=2C share=2C and attitude like air=2C water=2C and life which God bless=
ed