From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrMwI-0007Qb-Ii for qemu-devel@nongnu.org; Sun, 10 May 2015 04:50:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrMwE-0002tW-IJ for qemu-devel@nongnu.org; Sun, 10 May 2015 04:50:22 -0400 Received: from blu004-omc1s2.hotmail.com ([65.55.116.13]:63434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrMwE-0002tM-EG for qemu-devel@nongnu.org; Sun, 10 May 2015 04:50:18 -0400 Message-ID: Date: Sun, 10 May 2015 16:50:42 +0800 From: Chen Gang MIME-Version: 1.0 References: <55153546.5060906@hotmail.com> <55283AC6.2000205@hotmail.com> In-Reply-To: <55283AC6.2000205@hotmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/12 v9] target-tilegx: Add cpu basic features for linux-user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Riku Voipio , qemu-devel , Chris Metcalf , "walt@tilera.com" , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "rth@twiddle.net" After have a check again, for me, I'd like to simply remove it firstly, since it is only for system mode. - At present, we are only focus on user mode, and which I haven't done quite well. - After we finish user mode, and start system mode, then can add it. - In this way, this feature will have no any negative effect with our current coding/reviewing, either no any negative effect for our next coding/reviewing. Thanks. On 4/11/15 05:04, Chen Gang wrote: >>> +static const VMStateDescription vmstate_tilegx_cpu = { >>> >> + .name = "cpu", >>> >> + .unmigratable = 1, >>> >> +}; >> > >> > I'd prefer to see a correct VMState from the start -- it's >> > not very difficult. Migration/snapshotting is much easier >> > to enforce at the point where we let code in to the tree >> > than if we let in non-migratable devices and CPUs and then >> > have to fix them up later... >> > >> > > OK, thanks. I shall try. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed