From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xili_gchen_5257@hotmail.com>) id 1YsuYG-0006O5-JU
	for qemu-devel@nongnu.org; Thu, 14 May 2015 10:56:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xili_gchen_5257@hotmail.com>) id 1YsuYB-0003zy-HM
	for qemu-devel@nongnu.org; Thu, 14 May 2015 10:55:56 -0400
Received: from blu004-omc1s26.hotmail.com ([65.55.116.37]:65353)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xili_gchen_5257@hotmail.com>) id 1YsuYB-0003zo-DK
	for qemu-devel@nongnu.org; Thu, 14 May 2015 10:55:51 -0400
Message-ID: <BLU437-SMTP89A6973A26388CF6C84D53B9D80@phx.gbl>
Date: Thu, 14 May 2015 22:56:17 +0800
From: Chen Gang <xili_gchen_5257@hotmail.com>
MIME-Version: 1.0
References: <BLU436-SMTP25541B8B575D093A94C69DFB9DC0@phx.gbl>
	<BLU436-SMTP63FD3A6167A47FDC4A3D91B9DC0@phx.gbl>
	<5550DEFF.8050204@twiddle.net>
In-Reply-To: <5550DEFF.8050204@twiddle.net>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/10 v10] target-tilegx: Generate tcg
 instructions to execute to _init_malloc in glib
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Peter Maydell <peter.maydell@linaro.org>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Chris Metcalf <cmetcalf@ezchip.com>
Cc: "walt@tilera.com" <walt@tilera.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel <qemu-devel@nongnu.org>

On 5/12/15 00:55, Richard Henderson wrote:
> On 05/10/2015 03:45 PM, Chen Gang wrote:
>> > +static void gen_cmpltsi(struct DisasContext *dc,
>> > +                        uint8_t rdst, uint8_t rsrc, int8_t imm8)
>> > +{
>> > +    qemu_log_mask(CPU_LOG_TB_IN_ASM, "cmpltsi r%d, r%d, %d\n",
>> > +                  rdst, rsrc, imm8);
>> > +    tcg_gen_setcondi_i64(TCG_COND_LTU, dest_gr(dc, rdst), load_gr(dc, rsrc),
>> > +                         (int64_t)imm8);
>> > +}

It is another bug: need to use TCG_COND_LT instead of TCG_COND_LTU.

>> > +
>> > +static void gen_cmpltui(struct DisasContext *dc,
>> > +                        uint8_t rdst, uint8_t rsrc, uint8_t imm8)

For imm8, its type needs to be int8_t.

>> > +{
>> > +    qemu_log_mask(CPU_LOG_TB_IN_ASM, "cmpltui r%d, r%d, %d\n",
>> > +                  rdst, rsrc, imm8);
>> > +    tcg_gen_setcondi_i64(TCG_COND_LTU,
>> > +                         dest_gr(dc, rdst), load_gr(dc, rsrc), imm8);
>> > +}
>> > +
>> > +static void gen_cmpeqi(struct DisasContext *dc,
>> > +                       uint8_t rdst, uint8_t rsrc, uint8_t imm8)

For imm8, its type needs to be int8_t.

>> > +{
>> > +    qemu_log_mask(CPU_LOG_TB_IN_ASM, "cmpeqi r%d, r%d, %d\n", rdst, rsrc, imm8);
>> > +    tcg_gen_setcondi_i64(TCG_COND_EQ,
>> > +                         dest_gr(dc, rdst), load_gr(dc, rsrc), imm8);
>> > +}
> Merge these.
> 


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed