All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix CFLAGS query using pkgconfig
@ 2015-04-27 20:36 Otavio Salvador
  2015-04-27 20:45 ` Otavio Salvador
  2015-04-28  6:52 ` junzhu
  0 siblings, 2 replies; 4+ messages in thread
From: Otavio Salvador @ 2015-04-27 20:36 UTC (permalink / raw)
  To: meta-freescale Mailing List; +Cc: Otavio Salvador

The pkgconfig queries cannot be appended without explicit spaces as
pkgconfig does not print trailing spaces by itself.

Change-Id: Ifa0d25ea715c1a517a81d971c9d5c46ffa9c64e6
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 ...igure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch | 46 ++++++++++++++++++++++
 .../gstreamer/gst-fsl-plugin_4.0.3.bb              |  1 +
 2 files changed, 47 insertions(+)
 create mode 100644 recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch

diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch b/recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch
new file mode 100644
index 0000000..16a75fc
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch
@@ -0,0 +1,46 @@
+From 3312c9fbc80b7b7fe3e28b24c4b8955aa3d5bf18 Mon Sep 17 00:00:00 2001
+From: Otavio Salvador <otavio@ossystems.com.br>
+Date: Mon, 27 Apr 2015 15:36:06 -0300
+Subject: [PATCH] configure.ac: Fix query of CFLAGS to pkgconfig
+Organization: O.S. Systems Software LTDA.
+
+The pkgconfig queries cannot be appended without explicit spaces as
+pkgconfig does not print trailing spaces by itself.
+
+Upstream-Status: Pending
+
+Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
+---
+ configure.ac | 14 +++++++-------
+ 1 file changed, 7 insertions(+), 7 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 86da399..276728f 100755
+--- a/configure.ac
++++ b/configure.ac
+@@ -175,15 +175,15 @@ AC_CHECK_LIB(rt, clock_gettime)
+ AC_SUBST(RT_CFLAGS)
+ AC_SUBST(RT_LIBS)
+ 
+-FSL_MM_CORE_CFLAGS=`$PKG_CONFIG --cflags libfslaudiocodec 2>/dev/null`
+-FSL_MM_CORE_CFLAGS+=`$PKG_CONFIG --cflags libfslvideocodec 2>/dev/null`
+-FSL_MM_CORE_CFLAGS+=`$PKG_CONFIG --cflags libfslparser 2>/dev/null`
+-FSL_MM_CORE_CFLAGS+=`$PKG_CONFIG --cflags libfslvpuwrap 2>/dev/null`
++FSL_MM_CORE_CFLAGS="`$PKG_CONFIG --cflags libfslaudiocodec 2>/dev/null` \
++                    `$PKG_CONFIG --cflags libfslvideocodec 2>/dev/null` \
++                    `$PKG_CONFIG --cflags libfslparser 2>/dev/null` \
++                    `$PKG_CONFIG --cflags libfslvpuwrap 2>/dev/null`"
+ AC_SUBST(FSL_MM_CORE_CFLAGS)
+ 
+-FSL_MM_CORE_LIBS=`$PKG_CONFIG --libs libfslaudiocodec 2>/dev/null`
+-FSL_MM_CORE_LIBS+=`$PKG_CONFIG --libs libfslvideocodec 2>/dev/null`
+-FSL_MM_CORE_LIBS+=`$PKG_CONFIG --libs libfslparser 2>/dev/null`
++FSL_MM_CORE_LIBS="`$PKG_CONFIG --libs libfslaudiocodec 2>/dev/null` \
++                  `$PKG_CONFIG --libs libfslvideocodec 2>/dev/null` \
++                  `$PKG_CONFIG --libs libfslparser 2>/dev/null`"
+ AC_SUBST(FSL_MM_CORE_LIBS)
+ 
+ EXTRAPLATFORMCFLAGS="-DARM -D_GNUC_"
+-- 
+2.1.4
+
diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin_4.0.3.bb b/recipes-multimedia/gstreamer/gst-fsl-plugin_4.0.3.bb
index 7cb3c68..2e23e98 100644
--- a/recipes-multimedia/gstreamer/gst-fsl-plugin_4.0.3.bb
+++ b/recipes-multimedia/gstreamer/gst-fsl-plugin_4.0.3.bb
@@ -7,6 +7,7 @@ EXTRA_OECONF += " CROSS_ROOT=${PKG_CONFIG_SYSROOT_DIR}"
 
 SRC_URI = "${FSL_MIRROR}/gst-fsl-plugins-${PV}.tar.gz \
            file://Remove-use-of-obsolete-VIDIOC_DBG_G_CHIP_IDENT.patch \
+           file://configure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch \
 "
 
 S = "${WORKDIR}/gst-fsl-plugins-${PV}"
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix CFLAGS query using pkgconfig
  2015-04-27 20:36 [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix CFLAGS query using pkgconfig Otavio Salvador
@ 2015-04-27 20:45 ` Otavio Salvador
  2015-04-28  6:52 ` junzhu
  1 sibling, 0 replies; 4+ messages in thread
From: Otavio Salvador @ 2015-04-27 20:45 UTC (permalink / raw)
  To: meta-freescale Mailing List, Jun Zhu

Hello Jun,

On Mon, Apr 27, 2015 at 5:36 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The pkgconfig queries cannot be appended without explicit spaces as
> pkgconfig does not print trailing spaces by itself.
>
> Change-Id: Ifa0d25ea715c1a517a81d971c9d5c46ffa9c64e6
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

This patch should be reviewed; it fixes a real build failure found in
O.S. Systems tests.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix CFLAGS query using pkgconfig
  2015-04-27 20:36 [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix CFLAGS query using pkgconfig Otavio Salvador
  2015-04-27 20:45 ` Otavio Salvador
@ 2015-04-28  6:52 ` junzhu
  2015-04-28 11:04   ` Otavio Salvador
  1 sibling, 1 reply; 4+ messages in thread
From: junzhu @ 2015-04-28  6:52 UTC (permalink / raw)
  To: Otavio Salvador, meta-freescale Mailing List

Hi, Otavio,
Can you mind telling your build environment? 

My build server is Ubuntu v14.04 X86_64 version and my fido branch build shows that FSL_MM_CORE_CFLAGS+= add one space as expected

!---- FSL_MM_CORE_CFLAGS = -I/home/r01007/fsl-yocto/dizzy-7D/build-x11/tmp/sysroots/imx7d_all/usr/include/imx-mm/audio-codec -I/home/r01007/fsl-yocto/dizzy-7D/build-x11/tmp/sysroots/imx7d_all/usr/include/imx-mm/video-codec -I/home/r01007/fsl-yocto/dizzy-7D/build-x11/tmp/sysroots/imx7d_all/usr/include/imx-mm/parser ----

Best Regards,
Jun Zhu


-----Original Message-----
From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Otavio Salvador
Sent: Tuesday, April 28, 2015 4:37 AM
To: meta-freescale Mailing List
Cc: Otavio Salvador
Subject: [meta-freescale] [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix CFLAGS query using pkgconfig

The pkgconfig queries cannot be appended without explicit spaces as pkgconfig does not print trailing spaces by itself.

Change-Id: Ifa0d25ea715c1a517a81d971c9d5c46ffa9c64e6
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 ...igure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch | 46 ++++++++++++++++++++++
 .../gstreamer/gst-fsl-plugin_4.0.3.bb              |  1 +
 2 files changed, 47 insertions(+)
 create mode 100644 recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch

diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch b/recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch
new file mode 100644
index 0000000..16a75fc
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gst-fsl-plugin/configure.ac-Fix-query
+++ -of-CFLAGS-to-pkgconfig.patch
@@ -0,0 +1,46 @@
+From 3312c9fbc80b7b7fe3e28b24c4b8955aa3d5bf18 Mon Sep 17 00:00:00 2001
+From: Otavio Salvador <otavio@ossystems.com.br>
+Date: Mon, 27 Apr 2015 15:36:06 -0300
+Subject: [PATCH] configure.ac: Fix query of CFLAGS to pkgconfig
+Organization: O.S. Systems Software LTDA.
+
+The pkgconfig queries cannot be appended without explicit spaces as 
+pkgconfig does not print trailing spaces by itself.
+
+Upstream-Status: Pending
+
+Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
+---
+ configure.ac | 14 +++++++-------
+ 1 file changed, 7 insertions(+), 7 deletions(-)
+
+diff --git a/configure.ac b/configure.ac index 86da399..276728f 100755
+--- a/configure.ac
++++ b/configure.ac
+@@ -175,15 +175,15 @@ AC_CHECK_LIB(rt, clock_gettime)
+ AC_SUBST(RT_CFLAGS)
+ AC_SUBST(RT_LIBS)
+ 
+-FSL_MM_CORE_CFLAGS=`$PKG_CONFIG --cflags libfslaudiocodec 2>/dev/null` 
+-FSL_MM_CORE_CFLAGS+=`$PKG_CONFIG --cflags libfslvideocodec 
+2>/dev/null` -FSL_MM_CORE_CFLAGS+=`$PKG_CONFIG --cflags libfslparser 
+2>/dev/null` -FSL_MM_CORE_CFLAGS+=`$PKG_CONFIG --cflags libfslvpuwrap 
+2>/dev/null`
++FSL_MM_CORE_CFLAGS="`$PKG_CONFIG --cflags libfslaudiocodec 2>/dev/null` \
++                    `$PKG_CONFIG --cflags libfslvideocodec 2>/dev/null` \
++                    `$PKG_CONFIG --cflags libfslparser 2>/dev/null` \
++                    `$PKG_CONFIG --cflags libfslvpuwrap 2>/dev/null`"
+ AC_SUBST(FSL_MM_CORE_CFLAGS)
+ 
+-FSL_MM_CORE_LIBS=`$PKG_CONFIG --libs libfslaudiocodec 2>/dev/null` 
+-FSL_MM_CORE_LIBS+=`$PKG_CONFIG --libs libfslvideocodec 2>/dev/null` 
+-FSL_MM_CORE_LIBS+=`$PKG_CONFIG --libs libfslparser 2>/dev/null`
++FSL_MM_CORE_LIBS="`$PKG_CONFIG --libs libfslaudiocodec 2>/dev/null` \
++                  `$PKG_CONFIG --libs libfslvideocodec 2>/dev/null` \
++                  `$PKG_CONFIG --libs libfslparser 2>/dev/null`"
+ AC_SUBST(FSL_MM_CORE_LIBS)
+ 
+ EXTRAPLATFORMCFLAGS="-DARM -D_GNUC_"
+--
+2.1.4
+
diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin_4.0.3.bb b/recipes-multimedia/gstreamer/gst-fsl-plugin_4.0.3.bb
index 7cb3c68..2e23e98 100644
--- a/recipes-multimedia/gstreamer/gst-fsl-plugin_4.0.3.bb
+++ b/recipes-multimedia/gstreamer/gst-fsl-plugin_4.0.3.bb
@@ -7,6 +7,7 @@ EXTRA_OECONF += " CROSS_ROOT=${PKG_CONFIG_SYSROOT_DIR}"
 
 SRC_URI = "${FSL_MIRROR}/gst-fsl-plugins-${PV}.tar.gz \
            file://Remove-use-of-obsolete-VIDIOC_DBG_G_CHIP_IDENT.patch \
+           file://configure.ac-Fix-query-of-CFLAGS-to-pkgconfig.patch \
 "
 
 S = "${WORKDIR}/gst-fsl-plugins-${PV}"
--
2.1.4

--
_______________________________________________
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix CFLAGS query using pkgconfig
  2015-04-28  6:52 ` junzhu
@ 2015-04-28 11:04   ` Otavio Salvador
  0 siblings, 0 replies; 4+ messages in thread
From: Otavio Salvador @ 2015-04-28 11:04 UTC (permalink / raw)
  To: junzhu; +Cc: meta-freescale Mailing List

On Tue, Apr 28, 2015 at 3:52 AM, junzhu@freescale.com
<junzhu@freescale.com> wrote:
> Hi, Otavio,
> Can you mind telling your build environment?
>
> My build server is Ubuntu v14.04 X86_64 version and my fido branch build shows that FSL_MM_CORE_CFLAGS+= add one space as expected
>
> !---- FSL_MM_CORE_CFLAGS = -I/home/r01007/fsl-yocto/dizzy-7D/build-x11/tmp/sysroots/imx7d_all/usr/include/imx-mm/audio-codec -I/home/r01007/fsl-yocto/dizzy-7D/build-x11/tmp/sysroots/imx7d_all/usr/include/imx-mm/video-codec -I/home/r01007/fsl-yocto/dizzy-7D/build-x11/tmp/sysroots/imx7d_all/usr/include/imx-mm/parser ----

Debian Sid and the += didn't work here.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-04-28 11:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-27 20:36 [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix CFLAGS query using pkgconfig Otavio Salvador
2015-04-27 20:45 ` Otavio Salvador
2015-04-28  6:52 ` junzhu
2015-04-28 11:04   ` Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.