From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800AbcGPRaI (ORCPT ); Sat, 16 Jul 2016 13:30:08 -0400 Received: from mail-by2nam01on0061.outbound.protection.outlook.com ([104.47.34.61]:7040 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751573AbcGPRaE convert rfc822-to-8bit (ORCPT ); Sat, 16 Jul 2016 13:30:04 -0400 X-Greylist: delayed 12856 seconds by postgrey-1.27 at vger.kernel.org; Sat, 16 Jul 2016 13:30:04 EDT From: Jens Rottmann To: Minchan Kim CC: Lukasz Odzioba , Sasha Levin , "stable@vger.kernel.org" , Michal Hocko , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "Mikulas Patocka" Subject: Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs on compound page arrival" Thread-Topic: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs on compound page arrival" Thread-Index: AQHR3tIHQmwC8F1JtkapS+5ShFIzSqAbJFwAgAAoEmc= Date: Sat, 16 Jul 2016 17:29:59 +0000 Message-ID: References: <83d21ffc-eeb8-40f8-7443-8d8291cd5973@ADLINKtech.com>,<20160716144740.GA29708@bbox> In-Reply-To: <20160716144740.GA29708@bbox> Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=jens.rottmann@adlinktech.com; x-originating-ip: [79.223.65.95] x-ms-office365-filtering-correlation-id: 8ff8d8b9-ff96-453c-7d3a-08d3ad9ed00f x-microsoft-exchange-diagnostics: 1;BLUPR0501MB2081;6:gBRcadWH8YxGSkEf8jFMpuaDuKLgT81H7wimwI+VQlpJ2wIHDkDYCixjU0xWLUYi8FcgnHzw1vyWQ+DwXGGCN6uIT8+ie0v3LAOne+cuV7h8/YXPNBMugIwuWIwTeE5Ifwg469QNUusiWnqWgbBXLMcVHuCNxOIAzzhqaJhccF/DXYw9MqozdiFFlpe7td/sDK6GKrpg8dkZc4JE5EnPjXBK9KLzcy7xmvEDcP15nFOE7TSOMTNWT87EZfO8LGoonrrOeBEdq/NKIUmq9/HfP5CkOlKXbv8srsA/AeJ9sVk=;5:ay2lD88Q9bV4Zxv/g6HphFRmL0/aibNU/88KQglXu6gdpFOdC8FCSQUyQfPltG0rzrcRYSMtxVR2jIHZ1xlKNHnXuvTTgwpKzs8frW4mPNlqXDCq3pENYF9vgC77cLtgcj/f9mOt5dKK05yH8RIkag==;24:AXgkmHecXRpbNrCrY+/WKgDt4GzjPB+adHUjFxiG/1E45R8lNvzIpkE4Gtm01puH5re7rNS9b1Gc6A8gnKY5ZxSnF0HAxQUmWL0GrzDUw/0=;7:3Lf13afQr9eiPj/Ju0dr/pgGNPaKJ+zgjnkW85jTaM/JJ3qKcpeLkMvWe7U5anfJlV2iAQqqL4Hbg/8S0hcka23Qbzv/EUquEOmMfzBJAoCCww8PF1HdZ8Dmm+PjLLgsV+HFvpUAfVEW5QATG/XMbnneMkvbd7HNB+zavpNO9dK9LB8fDs1SaKiT7eY687L1mpbpu6Afi1x2I85sku7JNycmv5gx459y6oTmwtm6UWAMgCToAEdkI2kqSBvLhspz x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0501MB2081; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BLUPR0501MB2081;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0501MB2081; x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(24454002)(66654002)(199003)(5423002)(189002)(3846002)(9686002)(99286002)(2900100001)(2950100001)(102836003)(586003)(15975445007)(5002640100001)(305945005)(6116002)(2906002)(76576001)(3280700002)(54356999)(106356001)(106116001)(101416001)(4326007)(19580395003)(76176999)(77096005)(3660700001)(92566002)(122556002)(189998001)(50986999)(33656002)(86362001)(11100500001)(8936002)(8676002)(105586002)(87936001)(74316002)(7736002)(68736007)(97736004)(10400500002)(5003600100003)(110136002)(81156014)(81166006)(66066001)(7846002)(7696003)(6606295002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0501MB2081;H:BLUPR0501MB2082.namprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:3;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: adlinktech.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2016 17:29:59.5294 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 6c7b546b-78e1-414f-8297-48bb0f8ca053 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0501MB2081 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Minchan (& all), Minchan Kim wrote: > [...] found __lru_cache_add has a bug. [...] [-] if (!pagevec_space(pvec) || PageCompound(page)) [+] if (!pagevec_add(pvec, page) || PageCompound(page)) Confirm that did plug the leak, thanks! Also I just saw this was known already: https://marc.info/?l=linux-kernel&m=146858368215856 Sorry for not noticing earlier, I did search for "4.1.28 memory leak", but not for "memleak". Many thanks, Jens From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Jens Rottmann To: Minchan Kim CC: Lukasz Odzioba , Sasha Levin , "stable@vger.kernel.org" , Michal Hocko , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "Mikulas Patocka" Subject: Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs on compound page arrival" Date: Sat, 16 Jul 2016 17:29:59 +0000 Message-ID: References: <83d21ffc-eeb8-40f8-7443-8d8291cd5973@ADLINKtech.com>,<20160716144740.GA29708@bbox> In-Reply-To: <20160716144740.GA29708@bbox> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: Hi Minchan (& all), Minchan Kim wrote: > [...] found __lru_cache_add has a bug. [...] [-] if (!pagevec_space(pvec) || PageCompound(page)) [+] if (!pagevec_add(pvec, page) || PageCompound(page)) Confirm that did plug the leak, thanks! Also I just saw this was known already: https://marc.info/?l=3Dlinux-kernel&m=3D146858368215856 Sorry for not noticing earlier, I did search for "4.1.28 memory leak", but = not for "memleak". Many thanks, Jens -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org