From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mody, Rasesh" Subject: Re: [PATCH v4 31/62] net/qede/base: revise tunnel APIs/structs Date: Tue, 28 Mar 2017 21:18:14 +0000 Message-ID: References: <798af029-9a26-9065-350b-48781c1d3c55@intel.com> <1490683952-24919-32-git-send-email-rasesh.mody@cavium.com> <575911f6-467b-4153-1ac3-a452989a8ce5@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Thomas Monjalon To: Ferruh Yigit , "dev@dpdk.org" Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0051.outbound.protection.outlook.com [104.47.41.51]) by dpdk.org (Postfix) with ESMTP id DFAFFCF7A for ; Tue, 28 Mar 2017 23:18:17 +0200 (CEST) In-Reply-To: <575911f6-467b-4153-1ac3-a452989a8ce5@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, March 28, 2017 4:23 AM >=20 > On 3/28/2017 7:52 AM, Rasesh Mody wrote: > > Revise tunnel APIs/structs. > > - Unite tunnel start and update params in single struct > > "ecore_tunnel_info" > > - Remove A0 chip tunnelling support. > > - Added per tunnel info - removed bitmasks. > > > > Signed-off-by: Rasesh Mody >=20 > I hate to say this, but this patch gives build error with clang [1], it s= eems it is > fixed in next patch. We also observed this error on clang, however, the fix got wrongly applied = to the next patch, sorry about that. >=20 > This patchset is big, and takes time to review / validate it, and a small= error > requires whole patchset done again. I am not suggesting updating this one= , > but for further patchsets, what do you think making multiple smaller > patchsets? Please let us know if we need to refresh the current v4 patchset to address= the clang issue. It's good suggestion, for further patchsets, we can do multiple smaller pat= chsets. Thanks! -Rasesh >=20 > Thanks, > ferruh >=20 >=20 > [1] > Building x86_64-native-linuxapp-clang ... > .../drivers/net/qede/base/ecore_sp_commands.c:141:25: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->vxlan.tun_cls =3D type; > ~ ^~~~ > .../drivers/net/qede/base/ecore_sp_commands.c:143:26: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->l2_gre.tun_cls =3D type; > ~ ^~~~ > .../drivers/net/qede/base/ecore_sp_commands.c:145:26: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->ip_gre.tun_cls =3D type; > ~ ^~~~ > .../drivers/net/qede/base/ecore_sp_commands.c:147:29: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->l2_geneve.tun_cls =3D type; > ~ ^~~~ > .../drivers/net/qede/base/ecore_sp_commands.c:149:29: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->ip_geneve.tun_cls =3D type; > ~ ^~~~ > 5 errors generated. > make[10]: *** [base/ecore_sp_commands.o] Error 1 > make[10]: *** Waiting for unfinished jobs.... > .../drivers/net/qede/qede_ethdev.c:1724:45: error: variable 'p_tunn' is > uninitialized when used here [-Werror,-Wuninitialized] > rc =3D ecore_sp_pf_update_tunn_cfg(p_hwfn, p_tunn= , > ^~~~~~ > .../drivers/net/qede/qede_ethdev.c:1711:34: note: initialize the variable > 'p_tunn' to silence this warning > struct ecore_tunnel_info *p_tunn; > ^ > =3D NULL > .../drivers/net/qede/qede_ethdev.c:1877:5: error: variable 'p_tunn' is > uninitialized when used here [-Werror,-Wuninitialized] > p_tunn, ECORE_SPQ_MODE_CB, NULL); > ^~~~~~ > .../drivers/net/qede/qede_ethdev.c:1822:34: note: initialize the variable > 'p_tunn' to silence this warning > struct ecore_tunnel_info *p_tunn; > ^ > =3D NULL > 2 errors generated.