From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
Subject: Re: [PATCH v3 41/61] net/qede/base: add support for
 previous driver unload
Date: Sat, 25 Mar 2017 06:25:32 +0000
Message-ID: <BLUPR0701MB1572D3586B30FE8713623E5E9F310@BLUPR0701MB1572.namprd07.prod.outlook.com>
References: <dd51cd87-72b4-fa89-3dc1-b79c32df1355@intel.com>
 <1490340531-11403-42-git-send-email-rasesh.mody@cavium.com>
 <1cabe096-47c2-401f-de66-524590fede83@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam03on0083.outbound.protection.outlook.com [104.47.40.83])
 by dpdk.org (Postfix) with ESMTP id 27EFCD332
 for <dev@dpdk.org>; Sat, 25 Mar 2017 07:25:35 +0100 (CET)
In-Reply-To: <1cabe096-47c2-401f-de66-524590fede83@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Friday, March 24, 2017 4:01 AM
>=20
> On 3/24/2017 7:28 AM, Rasesh Mody wrote:
> > New driver/management fw load request sequence for handling previous
> > driver unload.
> >
> > Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
>=20
> Hi Rasesh,
>=20
> Patch by patch build broken with this patch with following build error, a=
nd
> fixed back with patch 50/61:
>=20
> .../drivers/net/qede/base/ecore_mcp.c:624:2: error: signed shift result
> (0xF00000000) requires 37 bits to represent, but 'int' only has 32 bits [=
-
> Werror,-Wshift-overflow]
>         ECORE_MFW_SET_FIELD(p_load_req->misc0, LOAD_REQ_FORCE,
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> .../drivers/net/qede/base/ecore.h:107:31: note: expanded from macro
> 'ECORE_MFW_SET_FIELD'
>         (name) &=3D ~((field ## _MASK) << (field ## _SHIFT));            =
 \
>                     ~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~
> .../drivers/net/qede/base/ecore_mcp.c:626:2: error: signed shift result
> (0xF0000000000) requires 45 bits to represent, but 'int' only has 32 bits=
 [-
> Werror,-Wshift-overflow]
>         ECORE_MFW_SET_FIELD(p_load_req->misc0, LOAD_REQ_FLAGS0,
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> .../drivers/net/qede/base/ecore.h:107:31: note: expanded from macro
> 'ECORE_MFW_SET_FIELD'
>         (name) &=3D ~((field ## _MASK) << (field ## _SHIFT));            =
 \
>                     ~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~ <...>
We observed the same issue with patch 41, unfortunately  the fix was uninte=
ntionally added only in patch 50 whereas it was candidate for patch 41. We'=
ll address this and resubmit.

Thanks!
-Rasesh