From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rasesh Mody <rasesh.mody@qlogic.com>
Subject: Re: xstats performance
Date: Tue, 5 Jul 2016 18:10:06 +0000
Message-ID: <BLUPR11MB0370FD4F5FAF642A42CFB9E285390@BLUPR11MB0370.namprd11.prod.outlook.com>
References: <5773EB79.1090509@6wind.com>
 <d37183a6-41d1-4a0f-ba47-f44b4cca89ad@intel.com> <8870166.MVVViF2IlQ@xps13>
 <99e03d76-b896-2146-274c-2f3d83eee899@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Olivier MATZ <olivier.matz@6wind.com>
To: Remy Horton <remy.horton@intel.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0121.outbound.protection.outlook.com [104.47.32.121])
 by dpdk.org (Postfix) with ESMTP id B9B615958
 for <dev@dpdk.org>; Tue,  5 Jul 2016 20:10:08 +0200 (CEST)
In-Reply-To: <99e03d76-b896-2146-274c-2f3d83eee899@intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Remy,

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> Sent: Friday, July 01, 2016 2:15 AM
>=20
>=20
> On 29/06/2016 17:40, Thomas Monjalon wrote:
> [..]
> > I don't think it is possible to standardize stats ids, for two reasons:
> > - it is hard to maintain and avoid conflicts between drivers
> > - the drivers would have to lookup the names which degrades
> > performance
>=20
> I designed it that way to keep flexibility down the line rather than spec=
ifically
> for the above use-case.
>=20
>=20
> > I think the idea of Olivier would improve the performance of stats retr=
ieval,
> > which was the idea of this rework :)
> > Unfortunately we need someone available to fix it quickly for RC2.
>=20
> For all the current drivers xstats_names[idx].id=3D=3Didx so it would jus=
t
> involve removing the references to the id field and updating the
> documentation. Complication is coordinating with QLogic for the bnx2x &
> qede xstats patches.

We could incorporate this change in our re-submission.
=20
> ..Remy