From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wang, Annie" Subject: RE: [PATCH 1/6] 8250/Kconfig: add config option CONFIG_SERIAL_8250_AMD Date: Wed, 6 Jan 2016 02:08:18 +0000 Message-ID: References: <1451885501-2710-1-git-send-email-annie.wang@amd.com> <1451885501-2710-2-git-send-email-annie.wang@amd.com> <20160104144118.GJ22941@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-by2on0095.outbound.protection.outlook.com ([207.46.100.95]:58432 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751846AbcAFCIY (ORCPT ); Tue, 5 Jan 2016 21:08:24 -0500 In-Reply-To: <20160104144118.GJ22941@pd.tnic> Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Borislav Petkov Cc: Andy Shevchenko , Vinod Koul , Mika Westerberg , Greg Kroah-Hartman , "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , "dmaengine@vger.kernel.org" , "Huang, Ray" , "Wan, Vincent" , "Xue, Ken" , Robin Murphy , Graeme Gregory , "Li, Tony" , "Yu, Xiangliang" SGkgQm9yaXMsDQoNCj4tLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPkZyb206IEJvcmlzbGF2 IFBldGtvdiBbbWFpbHRvOmJwQGFsaWVuOC5kZV0NCj5TZW50OiBNb25kYXksIEphbnVhcnkgMDQs IDIwMTYgMTA6NDEgUE0NCj5UbzogV2FuZywgQW5uaWUNCj5DYzogQW5keSBTaGV2Y2hlbmtvOyBW aW5vZCBLb3VsOyBNaWthIFdlc3RlcmJlcmc7IEdyZWcgS3JvYWgtSGFydG1hbjsgUmFmYWVsDQo+ Si4gV3lzb2NraTsgbGludXgtYWNwaUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2Vy Lmtlcm5lbC5vcmc7IGxpbnV4LQ0KPnNlcmlhbEB2Z2VyLmtlcm5lbC5vcmc7IGRtYWVuZ2luZUB2 Z2VyLmtlcm5lbC5vcmc7IEh1YW5nLCBSYXk7IFdhbiwgVmluY2VudDsNCj5YdWUsIEtlbjsgUm9i aW4gTXVycGh5OyBHcmFlbWUgR3JlZ29yeTsgTGksIFRvbnk7IFl1LCBYaWFuZ2xpYW5nDQo+U3Vi amVjdDogUmU6IFtQQVRDSCAxLzZdIDgyNTAvS2NvbmZpZzogYWRkIGNvbmZpZyBvcHRpb24NCj5D T05GSUdfU0VSSUFMXzgyNTBfQU1EDQo+DQo+T24gTW9uLCBKYW4gMDQsIDIwMTYgYXQgMDE6MzE6 MzZQTSArMDgwMCwgV2FuZyBIb25nY2hlbmcgd3JvdGU6DQo+PiBBZGQgY29uZmlnIG9wdGlvbiAg Q09ORklHX1NFUklBTF84MjUwX0FNRCBpbiB1c2Ugb2YgQU1EIGNhcnJpem8uDQo+PiBCZWNhdXNl IGNhcnJpem8ncyBVQVJUIERNQSBkZXZpY2UgaXMgYW4gYW1iYSBkZXZpY2UsIGl0IHNlbGVjdHMN Cj4+IEFSTV9BTUJBIG9wdGlvbi4gQW55dGhpbmcgdXNlcyBhbWJhIGRldmljZXMgbXVzdCBzZWxl Y3QgQVJNX0FNQkEuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogV2FuZyBIb25nY2hlbmcgPGFubmll LndhbmdAYW1kLmNvbT4NCj4+IC0tLQ0KPj4gIGRyaXZlcnMvdHR5L3NlcmlhbC84MjUwL0tjb25m aWcgfCA4ICsrKysrKysrDQo+PiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKQ0KPj4N Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3R0eS9zZXJpYWwvODI1MC9LY29uZmlnDQo+PiBiL2Ry aXZlcnMvdHR5L3NlcmlhbC84MjUwL0tjb25maWcgaW5kZXggNjQxMmYxNC4uYzllYmMzMSAxMDA2 NDQNCj4+IC0tLSBhL2RyaXZlcnMvdHR5L3NlcmlhbC84MjUwL0tjb25maWcNCj4+ICsrKyBiL2Ry aXZlcnMvdHR5L3NlcmlhbC84MjUwL0tjb25maWcNCj4+IEBAIC0zNzgsMyArMzc4LDExIEBAIGNv bmZpZyBTRVJJQUxfODI1MF9NSUQNCj4+ICAJICBTZWxlY3RpbmcgdGhpcyBvcHRpb24gd2lsbCBl bmFibGUgaGFuZGxpbmcgb2YgdGhlIGV4dHJhIGZlYXR1cmVzDQo+PiAgCSAgcHJlc2VudCBvbiB0 aGUgVUFSVCBmb3VuZCBvbiBJbnRlbCBNZWRmaWVsZCBTT0MgYW5kIHZhcmlvdXMgb3RoZXINCj4+ ICAJICBJbnRlbCBwbGF0Zm9ybXMuDQo+PiArDQo+PiArY29uZmlnIFNFUklBTF84MjUwX0FNRA0K Pj4gKwlib29sICJBTUQgY2Fycml6byBzZXJpYWwgcG9ydCBzdXBwb3J0Ig0KPj4gKwlkZXBlbmRz IG9uIFNFUklBTF84MjUwDQo+PiArCXNlbGVjdCBBUk1fQU1CQQ0KPj4gKwloZWxwDQo+PiArCSAg SWYgeW91IGhhdmUgYSBGYW1pbHkgMTVoLCBtb2RlbHMgMHg2MC0weDZGIGJhc2VkIGJvYXJkIGFu ZCB3YW50IHRvDQo+PiArCSAgdXNlIHRoZSBzZXJpYWwgcG9ydCwgc2F5IFkgdG8gdGhpcyBvcHRp b24uIElmIHVuc3VyZSwgc2F5IE4uDQo+DQo+SG1tLCBzbyB5b3UncmUgYWRkaW5nIHRoaXMgY29u ZmlnIG9wdGlvbiBoZXJlIG9ubHkgdG8gaGF2ZQ0KPmFjcGlfYXBkX3NldHVwX3F1aXJrcygpIGRl ZmluZWQgaW4gYW4gYWxyZWFkeSBBTUQtc3BlY2lmaWMgY29tcGlsYXRpb24gdW5pdA0KPmRyaXZl cnMvYWNwaS9hY3BpX2FwZC5jLg0KPg0KDQpIb3cgYWJvdXQgSSBhZGQgc2VsZWN0IEFSTV9BTUJB IGFuZCBTRVJJQUxfODI1MCBpbiBhcmNoL3g4Ni9LY29uZmlnPw0KDQpkaWZmIC0tZ2l0IGEvYXJj aC94ODYvS2NvbmZpZyBiL2FyY2gveDg2L0tjb25maWcNCmluZGV4IGRiMzYyMmYuLjBmZTY2NTcg MTAwNjQ0DQotLS0gYS9hcmNoL3g4Ni9LY29uZmlnDQorKysgYi9hcmNoL3g4Ni9LY29uZmlnDQpA QCAtNTM3LDExICs1MzcsMTUgQEAgY29uZmlnIFg4Nl9BTURfUExBVEZPUk1fREVWSUNFDQogICAg ICAgIGRlcGVuZHMgb24gQUNQSQ0KICAgICAgICBzZWxlY3QgQ09NTU9OX0NMSw0KICAgICAgICBz ZWxlY3QgUElOQ1RSTA0KKyAgICAgICBzZWxlY3QgU0VSSUFMXzgyNTANCisgICAgICAgc2VsZWN0 IEFSTV9BTUJBDQogICAgICAgIC0tLWhlbHAtLS0NCiAgICAgICAgICBTZWxlY3QgdG8gaW50ZXJw cmV0IEFNRCBzcGVjaWZpYyBBQ1BJIGRldmljZSB0byBwbGF0Zm9ybSBkZXZpY2UNCiAgICAgICAg ICBzdWNoIGFzIEkyQywgVUFSVCwgR1BJTyBmb3VuZCBvbiBBTUQgQ2Fycml6byBhbmQgbGF0ZXIg Y2hpcHNldHMuDQogICAgICAgICAgSTJDIGFuZCBVQVJUIGRlcGVuZCBvbiBDT01NT05fQ0xLIHRv IHNldCBjbG9jay4gR1BJTyBkcml2ZXIgaXMNCi0gICAgICAgICBpbXBsZW1lbnRlZCB1bmRlciBQ SU5DVFJMIHN1YnN5c3RlbS4NCisgICAgICAgICBpbXBsZW1lbnRlZCB1bmRlciBQSU5DVFJMIHN1 YnN5c3RlbS4gQ2Fycml6bydzIFVBUlQgaXMgaW1wbGVtZW50ZWQNCisgICAgICAgICB1bmRlciBT RVJJQUxfODI1MC4gQ2Fycml6bydzIFVBUlQgRE1BIGRldmljZSBpcyBhbiBhbWJhIGRldmljZSwN CisgICAgICAgICBpdCBzZWxlY3RzIEFSTV9BTUJBIG9wdGlvbi4NCg0KIGNvbmZpZyBJT1NGX01C SQ0KICAgICAgICB0cmlzdGF0ZSAiSW50ZWwgU29DIElPU0YgU2lkZWJhbmQgc3VwcG9ydCBmb3Ig U29DIHBsYXRmb3JtcyINCi0tDQoNCj5TbyB3aHkgbm90IG1ha2UgZHJpdmVycy9hY3BpL2FjcGlf YXBkLmMgZGVwZW5kIG9uIENQVV9TVVBfQU1EIGFuZCB0aGlzIHdheQ0KPml0IGlzIGF1dG9tYXRp Y2FsbHkgZW5hYmxlZCBvbiBBTUQgYW5kIHRoZW4gY2hlY2sgZmFtaWx5L21vZGVsL3N0ZXBwaW5n IHdoZW4NCj5hc3NpZ25pbmcgdGhhdA0KPg0KPisgICAgICAgLnBvc3Rfc2V0dXAgPSBhY3BpX2Fw ZF9zZXR1cF9xdWlya3MsDQo+DQo+dGhpbmc/DQo+DQo+WW91IG5lZWQgaXQgb25seSBvbiBGMTVo LCBtb2RlbHMgMHg2MC4uIG9ubHkgc28geW91IGRvbid0IHJlYWxseSBuZWVkIHRoZSBjb25maWcN Cj5vcHRpb24gd2hlbiB5b3UgY2FuIGZpbmQgb3V0IG9uIHdoYXQgaGFyZHdhcmUgeW91J3JlIHJ1 bm5pbmcgd2l0aG91dCB0aGUgdXNlcg0KPmhhdmluZyB0byBjb25maWd1cmUgdGhlIGtlcm5lbC4N Cj4NCj5IbW1tPw0KDQpDUFVfU1VQX0FNRCBpcyBvbmx5IGNvbmZpZ3VyZWQgaW4gWDg2IGFyY2gu IEFNRCBmdXR1cmUgIEFSTTY0IHByb2Nlc3NvcnMgbWF5DQphbHNvIG5lZWQgYWNwaSB0byBwbGF0 Zm9ybSBzdXBwb3J0LiANCiAgDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbcAFCI1 (ORCPT ); Tue, 5 Jan 2016 21:08:27 -0500 Received: from mail-by2on0095.outbound.protection.outlook.com ([207.46.100.95]:58432 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751846AbcAFCIY (ORCPT ); Tue, 5 Jan 2016 21:08:24 -0500 From: "Wang, Annie" To: Borislav Petkov CC: Andy Shevchenko , Vinod Koul , Mika Westerberg , Greg Kroah-Hartman , "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , "dmaengine@vger.kernel.org" , "Huang, Ray" , "Wan, Vincent" , "Xue, Ken" , Robin Murphy , Graeme Gregory , "Li, Tony" , "Yu, Xiangliang" Subject: RE: [PATCH 1/6] 8250/Kconfig: add config option CONFIG_SERIAL_8250_AMD Thread-Topic: [PATCH 1/6] 8250/Kconfig: add config option CONFIG_SERIAL_8250_AMD Thread-Index: AQHRRrFe8XKhfgCWfUue18ptuBJkmZ7rbo4AgAJNfzA= Date: Wed, 6 Jan 2016 02:08:18 +0000 Message-ID: References: <1451885501-2710-1-git-send-email-annie.wang@amd.com> <1451885501-2710-2-git-send-email-annie.wang@amd.com> <20160104144118.GJ22941@pd.tnic> In-Reply-To: <20160104144118.GJ22941@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Annie.Wang@amd.com; x-originating-ip: [210.13.97.168] x-microsoft-exchange-diagnostics: 1;BLUPR12MB0418;5:X845BEej1fM55669YXB01VF9aOKbYX6sCTEAUlLtQRlthC6YpHoyLH0kSlgst5Zpxw1tDGfDpAMlptn4Hmb5EJA+KA8CJ2GERxYp0hzDabVXl+FjvM7j+vZvPBBIJPgDVwlE1pEC4O9VSMAJgdRaUA==;24:oZPS4N/XYnZ66QLsc0PCcZsCCnSjdPT0HaMjYafDggFoeidzf0K8myVCWNM68Xk5dmpGSzYlCsSiFLyxuDWD9Qy56MQBoXrzEqChMUu4OU0=;20:v/kSFvEwBUC0UV2XSUcBEPnAZINJtobZxRycM0ghJsuL2Dcy8QtwRushwlBk8H2x+kGXkVmx+kXZRnqrgDO8J48ita0cJtOA3/f6sbm87BkqjO1ef3tMyHEnI6U4WlTuZpt0hJ1+nS40M12wcZ0G8mCvfM0Gdnrt2u/SqgGEHGT4XcfPHi7DGxJmN/7KW3TfmA1/OIp8vhHP8LS9sIJR1bPw2Od60LOq8UiALRmSUsrx0wud6E+G+k0HnCQIgNXx x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0418; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(767451399110); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(10201501046)(3002001);SRVR:BLUPR12MB0418;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0418; x-forefront-prvs: 0813C68E65 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(189002)(13464003)(199003)(24454002)(11100500001)(99286002)(76576001)(3846002)(10400500002)(5001960100002)(86362001)(5008740100001)(66066001)(6116002)(19580395003)(5002640100001)(102836003)(1096002)(2900100001)(19580405001)(74316001)(4326007)(586003)(33656002)(110136002)(105586002)(2950100001)(81156007)(54356999)(50986999)(122556002)(5003600100002)(77096005)(92566002)(106116001)(106356001)(5004730100002)(76176999)(189998001)(40100003)(97736004)(87936001)(101416001)(1220700001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0418;H:BLUPR12MB0433.namprd12.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2016 02:08:18.4119 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0418 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u0628VV5032316 Hi Boris, >-----Original Message----- >From: Borislav Petkov [mailto:bp@alien8.de] >Sent: Monday, January 04, 2016 10:41 PM >To: Wang, Annie >Cc: Andy Shevchenko; Vinod Koul; Mika Westerberg; Greg Kroah-Hartman; Rafael >J. Wysocki; linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >serial@vger.kernel.org; dmaengine@vger.kernel.org; Huang, Ray; Wan, Vincent; >Xue, Ken; Robin Murphy; Graeme Gregory; Li, Tony; Yu, Xiangliang >Subject: Re: [PATCH 1/6] 8250/Kconfig: add config option >CONFIG_SERIAL_8250_AMD > >On Mon, Jan 04, 2016 at 01:31:36PM +0800, Wang Hongcheng wrote: >> Add config option CONFIG_SERIAL_8250_AMD in use of AMD carrizo. >> Because carrizo's UART DMA device is an amba device, it selects >> ARM_AMBA option. Anything uses amba devices must select ARM_AMBA. >> >> Signed-off-by: Wang Hongcheng >> --- >> drivers/tty/serial/8250/Kconfig | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/tty/serial/8250/Kconfig >> b/drivers/tty/serial/8250/Kconfig index 6412f14..c9ebc31 100644 >> --- a/drivers/tty/serial/8250/Kconfig >> +++ b/drivers/tty/serial/8250/Kconfig >> @@ -378,3 +378,11 @@ config SERIAL_8250_MID >> Selecting this option will enable handling of the extra features >> present on the UART found on Intel Medfield SOC and various other >> Intel platforms. >> + >> +config SERIAL_8250_AMD >> + bool "AMD carrizo serial port support" >> + depends on SERIAL_8250 >> + select ARM_AMBA >> + help >> + If you have a Family 15h, models 0x60-0x6F based board and want to >> + use the serial port, say Y to this option. If unsure, say N. > >Hmm, so you're adding this config option here only to have >acpi_apd_setup_quirks() defined in an already AMD-specific compilation unit >drivers/acpi/acpi_apd.c. > How about I add select ARM_AMBA and SERIAL_8250 in arch/x86/Kconfig? diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index db3622f..0fe6657 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -537,11 +537,15 @@ config X86_AMD_PLATFORM_DEVICE depends on ACPI select COMMON_CLK select PINCTRL + select SERIAL_8250 + select ARM_AMBA ---help--- Select to interpret AMD specific ACPI device to platform device such as I2C, UART, GPIO found on AMD Carrizo and later chipsets. I2C and UART depend on COMMON_CLK to set clock. GPIO driver is - implemented under PINCTRL subsystem. + implemented under PINCTRL subsystem. Carrizo's UART is implemented + under SERIAL_8250. Carrizo's UART DMA device is an amba device, + it selects ARM_AMBA option. config IOSF_MBI tristate "Intel SoC IOSF Sideband support for SoC platforms" -- >So why not make drivers/acpi/acpi_apd.c depend on CPU_SUP_AMD and this way >it is automatically enabled on AMD and then check family/model/stepping when >assigning that > >+ .post_setup = acpi_apd_setup_quirks, > >thing? > >You need it only on F15h, models 0x60.. only so you don't really need the config >option when you can find out on what hardware you're running without the user >having to configure the kernel. > >Hmmm? CPU_SUP_AMD is only configured in X86 arch. AMD future ARM64 processors may also need acpi to platform support. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I