From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liu, Monk" Subject: RE: [PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer Date: Thu, 1 Mar 2018 08:51:41 +0000 Message-ID: References: <1519802463-9090-1-git-send-email-Monk.Liu@amd.com> <1519802463-9090-3-git-send-email-Monk.Liu@amd.com> <01879d0d-edea-680e-c9f2-1005d94f1dfd@gmail.com> <3a8945f9-848e-dd19-373d-5dddc69f76cb@amd.com> <7af9b6fb-28e8-4e25-5d4a-5b566a00cbea@gmail.com> <6dedfc7f-cf69-676f-463d-be52cda1b1bb@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <6dedfc7f-cf69-676f-463d-be52cda1b1bb-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Koenig, Christian" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" PiBhbWRncHVfZXZpY3RfZmxhZ3MoKSBhbmQgYW1kZ3B1X2JvX21vdmUoKSBuZWVkcyB0byBrbm93 IGlmIHRoZSBTRE1BIHJpbmcgaXMgYXZhaWxhYmxlIGR1cmluZyBzdXNwZW5kL3Jlc3VtZS4NCg0K QXMgbG9uZyBhcyB3ZSBhcmUgaW4gZ3B1IHJlc2V0LCB3ZSBkb24ndCByZXR1cm4gZXJyb3Igd2hl biByaW5nIG5vdCByZWFkeSwgY3V6IGV2ZW50dWFsbHkgaXQgZWl0aGVyIHN1Y2Nlc3Mgb3IgZmFp bGVkIGFuZCByZXNjaGVkdWxlZCBieSBzY2hlZHVsZXIgc2luY2UgaXQgaXMga2VybmVsIGpvYg0K V2hhdCdzIHlvdXIgY29uY2VybiA/DQoNCi9Nb25rDQoNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCkZyb206IEtvZW5pZywgQ2hyaXN0aWFuIA0KU2VudDogMjAxOOW5tDPmnIgx5pelIDE2 OjQxDQpUbzogTGl1LCBNb25rIDxNb25rLkxpdUBhbWQuY29tPjsgYW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcNClN1YmplY3Q6IFJlOiBbUEFUQ0ggMy80XSBkcm0vYW1kZ3B1OiBkb24ndCBy ZXR1cm4gd2hlbiByaW5nIG5vdCByZWFkeSBmb3IgZmlsbF9idWZmZXINCg0KPiBJZiB3ZSBhcmUg aW4gZ3B1IHJlc3Qgc3RhZ2UsIHdlIGNhbiBsZXQgU0RNQSBqb2IgbGl2ZSB3aXRoIHRoZSBjYXNl IG9mIHJpbmcgbm90IHJlYWR5LCAgY2FuIHlvdSBwb2ludCBvdXQgd2hlcmUgaXMgdGhlIHByb2Js ZW0gPw0KYW1kZ3B1X2V2aWN0X2ZsYWdzKCkgYW5kIGFtZGdwdV9ib19tb3ZlKCkgbmVlZHMgdG8g a25vdyBpZiB0aGUgU0RNQSByaW5nIGlzIGF2YWlsYWJsZSBkdXJpbmcgc3VzcGVuZC9yZXN1bWUu DQoNCkUuZy4gc3VzcGVuZCB3b3JrcyBhcyB0aGlzOg0KMS4gRXZpY3QgYWxsIG5vcm1hbCBCT3Mg ZnJvbSBWUkFNIHVzaW5nIHRoZSBTRE1BLg0KMi4gRGlzYWJsZSBTRE1BLCBHQVJULCBQU1AgZXRj Li4uIGUuZy4gZGlzYWJsZSB0aGUgaGFyZHdhcmUuDQozLiBVbnBpbiBhbGwgQk9zIGluIFZSQU0g dXNlZCBieSBoYXJkd2FyZSBlbmdpbmVzLCBlLmcuIHRoZSBHQVJUIHRhYmxlLCBmaXJtd2FyZSBl dGMuLi4NCjQuIEV2aWN0IGFsbCByZW1haW5pbmcgQk9zIGZyb20gVlJBTSB1c2luZyBDUFUgY29w aWVzLg0KDQpSZXN1bWUgd29ya3MgdGhlIG90aGVyIHdheSBhcm91bmQ6DQoxLiBNb3ZlIGFsbCBC T3MgZm9yIEdBUlQgdGFibGUgYW5kIGZpcm13YXJlIGJhY2sgaW50byBWUkFNIHVzaW5nIENQVSBj b3BpZXMuDQoyLiBQaW4gdGhvc2UgQk9zIGluIFZSQU0gYW5kIGVuYWJsZSB0aGUgaGFyZHdhcmUu DQozLiBVc2UgdGhlIFNETUEgdG8gbW92ZSBiYWNrIGFsbCBvdGhlciBCT3MgaW50byBWUkFNLg0K DQpUbyBmaWd1cmUgb3V0IGlmIHdlIHNob3VsZCB1c2UgdGhlIENQVSBjb3B5IG9yIHRoZSBTRE1B IHRoZSByaW5nLT5yZWFkeSBmbGFnIGlzIHVzZWQuIFNvIHJlbW92aW5nIHRoaXMgY2hlY2sgaXMg cmVhbGx5IGEgbm8tZ28gYmVjYXVzZSBpdCB3b3VsZCBicmVhayBzdXNwZW5kL3Jlc3VtZS4NCg0K VGhlIG9ubHkgb3RoZXIgYWx0ZXJuYXRpdmUgSSBjYW4gc2VlIGlzIHRvIGFkZCBhIHNlcGFyYXRl IGZsYWcgaW4gYW1kZ3B1X21tYW4gaWYgYnVmZmVyX2Z1bmNzIHNob3VsZCBiZSB1c2VkIG9yIG5v dC4gU2VlIGFsbCB0aGUgY2FsbGVycyBvZiBhbWRncHVfdHRtX3NldF9hY3RpdmVfdnJhbV9zaXpl KCkgYXMgd2VsbC4NCg0KU29tZXRoaW5nIGxpa2UgcmVuYW1pbmcgYW1kZ3B1X3R0bV9zZXRfYWN0 aXZlX3ZyYW1fc2l6ZSgpIGludG8NCmFtZGdwdV90dG1fc2V0X2J1ZmZlcl9mdW5jc19yZWFkKCkg YW5kIGlnbm9yaW5nIGFueSBjaGFuZ2UgaWYgZ3B1X3Jlc2V0IGlzIHNldC4NCg0KQlRXOiBDaGFu Z2luZyB0aGUgYWN0aXZlIFZSQU0gc2l6ZSBpbiBHUFUgcmVzZXQgaXMgcXVpdGUgYSBidWcgeW91 IHN0dW1ibGVkIG92ZXIgaGVyZSwgc28gdGhpcyByZWFsbHkgbmVlZHMgZml4aW5nIGFueXdheS4N Cg0KUmVnYXJkcywNCkNocmlzdGlhbi4NCg0KQW0gMDEuMDMuMjAxOCB1bSAwOToyMyBzY2hyaWVi IExpdSwgTW9uazoNCj4gQWNjZWxfd29ya2luZyBpcyBvbmx5IGZvciBHRlggcmluZywgSSBkb24n dCB0aGluayB0ZXN0IGl0IGlzIGFwcHJvcHJpYXRlIGZvciBTRE1BIGpvYnMgLi4uLg0KPg0KPiBJ ZiB3ZSBhcmUgaW4gZ3B1IHJlc3Qgc3RhZ2UsIHdlIGNhbiBsZXQgU0RNQSBqb2IgbGl2ZSB3aXRo IHRoZSBjYXNlIG9mIHJpbmcgbm90IHJlYWR5LCAgY2FuIHlvdSBwb2ludCBvdXQgd2hlcmUgaXMg dGhlIHByb2JsZW0gPw0KPg0KPiBJbiBmYWN0IHdlIGRpZCBzdHJlc3MgVERSIHRlc3Qgd2l0aCB0 aGlzIHBhdGNoIGFuZCBpdCBjYW4gcmVhbGx5IGZpeCANCj4gY291cGxlIG92ZXIga2lsbCBpc3N1 ZXMNCj4NCj4NCj4gL01vbmsNCj4NCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJv bTogQ2hyaXN0aWFuIEvDtm5pZyBbbWFpbHRvOmNrb2VuaWcubGVpY2h0enVtZXJrZW5AZ21haWwu Y29tXQ0KPiBTZW50OiAyMDE45bm0M+aciDHml6UgMTY6MTYNCj4gVG86IExpdSwgTW9uayA8TW9u ay5MaXVAYW1kLmNvbT47IEtvZW5pZywgQ2hyaXN0aWFuIA0KPiA8Q2hyaXN0aWFuLktvZW5pZ0Bh bWQuY29tPjsgYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCj4gU3ViamVjdDogUmU6IFtQ QVRDSCAzLzRdIGRybS9hbWRncHU6IGRvbid0IHJldHVybiB3aGVuIHJpbmcgbm90IHJlYWR5IA0K PiBmb3IgZmlsbF9idWZmZXINCj4NCj4gQWgsIGNyYXAgeWVhaCB0aGF0IHdvbid0IHdvcmsgc2lu Y2Ugd2UgZG9uJ3QgZnJlZSB0aGUgcmluZy4NCj4NCj4gS2V5IHBvaW50IGlzIHdlIG5lZWQgdG8g ZGlzdGluY3QgYmV0d2VlbiB0aGUgcmluZyBkb2Vzbid0IHdvcmsgdGVtcG9yYXJ5IGJlY2F1c2Ug d2UgYXJlIGluIGEgR1BVIHJlc2V0IGFuZCBpdCBkb2Vzbid0IHdvcmsgYXQgYWxsIGJlY2F1c2Ug d2UgYXJlIG1pc3NpbmcgZmlybXdhcmUgb3Igc3R1ZmYgbGlrZSB0aGF0Lg0KPg0KPiBBbmQgbm8s IGNoZWNraW5nIHRoZSBncHVfcmVzZXQgZmxhZyBpcyB0b3RhbGx5IHJhY3kgYW5kIGNhbid0IGJl IGRvbmUgZWl0aGVyLiBIb3cgYWJvdXQgY2hlY2tpbmcgYWNjZWxfd29ya2luZyBpbnN0ZWFkPw0K Pg0KPiBDaHJpc3RpYW4uDQo+DQo+IEFtIDAxLjAzLjIwMTggdW0gMDc6MDEgc2NocmllYiBMaXUs IE1vbms6DQo+Pj4gUGxlYXNlIGNoYW5nZSB0aGUgdGVzdCB0byB1c2UgcmluZy0+cmluZ19vYmog aW5zdGVhZCwgdGhpcyB3YXkgd2Ugc3RpbGwgYmFpbCBvdXQgaWYgc29tZWJvZHkgdHJpZXMgdG8g c3VibWl0IGNvbW1hbmRzIGJlZm9yZSB0aGUgcmluZyBpcyBldmVuIGFsbG9jYXRlZC4NCj4+IEkg ZG9uJ3QgdW5kZXJzdGFuZCBob3cgY291bGQgZmlsbF9idWZmZXIoKSBnZXQgcnVuIHVuZGVyIHRo ZSBjYXNlIHRoYXQgcmluZy0+cmluZ19vYmogaXMgbm90IGV2ZW4gYWxsb2NhdGVkIC4uLiB3aGVy ZSBpcyBzdWNoIGNhc2UgPw0KPj4NCj4+DQo+PiAvTW9uaw0KPj4NCj4+IC0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQo+PiBGcm9tOiBLb2VuaWcsIENocmlzdGlhbg0KPj4gU2VudDogMjAxOOW5 tDLmnIgyOOaXpSAyMDo0Ng0KPj4gVG86IExpdSwgTW9uayA8TW9uay5MaXVAYW1kLmNvbT47IGFt ZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQo+PiBTdWJqZWN0OiBSZTogW1BBVENIIDMvNF0g ZHJtL2FtZGdwdTogZG9uJ3QgcmV0dXJuIHdoZW4gcmluZyBub3QgcmVhZHkgDQo+PiBmb3IgZmls bF9idWZmZXINCj4+DQo+PiBHb29kIHBvaW50LCBidXQgaW4gdGhpcyBjYXNlIHdlIG5lZWQgc29t ZSBvdGhlciBoYW5kbGluZy4NCj4+DQo+PiBQbGVhc2UgY2hhbmdlIHRoZSB0ZXN0IHRvIHVzZSBy aW5nLT5yaW5nX29iaiBpbnN0ZWFkLCB0aGlzIHdheSB3ZSBzdGlsbCBiYWlsIG91dCBpZiBzb21l Ym9keSB0cmllcyB0byBzdWJtaXQgY29tbWFuZHMgYmVmb3JlIHRoZSByaW5nIGlzIGV2ZW4gYWxs b2NhdGVkLg0KPj4NCj4+IEFuZCB5b3UgYWxzbyBuZWVkIHRvIGZpeCBhIGNvdXBsZSBvZiBvdGhl ciBwbGFjZXMgaW4gYW1kZ3B1X3R0bS5jLg0KPj4NCj4+IFJlZ2FyZHMsDQo+PiBDaHJpc3RpYW4u DQo+Pg0KPj4gQW0gMjguMDIuMjAxOCB1bSAxMzozNCBzY2hyaWViIExpdSwgTW9uazoNCj4+PiBC ZWNhdXNlIHdoZW4gU0RNQSB3YXMgaGFuZyBieSBsaWtlIHByb2Nlc3MgQSwgYW5kIG1lYW53aGls ZSBhbm90aGVyIA0KPj4+IHByb2Nlc3MgQiBpcyBhbHJlYWR5IHJ1bm5pbmcgaW50byB0aGUgY29k ZSBvZiBmaWxsX2J1ZmZlcigpIFNvIGp1c3QgbGV0IHByb2Nlc3MgQiBjb250aW51ZSwgZG9uJ3Qg YmxvY2sgaXQgb3RoZXJ3aXNlIHByb2Nlc3MgQiB3b3VsZCBmYWlsIGJ5IHNvZnR3YXJlIHJlYXNv biAuDQo+Pj4NCj4+PiBMZXQgaXQgcnVuIGFuZCBmaW5hbGx5IHByb2Nlc3MgQidzIGpvYiB3b3Vs ZCBmYWlsIGFuZCBHUFUgcmVjb3ZlciANCj4+PiB3aWxsIHJlcGVhdCBpdCBhZ2FpbiAoc2luY2Ug aXQgaXMgYSBrZXJuZWwgam9iKQ0KPj4+DQo+Pj4gV2l0aG91dCB0aGlzIHNvbHV0aW9uIG90aGVy IHByb2Nlc3Mgd2lsbCBiZSBncmVhdGx5IGhhcm1lZCBieSBvbmUgDQo+Pj4gYmxhY2sgc2hlZXAg dGhhdCB0cmlnZ2VyaW5nIEdQVSByZWNvdmVyDQo+Pj4NCj4+PiAvTW9uaw0KPj4+DQo+Pj4NCj4+ Pg0KPj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+Pj4gRnJvbTogQ2hyaXN0aWFuIEvD tm5pZyBbbWFpbHRvOmNrb2VuaWcubGVpY2h0enVtZXJrZW5AZ21haWwuY29tXQ0KPj4+IFNlbnQ6 IDIwMTjlubQy5pyIMjjml6UgMjA6MjQNCj4+PiBUbzogTGl1LCBNb25rIDxNb25rLkxpdUBhbWQu Y29tPjsgYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCj4+PiBTdWJqZWN0OiBSZTogW1BB VENIIDMvNF0gZHJtL2FtZGdwdTogZG9uJ3QgcmV0dXJuIHdoZW4gcmluZyBub3QgDQo+Pj4gcmVh ZHkgZm9yIGZpbGxfYnVmZmVyDQo+Pj4NCj4+PiBBbSAyOC4wMi4yMDE4IHVtIDA4OjIxIHNjaHJp ZWIgTW9uayBMaXU6DQo+Pj4+IGJlY2F1c2UgdGhpcyB0aW1lIFNETUEgbWF5IHVuZGVyIEdQVSBS RVNFVCBzbyBpdHMgcmluZy0+cmVhZHkgbWF5IA0KPj4+PiBub3QgdHJ1ZSwga2VlcCBnb2luZyBh bmQgR1BVIHNjaGVkdWxlciB3aWxsIHJlc2NoZWR1bGUgdGhpcyBqb2IgaWYgDQo+Pj4+IGl0IGZh aWxlZC4NCj4+Pj4NCj4+Pj4gZ2l2ZSBhIHdhcm5pbmcgb24gY29weV9idWZmZXIgd2hlbiBnbyB0 aHJvdWdoIGRpcmVjdF9zdWJtaXQgd2hpbGUNCj4+Pj4gcmluZy0+cmVhZHkgaXMgZmFsc2UNCj4+ PiBOQUssIHRoYXQgdGVzdCBoYXMgYWxyZWFkeSBzYXZlZCB1cyBxdWl0ZSBhIGJ1bmNoIG9mIHRy b3VibGUgd2l0aCB0aGUgZmIgbGF5ZXIuDQo+Pj4NCj4+PiBXaHkgZXhhY3RseSBhcmUgeW91IHJ1 bm5pbmcgaW50byBpc3N1ZXMgd2l0aCB0aGF0Pw0KPj4+DQo+Pj4gQ2hyaXN0aWFuLg0KPj4+DQo+ Pj4+IENoYW5nZS1JZDogSWZlNmNkNTVlMGU4NDNkOTk5MDBlNWJlZDU0MTg0OTllODg2MzM2ODUN Cj4+Pj4gU2lnbmVkLW9mZi1ieTogTW9uayBMaXUgPE1vbmsuTGl1QGFtZC5jb20+DQo+Pj4+IC0t LQ0KPj4+PiAgICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyB8IDYg Ky0tLS0tDQo+Pj4+ICAgICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA1IGRlbGV0 aW9ucygtKQ0KPj4+Pg0KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X3R0bS5jDQo+Pj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X3R0bS5jDQo+Pj4+IGluZGV4IGUzOGU2ZGIuLjdiNzVhYzkgMTAwNjQ0DQo+Pj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYw0KPj4+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMNCj4+Pj4gQEAgLTE2NTYsNiArMTY1Niw3 IEBAIGludCBhbWRncHVfY29weV9idWZmZXIoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nLCB1aW50 NjRfdCBzcmNfb2Zmc2V0LA0KPj4+PiAgICAgIAlhbWRncHVfcmluZ19wYWRfaWIocmluZywgJmpv Yi0+aWJzWzBdKTsNCj4+Pj4gICAgICAJV0FSTl9PTihqb2ItPmlic1swXS5sZW5ndGhfZHcgPiBu dW1fZHcpOw0KPj4+PiAgICAgIAlpZiAoZGlyZWN0X3N1Ym1pdCkgew0KPj4+PiArCQlXQVJOX09O KCFyaW5nLT5yZWFkeSk7DQo+Pj4+ICAgICAgCQlyID0gYW1kZ3B1X2liX3NjaGVkdWxlKHJpbmcs IGpvYi0+bnVtX2licywgam9iLT5pYnMsDQo+Pj4+ICAgICAgCQkJCSAgICAgICBOVUxMLCBmZW5j ZSk7DQo+Pj4+ICAgICAgCQlqb2ItPmZlbmNlID0gZG1hX2ZlbmNlX2dldCgqZmVuY2UpOyBAQCAt MTY5MiwxMSArMTY5Myw2IEBAIA0KPj4+PiBpbnQgYW1kZ3B1X2ZpbGxfYnVmZmVyKHN0cnVjdCBh bWRncHVfYm8gKmJvLA0KPj4+PiAgICAgIAlzdHJ1Y3QgYW1kZ3B1X2pvYiAqam9iOw0KPj4+PiAg ICAgIAlpbnQgcjsNCj4+Pj4gICAgICANCj4+Pj4gLQlpZiAoIXJpbmctPnJlYWR5KSB7DQo+Pj4+ IC0JCURSTV9FUlJPUigiVHJ5aW5nIHRvIGNsZWFyIG1lbW9yeSB3aXRoIHJpbmcgdHVybmVkIG9m Zi5cbiIpOw0KPj4+PiAtCQlyZXR1cm4gLUVJTlZBTDsNCj4+Pj4gLQl9DQo+Pj4+IC0NCj4+Pj4g ICAgICAJaWYgKGJvLT50Ym8ubWVtLm1lbV90eXBlID09IFRUTV9QTF9UVCkgew0KPj4+PiAgICAg IAkJciA9IGFtZGdwdV90dG1fYWxsb2NfZ2FydCgmYm8tPnRibyk7DQo+Pj4+ICAgICAgCQlpZiAo cikNCj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+ PiBhbWQtZ2Z4IG1haWxpbmcgbGlzdA0KPj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcN Cj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdm eA0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQt Z2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK