All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Liu, Monk" <Monk.Liu-5C7GfCeVMHo@public.gmane.org>
To: "Koenig,
	Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>,
	"Deucher,
	Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
	"Mao, David" <David.Mao-5C7GfCeVMHo@public.gmane.org>
Cc: "Jin, Jian-Rong" <Jian-Rong.Jin-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: RE: deprecated register issues
Date: Wed, 7 Mar 2018 13:49:49 +0000	[thread overview]
Message-ID: <BLUPR12MB044941D93445D001B482655984D80@BLUPR12MB0449.namprd12.prod.outlook.com> (raw)
In-Reply-To: <0258a141-8849-623b-9949-de14026e76a8-5C7GfCeVMHo@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1683 bytes --]

+ UMD guys

Hi David

Do you know if GC_USER_RB_BACKEND_DISABLE is still exist for gfx9/vega10 ?

We found CC_RB_BACKEND_DISABLE was deprecated but looks it is still in use in kmd, so
I want to check with you both of above registers

Thanks
/Monk

From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Christian K?nig
Sent: 2018年3月7日 20:26
To: Liu, Monk <Monk.Liu@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: deprecated register issues

Hi Monk,

I honestly don't have the slightest idea why we are still accessing CC_RB_BACKEND_DISABLE. Maybe it still contains some useful values?

Key point was that we needed to stop accessing it all the time to avoid triggering problems.

Regards,
Christian.

Am 07.03.2018 um 13:11 schrieb Liu, Monk:

Hi Christian



I remember you and AlexD mentioned that a handful registers are deprecated for greenland (gfx9)

e.g. CC_RB_BACKEND_DISABLE



do you know why we still have this routine ?

static u32
gfx_v9_0_get_rb_active_bitmap(struct amdgpu_device *adev)

{

    u32 data, mask;



    data = RREG32_SOC15(GC,
0, mmCC_RB_BACKEND_DISABLE);

    data |= RREG32_SOC15(GC,
0, mmGC_USER_RB_BACKEND_DISABLE);



    data &= CC_RB_BACKEND_DISABLE__BACKEND_DISABLE_MASK;

    data >>= GC_USER_RB_BACKEND_DISABLE__BACKEND_DISABLE__SHIFT;



    mask = amdgpu_gfx_create_bitmask(adev->gfx.config.max_backends_per_se /

                     adev->gfx.config.max_sh_per_se);



    return (~data) & mask;

}



see that it still read CC_RB_BACKEND_DISABLE



thanks



/Monk




[-- Attachment #1.2: Type: text/html, Size: 17637 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-03-07 13:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 12:11 deprecated register issues Liu, Monk
     [not found] ` <BLUPR12MB04496DB9A508E4AEE114AF2484D80-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-07 12:25   ` Christian König
     [not found]     ` <0258a141-8849-623b-9949-de14026e76a8-5C7GfCeVMHo@public.gmane.org>
2018-03-07 13:49       ` Liu, Monk [this message]
     [not found]         ` <BLUPR12MB044941D93445D001B482655984D80-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-07 14:25           ` Mao, David
     [not found]             ` <58B0701E-D93F-417B-816C-0616F364789A-5C7GfCeVMHo@public.gmane.org>
2018-03-07 14:31               ` Christian König
     [not found]                 ` <8ccdd2af-4520-866b-9b55-fa41b05c1fa1-5C7GfCeVMHo@public.gmane.org>
2018-03-07 15:13                   ` Deucher, Alexander
     [not found]                     ` <DM5PR12MB1660D5E735D17FEEC2E5E51CF7D80-2J9CzHegvk9mP71xM+BsFwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-08  2:42                       ` Liu, Monk
     [not found]                         ` <BLUPR12MB04499E74336A32888737C2B584DF0-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-08  2:52                           ` Deucher, Alexander
     [not found]                             ` <BN6PR12MB165241AC2937FA73FE9E95C6F7DF0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-08  3:05                               ` Liu, Monk
     [not found]                                 ` <BLUPR12MB044941CA8B586506C47EF57184DF0-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-08  9:40                                   ` Christian König
     [not found]                                     ` <7e01679a-81fe-3e1d-9eb1-c7668145a87a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-03-08 10:03                                       ` Liu, Monk
     [not found]                                         ` <BLUPR12MB0449B325C1C6FA562915C4EA84DF0-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-08 10:11                                           ` Liu, Monk
     [not found]                                             ` <BLUPR12MB044982457323EEB3BFC1E39E84DF0-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-08 10:50                                               ` Christian König
     [not found]                                                 ` <3cebe4c6-3230-855d-abf2-df7c7bc2f861-5C7GfCeVMHo@public.gmane.org>
2018-03-09  2:59                                                   ` Liu, Monk
     [not found]                                                     ` <BLUPR12MB04496FDB34DF802EE66BF08684DE0-7LeqcoF/hwpTIQvHjXdJlwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-09  3:29                                                       ` Deucher, Alexander
     [not found]                                                         ` <BN6PR12MB16521216A47BC1FFC0414658F7DE0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-03-09  7:43                                                           ` Christian König
2018-03-09  9:33                                                           ` Liu, Monk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLUPR12MB044941D93445D001B482655984D80@BLUPR12MB0449.namprd12.prod.outlook.com \
    --to=monk.liu-5c7gfcevmho@public.gmane.org \
    --cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
    --cc=Christian.Koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=David.Mao-5C7GfCeVMHo@public.gmane.org \
    --cc=Jian-Rong.Jin-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.