From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liu, Monk" Subject: RE: [PATCH 06/18] drm/amdgpu/sriov:fix memory leak after gpu reset Date: Wed, 20 Sep 2017 02:27:21 +0000 Message-ID: References: <1505715122-23904-1-git-send-email-Monk.Liu@amd.com> <1505715122-23904-7-git-send-email-Monk.Liu@amd.com> <45fa4145-41a4-6186-4f35-4f3347bad601@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <45fa4145-41a4-6186-4f35-4f3347bad601-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Koenig, Christian" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" T2gsIEkgc2VlIHlvdXIgcG9pbnQsIGJ1dCB0aGF0IGFjdHVhbGx5IHByZXNlbnRzIGZvciBhIGNs ZWFudXAgcGF0Y2gsIGFuZCBtaW5lIGlzIHRvIGFkZCBhIGNvbmRpdGlvbiB0byBmaXggbWVtb3J5 IGxlYWssIEkgdGhpbmsgdGhleSBkaWZmZXJlbnQgcHVycG9zZSBhbmQgc2hvdWxkIGJlIHNlcGFy YXRlZCwNCg0KSSBjYW4gYWRkIG9uZSBtb3JlIHBhdGNoIHRvIGNsZWFudXAgaXQgd2l0aCB0aGF0 ICJjcmVhdGVfYm9fa2VuZWwiIHRvIG1ha2UgY29kZSBtb3JlIHRpZ2h0IGFuZCBjbGVhbg0KDQpC UiBNb25rDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBLb2VuaWcsIENocmlz dGlhbiANClNlbnQ6IDIwMTflubQ55pyIMTjml6UgMTk6MzUNClRvOiBMaXUsIE1vbmsgPE1vbmsu TGl1QGFtZC5jb20+OyBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0KU3ViamVjdDogUmU6 IFtQQVRDSCAwNi8xOF0gZHJtL2FtZGdwdS9zcmlvdjpmaXggbWVtb3J5IGxlYWsgYWZ0ZXIgZ3B1 IHJlc2V0DQoNCkFtIDE4LjA5LjIwMTcgdW0gMTI6NDcgc2NocmllYiBMaXUsIE1vbms6DQo+IEkg ZGlkbid0IGdldCB5b3VyIHBvaW50Li4uIGhvdyBjb3VsZCBib19jcmVhdGVfa2VybmVsIHNvbHZl IG15IGlzc3VlID8NCg0KSXQgZG9lc24ndCBzb2x2ZSB0aGUgdW5kZXJseWluZyBpc3N1ZSwgeW91 IGp1c3QgbmVlZCBsZXNzIGNvZGUgZm9yIHlvdXIgd29ya2Fyb3VuZC4NCg0KV2l0aCBib19jcmVh dGVfa2VybmVsIHlvdSBjYW4gZG8gY3JlYXRlL3Bpbi9rbWFwIGluIGp1c3Qgb25lIGZ1bmN0aW9u IGNhbGwuDQoNCj4NCj4gVGhlIHRoaW5nIGhlcmUgaXMgZHVyaW5nIGdwdSByZXNldCB3ZSBpbnZv a2UgaHdfaW5pdCBmb3IgZXZlcnkgaHcgDQo+IGNvbXBvbmVudCwgYW5kIGJ5IGRlc2lnbiBod19p bml0IHNob3VsZG4ndCBkb2luZyBhbnl0aGluZyBzb2Z0d2FyZSANCj4gcmVsYXRlZCwgdGh1cyB0 aGUgQk8gYWxsb2NhdGluZyBpbiBod19pbml0IGlzIHdyb25nLA0KDQpZZWFoLCBidXQgeW91ciBw YXRjaCBkb2Vzbid0IGZpeCB0aGF0IGVpdGhlciBhcyBmYXIgYXMgSSBjYW4gc2VlLg0KDQo+IEV2 ZW4gc3dpdGNoIHRvIGJvX2NyZWF0ZV9rZXJuZWwgd29uJ3QgYWRkcmVzcyB0aGUgaXNzdWUgLi4u DQoNClNlZSB0aGUgaW1wbGVtZW50YXRpb24gb2YgYm9fY3JlYXRlX2tlcm5lbCgpOg0KPiAgICAg ICAgIGlmICghKmJvX3B0cikgew0KPiAgICAgICAgICAgICAgICAgciA9IGFtZGdwdV9ib19jcmVh dGUoYWRldiwgc2l6ZSwgYWxpZ24sIHRydWUsIGRvbWFpbiwNCi4uLi4NCj4gICAgICAgICB9DQou Li4uDQo+ICAgICAgICAgciA9IGFtZGdwdV9ib19waW4oKmJvX3B0ciwgZG9tYWluLCBncHVfYWRk cik7DQouLi4NCj4gICAgICAgICBpZiAoY3B1X2FkZHIpIHsNCj4gICAgICAgICAgICAgICAgIHIg PSBhbWRncHVfYm9fa21hcCgqYm9fcHRyLCBjcHVfYWRkcik7DQouLi4NCj4gICAgICAgICB9DQoN CkNyZWF0aW5nIGlzIGFjdHVhbGx5IG9wdGlvbmFsLCBidXQgdGhlIGZ1bmN0aW9uIGFsd2F5cyBw aW5zIHRoZSBCTyBvbmNlIG1vcmUgYW5kIGZpZ3VyZXMgb3V0IGl0J3MgQ1BVIGFkZHJlc3MuDQoN CkFzIGZhciBhcyBJIGNhbiBzZWUgdGhhdCBzaG91bGQgc29sdmUgeW91ciBwcm9ibGVtIGZvciBu b3cuDQoNCkNocmlzdGlhbi4NCg0KDQo+DQo+DQo+IEJSIE1vbmsNCj4NCj4gLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQ2hyaXN0aWFuIEvDtm5pZyBbbWFpbHRvOmNrb2VuaWcu bGVpY2h0enVtZXJrZW5AZ21haWwuY29tXQ0KPiBTZW50OiAyMDE35bm0OeaciDE45pelIDE3OjEz DQo+IFRvOiBMaXUsIE1vbmsgPE1vbmsuTGl1QGFtZC5jb20+OyBhbWQtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDA2LzE4XSBkcm0vYW1kZ3B1L3NyaW92 OmZpeCBtZW1vcnkgbGVhayBhZnRlciBncHUgDQo+IHJlc2V0DQo+DQo+IEFtIDE4LjA5LjIwMTcg dW0gMDg6MTEgc2NocmllYiBNb25rIExpdToNCj4+IGRvaW5nIGdwdSByZXNldCB3aWxsIHJlcnVu IGFsbCBod19pbml0IGFuZCB0aHVzIHVjb2RlX2luaXRfYm8gaXMgDQo+PiBpbnZva2VkIGFnYWlu LCBzbyB3ZSBuZWVkIHRvIHNraXAgdGhlIGZ3X2J1ZiBhbGxvY2F0aW9uIGR1cmluZyBzcmlvdiAN Cj4+IGdwdSByZXNldCB0byBhdm9pZCBtZW1vcnkgbGVhay4NCj4+DQo+PiBDaGFuZ2UtSWQ6IEkz MTEzMWVkYTFiZDQ1ZWEyZjViZGM1MGM1ZGE1ZmM1YTlmZTkwMjdkDQo+PiBTaWduZWQtb2ZmLWJ5 OiBNb25rIExpdSA8TW9uay5MaXVAYW1kLmNvbT4NCj4+IC0tLQ0KPj4gICAgZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmggICAgICAgfCAgMyArKw0KPj4gICAgZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Vjb2RlLmMgfCA2NCArKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tDQo+PiAgICAyIGZpbGVzIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDMyIGRl bGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHUuaA0KPj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaA0KPj4g aW5kZXggNmZmMjk1OS4uM2QwYzYzMyAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdS5oDQo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHUuaA0KPj4gQEAgLTExODUsNiArMTE4NSw5IEBAIHN0cnVjdCBhbWRncHVfZmlybXdhcmUg ew0KPj4gICAgDQo+PiAgICAJLyogZ3B1IGluZm8gZmlybXdhcmUgZGF0YSBwb2ludGVyICovDQo+ PiAgICAJY29uc3Qgc3RydWN0IGZpcm13YXJlICpncHVfaW5mb19mdzsNCj4+ICsNCj4+ICsJdm9p ZCAqZndfYnVmX3B0cjsNCj4+ICsJdWludDY0X3QgZndfYnVmX21jOw0KPj4gICAgfTsNCj4+ICAg IA0KPj4gICAgLyoNCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfdWNvZGUuYw0KPj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdWNv ZGUuYw0KPj4gaW5kZXggZjMwNjM3NC4uNjU2NDkwMiAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jDQo+PiArKysgYi9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGdwdS9hbWRncHVfdWNvZGUuYw0KPj4gQEAgLTM2MCw4ICszNjAsNiBAQCBzdGF0 aWMgaW50IGFtZGdwdV91Y29kZV9wYXRjaF9qdChzdHJ1Y3QgYW1kZ3B1X2Zpcm13YXJlX2luZm8g KnVjb2RlLA0KPj4gICAgaW50IGFtZGdwdV91Y29kZV9pbml0X2JvKHN0cnVjdCBhbWRncHVfZGV2 aWNlICphZGV2KQ0KPj4gICAgew0KPj4gICAgCXN0cnVjdCBhbWRncHVfYm8gKipibyA9ICZhZGV2 LT5maXJtd2FyZS5md19idWY7DQo+PiAtCXVpbnQ2NF90IGZ3X21jX2FkZHI7DQo+PiAtCXZvaWQg KmZ3X2J1Zl9wdHIgPSBOVUxMOw0KPj4gICAgCXVpbnQ2NF90IGZ3X29mZnNldCA9IDA7DQo+PiAg ICAJaW50IGksIGVycjsNCj4+ICAgIAlzdHJ1Y3QgYW1kZ3B1X2Zpcm13YXJlX2luZm8gKnVjb2Rl ID0gTlVMTDsgQEAgLTM3MiwzNyArMzcwLDM5IEBAIA0KPj4gaW50IGFtZGdwdV91Y29kZV9pbml0 X2JvKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQ0KPj4gICAgCQlyZXR1cm4gMDsNCj4+ICAg IAl9DQo+PiAgICANCj4+IC0JZXJyID0gYW1kZ3B1X2JvX2NyZWF0ZShhZGV2LCBhZGV2LT5maXJt d2FyZS5md19zaXplLCBQQUdFX1NJWkUsIHRydWUsDQo+PiAtCQkJCWFtZGdwdV9zcmlvdl92Zihh ZGV2KSA/IEFNREdQVV9HRU1fRE9NQUlOX1ZSQU0gOiBBTURHUFVfR0VNX0RPTUFJTl9HVFQsDQo+ PiAtCQkJCUFNREdQVV9HRU1fQ1JFQVRFX1ZSQU1fQ09OVElHVU9VUywNCj4+IC0JCQkJTlVMTCwg TlVMTCwgMCwgYm8pOw0KPj4gLQlpZiAoZXJyKSB7DQo+PiAtCQlkZXZfZXJyKGFkZXYtPmRldiwg IiglZCkgRmlybXdhcmUgYnVmZmVyIGFsbG9jYXRlIGZhaWxlZFxuIiwgZXJyKTsNCj4+IC0JCWdv dG8gZmFpbGVkOw0KPj4gLQl9DQo+PiArCWlmICghYW1kZ3B1X3NyaW92X3ZmKGFkZXYpIHx8ICFh ZGV2LT5pbl9zcmlvdl9yZXNldCkgew0KPiBJbnN0ZWFkIG9mIGFsbCB0aGlzIGJldHRlciB1c2Ug YW1kZ3B1X2JvX2NyZWF0ZV9rZXJuZWwoKSwgdGhpcyBzaG91bGQgYWxyZWFkeSBpbmNsdWRlIG1v c3Qgb2YgdGhlIGhhbmRsaW5nIG5lY2Vzc2FyeSBoZXJlLg0KPg0KPiBDaHJpc3RpYW4uDQo+DQo+ PiArCQllcnIgPSBhbWRncHVfYm9fY3JlYXRlKGFkZXYsIGFkZXYtPmZpcm13YXJlLmZ3X3NpemUs IFBBR0VfU0laRSwgdHJ1ZSwNCj4+ICsJCQkJCWFtZGdwdV9zcmlvdl92ZihhZGV2KSA/IEFNREdQ VV9HRU1fRE9NQUlOX1ZSQU0gOiBBTURHUFVfR0VNX0RPTUFJTl9HVFQsDQo+PiArCQkJCQlBTURH UFVfR0VNX0NSRUFURV9WUkFNX0NPTlRJR1VPVVMsDQo+PiArCQkJCQlOVUxMLCBOVUxMLCAwLCBi byk7DQo+PiArCQlpZiAoZXJyKSB7DQo+PiArCQkJZGV2X2VycihhZGV2LT5kZXYsICIoJWQpIEZp cm13YXJlIGJ1ZmZlciBhbGxvY2F0ZSBmYWlsZWRcbiIsIGVycik7DQo+PiArCQkJZ290byBmYWls ZWQ7DQo+PiArCQl9DQo+PiAgICANCj4+IC0JZXJyID0gYW1kZ3B1X2JvX3Jlc2VydmUoKmJvLCBm YWxzZSk7DQo+PiAtCWlmIChlcnIpIHsNCj4+IC0JCWRldl9lcnIoYWRldi0+ZGV2LCAiKCVkKSBG aXJtd2FyZSBidWZmZXIgcmVzZXJ2ZSBmYWlsZWRcbiIsIGVycik7DQo+PiAtCQlnb3RvIGZhaWxl ZF9yZXNlcnZlOw0KPj4gLQl9DQo+PiArCQllcnIgPSBhbWRncHVfYm9fcmVzZXJ2ZSgqYm8sIGZh bHNlKTsNCj4+ICsJCWlmIChlcnIpIHsNCj4+ICsJCQlkZXZfZXJyKGFkZXYtPmRldiwgIiglZCkg RmlybXdhcmUgYnVmZmVyIHJlc2VydmUgZmFpbGVkXG4iLCBlcnIpOw0KPj4gKwkJCWdvdG8gZmFp bGVkX3Jlc2VydmU7DQo+PiArCQl9DQo+PiAgICANCj4+IC0JZXJyID0gYW1kZ3B1X2JvX3Bpbigq Ym8sIGFtZGdwdV9zcmlvdl92ZihhZGV2KSA/IEFNREdQVV9HRU1fRE9NQUlOX1ZSQU0gOiBBTURH UFVfR0VNX0RPTUFJTl9HVFQsDQo+PiAtCQkJCSZmd19tY19hZGRyKTsNCj4+IC0JaWYgKGVycikg ew0KPj4gLQkJZGV2X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciBwaW4gZmFp bGVkXG4iLCBlcnIpOw0KPj4gLQkJZ290byBmYWlsZWRfcGluOw0KPj4gLQl9DQo+PiArCQllcnIg PSBhbWRncHVfYm9fcGluKCpibywgYW1kZ3B1X3NyaW92X3ZmKGFkZXYpID8gQU1ER1BVX0dFTV9E T01BSU5fVlJBTSA6IEFNREdQVV9HRU1fRE9NQUlOX0dUVCwNCj4+ICsJCQkJCSZhZGV2LT5maXJt d2FyZS5md19idWZfbWMpOw0KPj4gKwkJaWYgKGVycikgew0KPj4gKwkJCWRldl9lcnIoYWRldi0+ ZGV2LCAiKCVkKSBGaXJtd2FyZSBidWZmZXIgcGluIGZhaWxlZFxuIiwgZXJyKTsNCj4+ICsJCQln b3RvIGZhaWxlZF9waW47DQo+PiArCQl9DQo+PiAgICANCj4+IC0JZXJyID0gYW1kZ3B1X2JvX2tt YXAoKmJvLCAmZndfYnVmX3B0cik7DQo+PiAtCWlmIChlcnIpIHsNCj4+IC0JCWRldl9lcnIoYWRl di0+ZGV2LCAiKCVkKSBGaXJtd2FyZSBidWZmZXIga21hcCBmYWlsZWRcbiIsIGVycik7DQo+PiAt CQlnb3RvIGZhaWxlZF9rbWFwOw0KPj4gLQl9DQo+PiArCQllcnIgPSBhbWRncHVfYm9fa21hcCgq Ym8sICZhZGV2LT5maXJtd2FyZS5md19idWZfcHRyKTsNCj4+ICsJCWlmIChlcnIpIHsNCj4+ICsJ CQlkZXZfZXJyKGFkZXYtPmRldiwgIiglZCkgRmlybXdhcmUgYnVmZmVyIGttYXAgZmFpbGVkXG4i LCBlcnIpOw0KPj4gKwkJCWdvdG8gZmFpbGVkX2ttYXA7DQo+PiArCQl9DQo+PiAgICANCj4+IC0J YW1kZ3B1X2JvX3VucmVzZXJ2ZSgqYm8pOw0KPj4gKwkJYW1kZ3B1X2JvX3VucmVzZXJ2ZSgqYm8p Ow0KPj4gKwl9DQo+PiAgICANCj4+IC0JbWVtc2V0KGZ3X2J1Zl9wdHIsIDAsIGFkZXYtPmZpcm13 YXJlLmZ3X3NpemUpOw0KPj4gKwltZW1zZXQoYWRldi0+ZmlybXdhcmUuZndfYnVmX3B0ciwgMCwg YWRldi0+ZmlybXdhcmUuZndfc2l6ZSk7DQo+PiAgICANCj4+ICAgIAkvKg0KPj4gICAgCSAqIGlm IFNNVSBsb2FkZWQgZmlybXdhcmUsIGl0IG5lZWRuJ3QgYWRkIFNNQywgVVZELCBhbmQgVkNFIEBA DQo+PiAtNDIxLDE0ICs0MjEsMTQgQEAgaW50IGFtZGdwdV91Y29kZV9pbml0X2JvKHN0cnVjdCBh bWRncHVfZGV2aWNlICphZGV2KQ0KPj4gICAgCQl1Y29kZSA9ICZhZGV2LT5maXJtd2FyZS51Y29k ZVtpXTsNCj4+ICAgIAkJaWYgKHVjb2RlLT5mdykgew0KPj4gICAgCQkJaGVhZGVyID0gKGNvbnN0 IHN0cnVjdCBjb21tb25fZmlybXdhcmVfaGVhZGVyICopdWNvZGUtPmZ3LT5kYXRhOw0KPj4gLQkJ CWFtZGdwdV91Y29kZV9pbml0X3NpbmdsZV9mdyhhZGV2LCB1Y29kZSwgZndfbWNfYWRkciArIGZ3 X29mZnNldCwNCj4+IC0JCQkJCQkgICAgKHZvaWQgKikoKHVpbnQ4X3QgKilmd19idWZfcHRyICsg Zndfb2Zmc2V0KSk7DQo+PiArCQkJYW1kZ3B1X3Vjb2RlX2luaXRfc2luZ2xlX2Z3KGFkZXYsIHVj b2RlLCBhZGV2LT5maXJtd2FyZS5md19idWZfbWMgKyBmd19vZmZzZXQsDQo+PiArCQkJCQkJICAg IGFkZXYtPmZpcm13YXJlLmZ3X2J1Zl9wdHIgKyBmd19vZmZzZXQpOw0KPj4gICAgCQkJaWYgKGkg PT0gQU1ER1BVX1VDT0RFX0lEX0NQX01FQzEgJiYNCj4+ICAgIAkJCSAgICBhZGV2LT5maXJtd2Fy ZS5sb2FkX3R5cGUgIT0gQU1ER1BVX0ZXX0xPQURfUFNQKSB7DQo+PiAgICAJCQkJY29uc3Qgc3Ry dWN0IGdmeF9maXJtd2FyZV9oZWFkZXJfdjFfMCAqY3BfaGRyOw0KPj4gICAgCQkJCWNwX2hkciA9 IChjb25zdCBzdHJ1Y3QgZ2Z4X2Zpcm13YXJlX2hlYWRlcl92MV8wICopdWNvZGUtPmZ3LT5kYXRh Ow0KPj4gLQkJCQlhbWRncHVfdWNvZGVfcGF0Y2hfanQodWNvZGUsIGZ3X21jX2FkZHIgKyBmd19v ZmZzZXQsDQo+PiAtCQkJCQkJICAgIGZ3X2J1Zl9wdHIgKyBmd19vZmZzZXQpOw0KPj4gKwkJCQlh bWRncHVfdWNvZGVfcGF0Y2hfanQodWNvZGUsICBhZGV2LT5maXJtd2FyZS5md19idWZfbWMgKyBm d19vZmZzZXQsDQo+PiArCQkJCQkJICAgIGFkZXYtPmZpcm13YXJlLmZ3X2J1Zl9wdHIgKyBmd19v ZmZzZXQpOw0KPj4gICAgCQkJCWZ3X29mZnNldCArPSBBTElHTihsZTMyX3RvX2NwdShjcF9oZHIt Pmp0X3NpemUpIDw8IDIsIFBBR0VfU0laRSk7DQo+PiAgICAJCQl9DQo+PiAgICAJCQlmd19vZmZz ZXQgKz0gQUxJR04odWNvZGUtPnVjb2RlX3NpemUsIFBBR0VfU0laRSk7DQo+DQoNCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBs aXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=