From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liu, Monk" Subject: RE: [PATCH 06/18] drm/amdgpu/sriov:fix memory leak after gpu reset Date: Mon, 18 Sep 2017 10:47:17 +0000 Message-ID: References: <1505715122-23904-1-git-send-email-Monk.Liu@amd.com> <1505715122-23904-7-git-send-email-Monk.Liu@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Koenig, Christian" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" SSBkaWRuJ3QgZ2V0IHlvdXIgcG9pbnQuLi4gaG93IGNvdWxkIGJvX2NyZWF0ZV9rZXJuZWwgc29s dmUgbXkgaXNzdWUgPw0KDQpUaGUgdGhpbmcgaGVyZSBpcyBkdXJpbmcgZ3B1IHJlc2V0IHdlIGlu dm9rZSBod19pbml0IGZvciBldmVyeSBodyBjb21wb25lbnQsIGFuZCBieSBkZXNpZ24gaHdfaW5p dCBzaG91bGRuJ3QgZG9pbmcgYW55dGhpbmcgc29mdHdhcmUgcmVsYXRlZCwgdGh1cyB0aGUgQk8g YWxsb2NhdGluZyBpbiBod19pbml0IGlzIHdyb25nLA0KDQpFdmVuIHN3aXRjaCB0byBib19jcmVh dGVfa2VybmVsIHdvbid0IGFkZHJlc3MgdGhlIGlzc3VlIC4uLg0KDQoNCkJSIE1vbmsNCg0KLS0t LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IENocmlzdGlhbiBLw7ZuaWcgW21haWx0bzpj a29lbmlnLmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbV0gDQpTZW50OiAyMDE35bm0OeaciDE45pel IDE3OjEzDQpUbzogTGl1LCBNb25rIDxNb25rLkxpdUBhbWQuY29tPjsgYW1kLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcNClN1YmplY3Q6IFJlOiBbUEFUQ0ggMDYvMThdIGRybS9hbWRncHUvc3Jp b3Y6Zml4IG1lbW9yeSBsZWFrIGFmdGVyIGdwdSByZXNldA0KDQpBbSAxOC4wOS4yMDE3IHVtIDA4 OjExIHNjaHJpZWIgTW9uayBMaXU6DQo+IGRvaW5nIGdwdSByZXNldCB3aWxsIHJlcnVuIGFsbCBo d19pbml0IGFuZCB0aHVzIHVjb2RlX2luaXRfYm8gaXMgDQo+IGludm9rZWQgYWdhaW4sIHNvIHdl IG5lZWQgdG8gc2tpcCB0aGUgZndfYnVmIGFsbG9jYXRpb24gZHVyaW5nIHNyaW92IA0KPiBncHUg cmVzZXQgdG8gYXZvaWQgbWVtb3J5IGxlYWsuDQo+DQo+IENoYW5nZS1JZDogSTMxMTMxZWRhMWJk NDVlYTJmNWJkYzUwYzVkYTVmYzVhOWZlOTAyN2QNCj4gU2lnbmVkLW9mZi1ieTogTW9uayBMaXUg PE1vbmsuTGl1QGFtZC5jb20+DQo+IC0tLQ0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdS5oICAgICAgIHwgIDMgKysNCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfdWNvZGUuYyB8IDY0ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0NCj4gICAy IGZpbGVzIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDMyIGRlbGV0aW9ucygtKQ0KPg0KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmggDQo+IGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgNCj4gaW5kZXggNmZmMjk1OS4uM2QwYzYz MyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgNCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgNCj4gQEAgLTExODUsNiAr MTE4NSw5IEBAIHN0cnVjdCBhbWRncHVfZmlybXdhcmUgew0KPiAgIA0KPiAgIAkvKiBncHUgaW5m byBmaXJtd2FyZSBkYXRhIHBvaW50ZXIgKi8NCj4gICAJY29uc3Qgc3RydWN0IGZpcm13YXJlICpn cHVfaW5mb19mdzsNCj4gKw0KPiArCXZvaWQgKmZ3X2J1Zl9wdHI7DQo+ICsJdWludDY0X3QgZndf YnVmX21jOw0KPiAgIH07DQo+ICAgDQo+ICAgLyoNCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jIA0KPiBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV91Y29kZS5jDQo+IGluZGV4IGYzMDYzNzQuLjY1NjQ5MDIgMTAwNjQ0DQo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jDQo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jDQo+IEBAIC0zNjAsOCAr MzYwLDYgQEAgc3RhdGljIGludCBhbWRncHVfdWNvZGVfcGF0Y2hfanQoc3RydWN0IGFtZGdwdV9m aXJtd2FyZV9pbmZvICp1Y29kZSwNCj4gICBpbnQgYW1kZ3B1X3Vjb2RlX2luaXRfYm8oc3RydWN0 IGFtZGdwdV9kZXZpY2UgKmFkZXYpDQo+ICAgew0KPiAgIAlzdHJ1Y3QgYW1kZ3B1X2JvICoqYm8g PSAmYWRldi0+ZmlybXdhcmUuZndfYnVmOw0KPiAtCXVpbnQ2NF90IGZ3X21jX2FkZHI7DQo+IC0J dm9pZCAqZndfYnVmX3B0ciA9IE5VTEw7DQo+ICAgCXVpbnQ2NF90IGZ3X29mZnNldCA9IDA7DQo+ ICAgCWludCBpLCBlcnI7DQo+ICAgCXN0cnVjdCBhbWRncHVfZmlybXdhcmVfaW5mbyAqdWNvZGUg PSBOVUxMOyBAQCAtMzcyLDM3ICszNzAsMzkgQEAgDQo+IGludCBhbWRncHVfdWNvZGVfaW5pdF9i byhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikNCj4gICAJCXJldHVybiAwOw0KPiAgIAl9DQo+ ICAgDQo+IC0JZXJyID0gYW1kZ3B1X2JvX2NyZWF0ZShhZGV2LCBhZGV2LT5maXJtd2FyZS5md19z aXplLCBQQUdFX1NJWkUsIHRydWUsDQo+IC0JCQkJYW1kZ3B1X3NyaW92X3ZmKGFkZXYpID8gQU1E R1BVX0dFTV9ET01BSU5fVlJBTSA6IEFNREdQVV9HRU1fRE9NQUlOX0dUVCwNCj4gLQkJCQlBTURH UFVfR0VNX0NSRUFURV9WUkFNX0NPTlRJR1VPVVMsDQo+IC0JCQkJTlVMTCwgTlVMTCwgMCwgYm8p Ow0KPiAtCWlmIChlcnIpIHsNCj4gLQkJZGV2X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJl IGJ1ZmZlciBhbGxvY2F0ZSBmYWlsZWRcbiIsIGVycik7DQo+IC0JCWdvdG8gZmFpbGVkOw0KPiAt CX0NCj4gKwlpZiAoIWFtZGdwdV9zcmlvdl92ZihhZGV2KSB8fCAhYWRldi0+aW5fc3Jpb3ZfcmVz ZXQpIHsNCg0KSW5zdGVhZCBvZiBhbGwgdGhpcyBiZXR0ZXIgdXNlIGFtZGdwdV9ib19jcmVhdGVf a2VybmVsKCksIHRoaXMgc2hvdWxkIGFscmVhZHkgaW5jbHVkZSBtb3N0IG9mIHRoZSBoYW5kbGlu ZyBuZWNlc3NhcnkgaGVyZS4NCg0KQ2hyaXN0aWFuLg0KDQo+ICsJCWVyciA9IGFtZGdwdV9ib19j cmVhdGUoYWRldiwgYWRldi0+ZmlybXdhcmUuZndfc2l6ZSwgUEFHRV9TSVpFLCB0cnVlLA0KPiAr CQkJCQlhbWRncHVfc3Jpb3ZfdmYoYWRldikgPyBBTURHUFVfR0VNX0RPTUFJTl9WUkFNIDogQU1E R1BVX0dFTV9ET01BSU5fR1RULA0KPiArCQkJCQlBTURHUFVfR0VNX0NSRUFURV9WUkFNX0NPTlRJ R1VPVVMsDQo+ICsJCQkJCU5VTEwsIE5VTEwsIDAsIGJvKTsNCj4gKwkJaWYgKGVycikgew0KPiAr CQkJZGV2X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciBhbGxvY2F0ZSBmYWls ZWRcbiIsIGVycik7DQo+ICsJCQlnb3RvIGZhaWxlZDsNCj4gKwkJfQ0KPiAgIA0KPiAtCWVyciA9 IGFtZGdwdV9ib19yZXNlcnZlKCpibywgZmFsc2UpOw0KPiAtCWlmIChlcnIpIHsNCj4gLQkJZGV2 X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciByZXNlcnZlIGZhaWxlZFxuIiwg ZXJyKTsNCj4gLQkJZ290byBmYWlsZWRfcmVzZXJ2ZTsNCj4gLQl9DQo+ICsJCWVyciA9IGFtZGdw dV9ib19yZXNlcnZlKCpibywgZmFsc2UpOw0KPiArCQlpZiAoZXJyKSB7DQo+ICsJCQlkZXZfZXJy KGFkZXYtPmRldiwgIiglZCkgRmlybXdhcmUgYnVmZmVyIHJlc2VydmUgZmFpbGVkXG4iLCBlcnIp Ow0KPiArCQkJZ290byBmYWlsZWRfcmVzZXJ2ZTsNCj4gKwkJfQ0KPiAgIA0KPiAtCWVyciA9IGFt ZGdwdV9ib19waW4oKmJvLCBhbWRncHVfc3Jpb3ZfdmYoYWRldikgPyBBTURHUFVfR0VNX0RPTUFJ Tl9WUkFNIDogQU1ER1BVX0dFTV9ET01BSU5fR1RULA0KPiAtCQkJCSZmd19tY19hZGRyKTsNCj4g LQlpZiAoZXJyKSB7DQo+IC0JCWRldl9lcnIoYWRldi0+ZGV2LCAiKCVkKSBGaXJtd2FyZSBidWZm ZXIgcGluIGZhaWxlZFxuIiwgZXJyKTsNCj4gLQkJZ290byBmYWlsZWRfcGluOw0KPiAtCX0NCj4g KwkJZXJyID0gYW1kZ3B1X2JvX3BpbigqYm8sIGFtZGdwdV9zcmlvdl92ZihhZGV2KSA/IEFNREdQ VV9HRU1fRE9NQUlOX1ZSQU0gOiBBTURHUFVfR0VNX0RPTUFJTl9HVFQsDQo+ICsJCQkJCSZhZGV2 LT5maXJtd2FyZS5md19idWZfbWMpOw0KPiArCQlpZiAoZXJyKSB7DQo+ICsJCQlkZXZfZXJyKGFk ZXYtPmRldiwgIiglZCkgRmlybXdhcmUgYnVmZmVyIHBpbiBmYWlsZWRcbiIsIGVycik7DQo+ICsJ CQlnb3RvIGZhaWxlZF9waW47DQo+ICsJCX0NCj4gICANCj4gLQllcnIgPSBhbWRncHVfYm9fa21h cCgqYm8sICZmd19idWZfcHRyKTsNCj4gLQlpZiAoZXJyKSB7DQo+IC0JCWRldl9lcnIoYWRldi0+ ZGV2LCAiKCVkKSBGaXJtd2FyZSBidWZmZXIga21hcCBmYWlsZWRcbiIsIGVycik7DQo+IC0JCWdv dG8gZmFpbGVkX2ttYXA7DQo+IC0JfQ0KPiArCQllcnIgPSBhbWRncHVfYm9fa21hcCgqYm8sICZh ZGV2LT5maXJtd2FyZS5md19idWZfcHRyKTsNCj4gKwkJaWYgKGVycikgew0KPiArCQkJZGV2X2Vy cihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciBrbWFwIGZhaWxlZFxuIiwgZXJyKTsN Cj4gKwkJCWdvdG8gZmFpbGVkX2ttYXA7DQo+ICsJCX0NCj4gICANCj4gLQlhbWRncHVfYm9fdW5y ZXNlcnZlKCpibyk7DQo+ICsJCWFtZGdwdV9ib191bnJlc2VydmUoKmJvKTsNCj4gKwl9DQo+ICAg DQo+IC0JbWVtc2V0KGZ3X2J1Zl9wdHIsIDAsIGFkZXYtPmZpcm13YXJlLmZ3X3NpemUpOw0KPiAr CW1lbXNldChhZGV2LT5maXJtd2FyZS5md19idWZfcHRyLCAwLCBhZGV2LT5maXJtd2FyZS5md19z aXplKTsNCj4gICANCj4gICAJLyoNCj4gICAJICogaWYgU01VIGxvYWRlZCBmaXJtd2FyZSwgaXQg bmVlZG4ndCBhZGQgU01DLCBVVkQsIGFuZCBWQ0UgQEAgDQo+IC00MjEsMTQgKzQyMSwxNCBAQCBp bnQgYW1kZ3B1X3Vjb2RlX2luaXRfYm8oc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpDQo+ICAg CQl1Y29kZSA9ICZhZGV2LT5maXJtd2FyZS51Y29kZVtpXTsNCj4gICAJCWlmICh1Y29kZS0+Zncp IHsNCj4gICAJCQloZWFkZXIgPSAoY29uc3Qgc3RydWN0IGNvbW1vbl9maXJtd2FyZV9oZWFkZXIg Kil1Y29kZS0+ZnctPmRhdGE7DQo+IC0JCQlhbWRncHVfdWNvZGVfaW5pdF9zaW5nbGVfZncoYWRl diwgdWNvZGUsIGZ3X21jX2FkZHIgKyBmd19vZmZzZXQsDQo+IC0JCQkJCQkgICAgKHZvaWQgKiko KHVpbnQ4X3QgKilmd19idWZfcHRyICsgZndfb2Zmc2V0KSk7DQo+ICsJCQlhbWRncHVfdWNvZGVf aW5pdF9zaW5nbGVfZncoYWRldiwgdWNvZGUsIGFkZXYtPmZpcm13YXJlLmZ3X2J1Zl9tYyArIGZ3 X29mZnNldCwNCj4gKwkJCQkJCSAgICBhZGV2LT5maXJtd2FyZS5md19idWZfcHRyICsgZndfb2Zm c2V0KTsNCj4gICAJCQlpZiAoaSA9PSBBTURHUFVfVUNPREVfSURfQ1BfTUVDMSAmJg0KPiAgIAkJ CSAgICBhZGV2LT5maXJtd2FyZS5sb2FkX3R5cGUgIT0gQU1ER1BVX0ZXX0xPQURfUFNQKSB7DQo+ ICAgCQkJCWNvbnN0IHN0cnVjdCBnZnhfZmlybXdhcmVfaGVhZGVyX3YxXzAgKmNwX2hkcjsNCj4g ICAJCQkJY3BfaGRyID0gKGNvbnN0IHN0cnVjdCBnZnhfZmlybXdhcmVfaGVhZGVyX3YxXzAgKil1 Y29kZS0+ZnctPmRhdGE7DQo+IC0JCQkJYW1kZ3B1X3Vjb2RlX3BhdGNoX2p0KHVjb2RlLCBmd19t Y19hZGRyICsgZndfb2Zmc2V0LA0KPiAtCQkJCQkJICAgIGZ3X2J1Zl9wdHIgKyBmd19vZmZzZXQp Ow0KPiArCQkJCWFtZGdwdV91Y29kZV9wYXRjaF9qdCh1Y29kZSwgIGFkZXYtPmZpcm13YXJlLmZ3 X2J1Zl9tYyArIGZ3X29mZnNldCwNCj4gKwkJCQkJCSAgICBhZGV2LT5maXJtd2FyZS5md19idWZf cHRyICsgZndfb2Zmc2V0KTsNCj4gICAJCQkJZndfb2Zmc2V0ICs9IEFMSUdOKGxlMzJfdG9fY3B1 KGNwX2hkci0+anRfc2l6ZSkgPDwgMiwgUEFHRV9TSVpFKTsNCj4gICAJCQl9DQo+ICAgCQkJZndf b2Zmc2V0ICs9IEFMSUdOKHVjb2RlLT51Y29kZV9zaXplLCBQQUdFX1NJWkUpOw0KDQoNCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=