[IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel

From: "Smith, Jackson" <rsmith@RiversideResearch.org>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel
Date: Mon, 25 Jul 2022 17:44:01 +0000	[thread overview]
Message-ID: <BN0P110MB16423592266085271C069BA7CF959@BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM> (raw)

Hi Stefano,

My colleague Jason Lei and I would like to submit a patch to imagebuilder.

It seems that generating a .fit with a true dom0less configuration fails because an extraneous comma is included in the its file.

We believe this change resolves the issue.

Thanks,
Jackson

-- >8 --

Remove extraneous comma in generated its file when no DOM0_KERNEL is specified.

diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen
index 8f08cd6..6f94fce 100755
--- a/scripts/uboot-script-gen
+++ b/scripts/uboot-script-gen
@@ -676,7 +676,12 @@ create_its_file_xen()
             i=$(( $i + 1 ))
             continue
         fi
-        load_files+=", \"domU${i}_kernel\""
+       if test -z "$load_files"
+       then
+           load_files+="\"domU${i}_kernel\""
+       else
+           load_files+=", \"domU${i}_kernel\""
+       fi
         cat >> "$its_file" <<- EOF
         domU${i}_kernel {
             description = "domU${i} kernel binary";



