From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CF0C433EF for ; Fri, 24 Sep 2021 08:46:11 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 85AFD60F41 for ; Fri, 24 Sep 2021 08:46:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85AFD60F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98A3E4122D; Fri, 24 Sep 2021 10:46:09 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 8D8D840142 for ; Fri, 24 Sep 2021 10:46:07 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10116"; a="220830832" X-IronPort-AV: E=Sophos;i="5.85,319,1624345200"; d="scan'208";a="220830832" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 01:46:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,319,1624345200"; d="scan'208";a="436931278" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 24 Sep 2021 01:46:05 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 24 Sep 2021 01:46:05 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 24 Sep 2021 01:46:05 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 24 Sep 2021 01:46:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JLgbxZQHIJhBhZ4vbE8g2jxHbafvUZ7LSTUcYHCyYOSqJRm4LlGnAjNjDWiL8tkEp9QZi/gQQa71ISl1Ts9D9HBe4X9j3Ho1ZdLY2zq27gbBqO+Y8+SzxXTOaaqi6r8CvAj4f57YTQp+9kNQm/utmNVVaiaCwX0tN1TlwgHmR5Ak+QQiCgmZIIWTnJKUTRm4VL3Lu0pC+73evR6YND53q4Vl9Dp5NZi5nIbhdZoiuQ2mUBdnqAW6ajhdAW/zBpMgtQLq3JGfL8BsgBE9cZ0a5DuglAHmbTUINwCayWhTY7yE/BFQv3ViuSCnr4/cZ0/CR7DjLD5S4xZLEQxD+/YV8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NquwVfzqGHrXspDDXElzcQU3/8fcNJFLXsbIMzn14cI=; b=c/UlAE6IxAAx1nHMmDZzPMepEIvT7bXw0QAu8sELBlEnLNLjdJhUVk1IahKhl393OMwyAAucOTPOY7HKuHg1hcjnHeFm1wcqcGHsrHo4nd1JalrJJtNwtN3D6ikXKHcFkggcyGZPzOcEi6W3j8S5lK3FvGkFw3OBrlk2HeUdqg8Op0canWv9FGJVM39zJjfaV88qt7f7XZNdy3d9cdiBNmGqjNFoywshBK7BZQaSiht6HwblICIo92T6lN6M+dytl90hMMMRa3JCqlfQ4x9jbAALW8uAm5A169JLR68OTsNUo56boWGNJK5/YuA6Z+7qhRaST11pviHE4gCe1b36LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NquwVfzqGHrXspDDXElzcQU3/8fcNJFLXsbIMzn14cI=; b=sS9MmWEnQ8Wpf6TpIfU0/7x+9wsz1Md/63bTIVGyzulF2X8lOjV0irDTJ4EARCbnhlIuTOcFnMwii+9yzCTNUSI/u8c0kF52mr1RtoZ74dmoPDSor1lzSjbc31jw13D/sljRmyNaVJ0mQg7wOB1DlcDuHvylCsdCpVZp9U53mNQ= Received: from BN0PR11MB5712.namprd11.prod.outlook.com (2603:10b6:408:160::17) by BN9PR11MB5546.namprd11.prod.outlook.com (2603:10b6:408:103::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Fri, 24 Sep 2021 08:45:57 +0000 Received: from BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::701d:ccab:5607:daab]) by BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::701d:ccab:5607:daab%4]) with mapi id 15.20.4544.018; Fri, 24 Sep 2021 08:45:57 +0000 From: "Van Haaren, Harry" To: "Guo, Junfeng" , "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Guo, Junfeng" Thread-Topic: [dpdk-dev] [PATCH 2/3] net/ice: enable protocol agnostic flow offloading in FDIR Thread-Index: AQHXsR8qcTrFes8LHUCLKwABc13WG6uy3dRg Date: Fri, 24 Sep 2021 08:45:57 +0000 Message-ID: References: <20210924162223.1543519-1-junfeng.guo@intel.com> <20210924162223.1543519-3-junfeng.guo@intel.com> In-Reply-To: <20210924162223.1543519-3-junfeng.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 53066657-f096-4e20-a5c7-08d97f37ba76 x-ms-traffictypediagnostic: BN9PR11MB5546: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0ZnKc8tcS0fmOJtX8udXkw8l7+BNxOc1qgSX8F7QhMjAz7KuAV1rFqPahPBphXk7ip0Kyajz42zunBGGmlJ3bpK1+jGz6urtsLZ6Y9Lc4wBfQILwYoNs/oV+sLrZnEjjU+pXhon+mebxTWsRIeA5Ay7fgKVAI2kUvNxmJlAsWXIZsnqakAogLCYK05SpJ7Qak4Y87g6qtgnasMdnihsnxEkyZSgFBdq4q3GgSxXQqiCnn8kiiq0inchn6BUAzL1trk/55f4hUw0+jlFAflov/vRksIoIX+OJbYqYvCAmF8bkMvUCRJ1Co6Hf/Obw8JY3cF9Hxh1MHj5nMj+QsZJwrxD4IIyxxNtF/O7Cki6rlFHSfqH+Rbg+E3KPSWGZoSoYb4n+KghEdmN2IGmmCDaEevhKIh63ZMHd5k6QQcyf9g3Hj+1hYn9W0ECf0MLC9myH+6H1siYv5G5HWiK0CAXmEQZ7whgvwQVJl/dpTsV3oKnTnUdZbZWSRFJ4UEU1z3Gkm0l98BR0j5O/mL5A97CrmqBWDQxMpl3kf3PKdWd+lxsnqZWftQbSPqS4skOV96GAAWLEZfWAUoSBxaTiM1APn2V64G+z/KP+0ShIiEAf/12IDc4wfOyGz6n5YmuPda+/43slaQ2xM7NiBCWpyyrR1mta6utbkNalxEMUixDs1npJ5K3Ey4LPamj1gJhWi8nf/myuK6TKMG7fiq6C46f0bw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR11MB5712.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(54906003)(33656002)(107886003)(6636002)(122000001)(76116006)(2906002)(38100700002)(55016002)(86362001)(9686003)(5660300002)(66946007)(83380400001)(66556008)(66446008)(66476007)(64756008)(71200400001)(26005)(4326008)(6506007)(53546011)(52536014)(38070700005)(186003)(7696005)(8676002)(8936002)(316002)(110136005)(508600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?X49GsFQox7auYnHDmgYtCXB2n+TC1yGNa+7mGPHHxPIzweiUlxiUsFqgbi/U?= =?us-ascii?Q?ft1Sg22KzwjCc5lPggyoKJVAsqUwXoGEKjgEqW2n8ELm3H5muyYxEXtxXTQ0?= =?us-ascii?Q?MiuEcpX8zyqKB0Tu7CJ6CkW7YqC1Tdsxjc/zG5YGhYEMTVh81nvo2Qj9F2NC?= =?us-ascii?Q?k77juPfVmaoVGfZpGnyuZZMNoqHjrqX/7CeVG2y3BDKdLNM44WhiwiJCxc1Z?= =?us-ascii?Q?9obzFWy4GDC5YLk5AxpwY5CkuPPOhHN3tPtJQY6KrydUpQreXvoQc9M2Anvs?= =?us-ascii?Q?043i0O4/JDXRuFPX0E8zDrQ1jSl2X5/vHOfm+348sEziucM5uGojRtNcoAFK?= =?us-ascii?Q?QUBeaV02lJQly3e/rh9k03DMXzCwhcRnHMumyDq5IEI6KxdjOW/m4xh0gaQl?= =?us-ascii?Q?cjGVnA1WfobMKZoKaIN/K/JTLRYquIu2D9n21r5MOoZPPSSM5wqyn/by1tWI?= =?us-ascii?Q?S+rzJsDKe2SDZY09PN5APWuLSg//HttZoLhP+sLn5kF6xe496S1/lbexfgew?= =?us-ascii?Q?S4o698w5tIH2ZzEPZlJvhrDExHOiEDuUlwijCTqFn8wdR9+r1de2zjs++32Q?= =?us-ascii?Q?Qu+vqCDZttXs9gI0t/jebXegVAEIPF2Uc6K8vk5LXlityJCc6LpZP51caaQ7?= =?us-ascii?Q?kw5qeO1hng7dTdPnw0CNJSIEjX2xsN5wZcT87Es/zKmgkIYJttPF0VJRSog7?= =?us-ascii?Q?RepewPiFyZvEI/+/ivDsZyD9Hh7dknovN+OCSK1ROaZ+aPQqvoAgvqnuL9uL?= =?us-ascii?Q?NKfvAZJnfujYN7wUmOxxt5K5zGeyYAiyFOsLagd+szKanXKHDhS3us5KLxxB?= =?us-ascii?Q?5izNKCPZil/kMl4qnuK2Y126/50RYFVKAGP4CVNiQtYi/EGlge2dtgDQCWyu?= =?us-ascii?Q?Q5FQzwx7WD+Tr+PYTCLWECuPwhNMx+IvsGGeXsTm9Tp5is8v8KC2MtVSGAxT?= =?us-ascii?Q?OJMHun2cRIcaiQntjyViJP3REf8BO+KyJl9IeKh/8dFolNke0PZczAnF6eUa?= =?us-ascii?Q?N7rvT+v428dYEYrHcwiQHgsQcTzBns0yYpHORuxGQO2y8D5YJ0dz7SjXJ9SL?= =?us-ascii?Q?Z1COP4AXZqFj7xrxgi4vfTKW0Q4XiF0j+/yRUQqsd9/lmM6euBi2Xx/TIabH?= =?us-ascii?Q?bhwM3RZRS9IiDEbarAvsYiA3j16PLdXHHZAV/ST/TxCaJJcIcIsLinpJYWvm?= =?us-ascii?Q?8sOX1fouZ0FIkgbjIq1BhMXkyy6vh5ijXwv2xysyfd7za/BKgxi/q//w3Mdp?= =?us-ascii?Q?oZUkw47j76V79eHf0OC0JM9ECbw3PB0aLGfU77y0H9IVeYobkCt4GFSPkv90?= =?us-ascii?Q?8WQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5712.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53066657-f096-4e20-a5c7-08d97f37ba76 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2021 08:45:57.6040 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xCM5wc4j5zUuU2DYkSgKjomoDy9BnO10kXRLuSSIH7hpF2XPHEuUU2I9fX8I9zxSG/k9NOfrJp+j/NT5Pph0seCkl1FszHyXZCx329ofMtc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5546 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/3] net/ice: enable protocol agnostic flow offloading in FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Junfeng Guo > Sent: Friday, September 24, 2021 5:22 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Junfeng > Subject: [dpdk-dev] [PATCH 2/3] net/ice: enable protocol agnostic flow > offloading in FDIR >=20 > Protocol agnostic flow offloading in Flow Director is enabled by this > patch based on the Parser Library, using existing rte_flow raw API, > without public API change. >=20 > Note that the raw flow requires: > 1. byte string of raw target packet bits. > 2. byte string of mask of target packet. >=20 > Here is an example: > FDIR matching ipv4 dst addr with 1.2.3.4 and redirect to queue 3: >=20 > flow create 0 ingress pattern raw \ > pattern spec \ > 00000000000000000000000008004500001400004000401000000000000001020304 \ > pattern mask \ > 000000000000000000000000000000000000000000000000000000000000ffffffff \ > / end actions queue index 3 / mark id 3 / end To improve the documentation in the commit message, should the "00000800" (= 0x0800) EtherType not be masked with 0xFFFF too? Non IPv4 packets which happen to h= ave the masked data "01020304" in that position would incorrectly match. By adding = 0xFFFF in the mask to check ethertype =3D=3D 0x8000, this issue is resolved. > 00000000000000000000000008004500001400004000401000000000000001020304 \ > pattern mask \ > 00000000000000000000FFFFFFFF00000000000000000000000000000000ffffffff \ Difficult to see if I changed correct characters in the string from 0 to F,= but I hope the point is clear. Regards, -Harry