From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757244AbbAZWrX (ORCPT ); Mon, 26 Jan 2015 17:47:23 -0500 Received: from mail-bn1bon0138.outbound.protection.outlook.com ([157.56.111.138]:29092 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757224AbbAZWrU convert rfc822-to-8bit (ORCPT ); Mon, 26 Jan 2015 17:47:20 -0500 From: Haiyang Zhang To: Nicholas Mc Guire , KY Srinivasan CC: "devel@linuxdriverproject.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2] net: hyperv: else branch not necessary Thread-Topic: [PATCH v2] net: hyperv: else branch not necessary Thread-Index: AQHQOMsMfFDVAhk12kKnTs5nk2uyyZzTAjRQ Date: Mon, 26 Jan 2015 22:47:18 +0000 Message-ID: References: <1422209317-18975-1-git-send-email-der.herr@hofr.at> In-Reply-To: <1422209317-18975-1-git-send-email-der.herr@hofr.at> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [96.237.174.38] authentication-results: hofr.at; dkim=none (message not signed) header.d=none;hofr.at; dmarc=none action=none header.from=microsoft.com; x-dmarcaction-test: None x-microsoft-antispam: BCL:0;PCL:0;RULEID:(3005004);SRVR:BN1PR0301MB0707; x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0707; x-forefront-prvs: 0468FE4A2B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(51704005)(377454003)(13464003)(40100003)(102836002)(2900100001)(99286002)(2656002)(87936001)(86362001)(1511001)(2950100001)(62966003)(122556002)(77156002)(66066001)(2421001)(76576001)(106116001)(33656002)(19580395003)(76176999)(50986999)(54606007)(46102003)(92566002)(74316001)(54356999)(54206007)(19580405001)(86612001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR0301MB0707;H:BN1PR0301MB0770.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: microsoft.onmicrosoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2015 22:47:18.1689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0707 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Nicholas Mc Guire [mailto:der.herr@hofr.at] > Sent: Sunday, January 25, 2015 1:09 PM > To: KY Srinivasan > Cc: Haiyang Zhang; devel@linuxdriverproject.org; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; Nicholas Mc Guire > Subject: [PATCH v2] net: hyperv: else branch not necessary > > As the if completes with a unconditional goto the else branch > is not needed here. > > Signed-off-by: Nicholas Mc Guire Signed-off-by: Haiyang Zhang Thank you! > --- > > v2: added missing subsystem string in subject line - patch unchanged > > All paths of execution that did not exit through the if branch will > go through the else branch so no need for an explicit else here > > Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y > CONFIG_HYPERV=m, CONFIG_HYPERV_NET=m > > Patch is against 3.19.0-rc5 -next-20150123 > > drivers/net/hyperv/rndis_filter.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/hyperv/rndis_filter.c > b/drivers/net/hyperv/rndis_filter.c > index 7bd8387..efb84a9 100644 > --- a/drivers/net/hyperv/rndis_filter.c > +++ b/drivers/net/hyperv/rndis_filter.c > @@ -833,10 +833,10 @@ int rndis_filter_set_packet_filter(struct > rndis_device *dev, u32 new_filter) > * send completion for it. > */ > goto exit; > - } else { > - set_complete = &request->response_msg.msg.set_complete; > - status = set_complete->status; > - } > + } > + > + set_complete = &request->response_msg.msg.set_complete; > + status = set_complete->status; > > cleanup: > if (request) > -- > 1.7.10.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haiyang Zhang Subject: RE: [PATCH v2] net: hyperv: else branch not necessary Date: Mon, 26 Jan 2015 22:47:18 +0000 Message-ID: References: <1422209317-18975-1-git-send-email-der.herr@hofr.at> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" To: Nicholas Mc Guire , KY Srinivasan Return-path: In-Reply-To: <1422209317-18975-1-git-send-email-der.herr@hofr.at> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org > -----Original Message----- > From: Nicholas Mc Guire [mailto:der.herr@hofr.at] > Sent: Sunday, January 25, 2015 1:09 PM > To: KY Srinivasan > Cc: Haiyang Zhang; devel@linuxdriverproject.org; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; Nicholas Mc Guire > Subject: [PATCH v2] net: hyperv: else branch not necessary > > As the if completes with a unconditional goto the else branch > is not needed here. > > Signed-off-by: Nicholas Mc Guire Signed-off-by: Haiyang Zhang Thank you! > --- > > v2: added missing subsystem string in subject line - patch unchanged > > All paths of execution that did not exit through the if branch will > go through the else branch so no need for an explicit else here > > Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y > CONFIG_HYPERV=m, CONFIG_HYPERV_NET=m > > Patch is against 3.19.0-rc5 -next-20150123 > > drivers/net/hyperv/rndis_filter.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/hyperv/rndis_filter.c > b/drivers/net/hyperv/rndis_filter.c > index 7bd8387..efb84a9 100644 > --- a/drivers/net/hyperv/rndis_filter.c > +++ b/drivers/net/hyperv/rndis_filter.c > @@ -833,10 +833,10 @@ int rndis_filter_set_packet_filter(struct > rndis_device *dev, u32 new_filter) > * send completion for it. > */ > goto exit; > - } else { > - set_complete = &request->response_msg.msg.set_complete; > - status = set_complete->status; > - } > + } > + > + set_complete = &request->response_msg.msg.set_complete; > + status = set_complete->status; > > cleanup: > if (request) > -- > 1.7.10.4