From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Damien Le Moal To: Jens Axboe , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "dm-devel@redhat.com" , Mike Snitzer CC: Christoph Hellwig , Matias Bjorling Subject: Re: [PATCH v4 00/11] Zoned block device support improvements Date: Mon, 15 Oct 2018 00:45:57 +0000 Message-ID: References: <20181012100850.23316-1-damien.lemoal@wdc.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-ID: Jens,=0A= =0A= On 2018/10/14 7:43, Jens Axboe wrote:=0A= > On 10/12/18 4:08 AM, Damien Le Moal wrote:=0A= >> This series improves zoned block device support (reduce overhead) and=0A= >> introduces many simplifications to the code (overall, there are more del= etions=0A= >> than insertions).=0A= >>=0A= >> In more details:=0A= >> * Patches 1 to 3 are SCSI side (sd driver) cleanups and improvements red= ucing=0A= >> the overhead of report zones command execution during disk scan and=0A= >> revalidation.=0A= >> * Patches 4 to 9 improve the useability and user API of zoned block devi= ces.=0A= >> * Patch 10 is the main part of this series. This patch replaces the=0A= >> REQ_OP_ZONE_REPORT BIO/request operation for executing report zones co= mmands=0A= >> with a block device file operation, removing the need for the command = reply=0A= >> payload in-place rewriting in the BIO buffer. This leads to major=0A= >> simplification of the code in many places.=0A= >> * Patch 11 further simplifies the code of low level drivers by providing= a=0A= >> generic implementation of zoned block device request queue zone bitmap= s=0A= >> initialization and revalidation.=0A= >>=0A= >> Please consider the addition of these patches in 4.20.=0A= >> Comments are as always welcome.=0A= > =0A= > How do we want to funnel this series? 1-3 look separate, so perhaps they= =0A= > should go through the scsi tree. Then I can take the rest. Or do some=0A= > of the later ones depend on 1-3 being in, in terms of applying cleanly?= =0A= > I can also take all of them, looks like only #3 needs a SCSI ack.=0A= =0A= Patch 10 and 11 will not apply cleanly for the scsi part without 1-3 in fir= st.=0A= 1-3, 10 and 11 would need an ack/review from Martin (SCSI).=0A= And 10-11 also probably need an ack/review from Mike for the DM changes.=0A= =0A= Best regards.=0A= =0A= -- =0A= Damien Le Moal=0A= Western Digital Research=0A= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Le Moal Subject: Re: [PATCH v4 00/11] Zoned block device support improvements Date: Mon, 15 Oct 2018 00:45:57 +0000 Message-ID: References: <20181012100850.23316-1-damien.lemoal@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Jens Axboe , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "dm-devel@redhat.com" , Mike Snitzer Cc: Christoph Hellwig , Matias Bjorling List-Id: linux-scsi@vger.kernel.org Jens, On 2018/10/14 7:43, Jens Axboe wrote: > On 10/12/18 4:08 AM, Damien Le Moal wrote: >> This series improves zoned block device support (reduce overhead) and >> introduces many simplifications to the code (overall, there are more deletions >> than insertions). >> >> In more details: >> * Patches 1 to 3 are SCSI side (sd driver) cleanups and improvements reducing >> the overhead of report zones command execution during disk scan and >> revalidation. >> * Patches 4 to 9 improve the useability and user API of zoned block devices. >> * Patch 10 is the main part of this series. This patch replaces the >> REQ_OP_ZONE_REPORT BIO/request operation for executing report zones commands >> with a block device file operation, removing the need for the command reply >> payload in-place rewriting in the BIO buffer. This leads to major >> simplification of the code in many places. >> * Patch 11 further simplifies the code of low level drivers by providing a >> generic implementation of zoned block device request queue zone bitmaps >> initialization and revalidation. >> >> Please consider the addition of these patches in 4.20. >> Comments are as always welcome. > > How do we want to funnel this series? 1-3 look separate, so perhaps they > should go through the scsi tree. Then I can take the rest. Or do some > of the later ones depend on 1-3 being in, in terms of applying cleanly? > I can also take all of them, looks like only #3 needs a SCSI ack. Patch 10 and 11 will not apply cleanly for the scsi part without 1-3 in first. 1-3, 10 and 11 would need an ack/review from Martin (SCSI). And 10-11 also probably need an ack/review from Mike for the DM changes. Best regards. -- Damien Le Moal Western Digital Research