From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Damien Le Moal To: Jens Axboe , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "dm-devel@redhat.com" , Mike Snitzer CC: Christoph Hellwig , Matias Bjorling Subject: Re: [PATCH v4 00/11] Zoned block device support improvements Date: Wed, 24 Oct 2018 08:04:53 +0000 Message-ID: References: <20181012100850.23316-1-damien.lemoal@wdc.com> <78778e22-9c5e-99d0-ef5c-85e04d03a4b7@kernel.dk> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-ID: Jens,=0A= =0A= On 2018/10/23 16:59, Jens Axboe wrote:=0A= > On 10/12/18 4:08 AM, Damien Le Moal wrote:=0A= >> This series improves zoned block device support (reduce overhead) and=0A= >> introduces many simplifications to the code (overall, there are more del= etions=0A= >> than insertions).=0A= >>=0A= >> In more details:=0A= >> * Patches 1 to 3 are SCSI side (sd driver) cleanups and improvements red= ucing=0A= >> the overhead of report zones command execution during disk scan and=0A= >> revalidation.=0A= >> * Patches 4 to 9 improve the useability and user API of zoned block devi= ces.=0A= >> * Patch 10 is the main part of this series. This patch replaces the=0A= >> REQ_OP_ZONE_REPORT BIO/request operation for executing report zones co= mmands=0A= >> with a block device file operation, removing the need for the command = reply=0A= >> payload in-place rewriting in the BIO buffer. This leads to major=0A= >> simplification of the code in many places.=0A= >> * Patch 11 further simplifies the code of low level drivers by providing= a=0A= >> generic implementation of zoned block device reuest queue zone bitmaps= =0A= >> initialization and revalidation.=0A= > =0A= > I've applied this, but I have two complaints:=0A= > =0A= > 1) Two had to be hand applied, it wasn't against the block tree.=0A= =0A= My apologies for that. I had to rebase against the latest RC because of a= =0A= conflict with late fixes in DM. I should have checked more carefully agains= t the=0A= block tree after that. Sorry about this, I will be more careful going forwa= rd.=0A= =0A= > 2) The ordering of the signed-off-by. Someone told me that this is=0A= > patchwork, but I absolutely hate it. SOB should go last, not before=0A= > the reviewed-by. I fixed that up too.=0A= =0A= Thank you. I think this was me rather than patchwork when I a manually adde= d the=0A= reviewed-by tags with new versions of the series. I will remember this and = tag=0A= in you preferred order.=0A= =0A= Thank you.=0A= =0A= Best regards.=0A= =0A= -- =0A= Damien Le Moal=0A= Western Digital Research=0A= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Le Moal Subject: Re: [PATCH v4 00/11] Zoned block device support improvements Date: Wed, 24 Oct 2018 08:04:53 +0000 Message-ID: References: <20181012100850.23316-1-damien.lemoal@wdc.com> <78778e22-9c5e-99d0-ef5c-85e04d03a4b7@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Jens Axboe , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "dm-devel@redhat.com" , Mike Snitzer Cc: Christoph Hellwig , Matias Bjorling List-Id: linux-scsi@vger.kernel.org Jens, On 2018/10/23 16:59, Jens Axboe wrote: > On 10/12/18 4:08 AM, Damien Le Moal wrote: >> This series improves zoned block device support (reduce overhead) and >> introduces many simplifications to the code (overall, there are more deletions >> than insertions). >> >> In more details: >> * Patches 1 to 3 are SCSI side (sd driver) cleanups and improvements reducing >> the overhead of report zones command execution during disk scan and >> revalidation. >> * Patches 4 to 9 improve the useability and user API of zoned block devices. >> * Patch 10 is the main part of this series. This patch replaces the >> REQ_OP_ZONE_REPORT BIO/request operation for executing report zones commands >> with a block device file operation, removing the need for the command reply >> payload in-place rewriting in the BIO buffer. This leads to major >> simplification of the code in many places. >> * Patch 11 further simplifies the code of low level drivers by providing a >> generic implementation of zoned block device reuest queue zone bitmaps >> initialization and revalidation. > > I've applied this, but I have two complaints: > > 1) Two had to be hand applied, it wasn't against the block tree. My apologies for that. I had to rebase against the latest RC because of a conflict with late fixes in DM. I should have checked more carefully against the block tree after that. Sorry about this, I will be more careful going forward. > 2) The ordering of the signed-off-by. Someone told me that this is > patchwork, but I absolutely hate it. SOB should go last, not before > the reviewed-by. I fixed that up too. Thank you. I think this was me rather than patchwork when I a manually added the reviewed-by tags with new versions of the series. I will remember this and tag in you preferred order. Thank you. Best regards. -- Damien Le Moal Western Digital Research