From: "Sia, Jee Heng" <jee.heng.sia@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "liam.r.girdwood@linux.intel.com"
<liam.r.girdwood@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>
Subject: RE: [PATCH v2 2/4] ASoC: Intel: Boards: Add KeemBay machine driver
Date: Wed, 27 May 2020 13:11:52 +0000 [thread overview]
Message-ID: <BN6PR11MB1953C13CDAA8A6D793730914DAB10@BN6PR11MB1953.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200518170933.GB28178@sirena.org.uk>
Thanks but will deep dive into the graph card. Will get back to you shortly.
Thanks
Regards
Jee Heng
-----Original Message-----
From: Mark Brown <broonie@kernel.org>
Sent: Tuesday, May 19, 2020 1:10 AM
To: Sia, Jee Heng <jee.heng.sia@intel.com>
Cc: alsa-devel@alsa-project.org; tiwai@suse.com; pierre-louis.bossart@linux.intel.com; liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH v2 2/4] ASoC: Intel: Boards: Add KeemBay machine driver
On Mon, May 18, 2020 at 10:17:20AM +0800, Sia Jee Heng wrote:
> Add KeemBay machine driver which glues the tlv320aic3204 codec driver
> and kmb_platform driver to form the asoc sound driver.
Why do you need a custom machine driver for this, as this is a DT based platform and I'm not seeing anything complex or unusual in the code you should be able to use audio-graph-card (or simple-card but the former is more modern and should be preferred for new systems).
If this is required the DT binding should be documented.
next prev parent reply other threads:[~2020-05-27 13:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 2:17 [PATCH v2 0/4] ASoC: Intel: Add KeemBay ASoC driver Sia Jee Heng
2020-05-18 2:17 ` [PATCH v2 1/4] ASoC: Intel: Add KeemBay platform driver Sia Jee Heng
2020-05-18 17:06 ` Mark Brown
2020-05-27 13:20 ` Sia, Jee Heng
2020-05-27 13:23 ` Mark Brown
2020-05-18 2:17 ` [PATCH v2 2/4] ASoC: Intel: Boards: Add KeemBay machine driver Sia Jee Heng
2020-05-18 17:09 ` Mark Brown
2020-05-27 13:11 ` Sia, Jee Heng [this message]
2020-05-29 4:42 ` Sia, Jee Heng
2020-05-18 2:17 ` [PATCH v2 3/4] ASoC: Intel: Add makefiles and kconfig changes for KeemBay Sia Jee Heng
2020-05-18 2:17 ` [PATCH v2 4/4] dt-bindings: sound: Add documentation for KeemBay sound card and i2s Sia Jee Heng
2020-05-18 16:38 ` [PATCH v2 0/4] ASoC: Intel: Add KeemBay ASoC driver Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB1953C13CDAA8A6D793730914DAB10@BN6PR11MB1953.namprd11.prod.outlook.com \
--to=jee.heng.sia@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.