RE: [PATCH] drm/amdgpu: Add sysfs file for VBIOS

From: "Russell, Kent" <Kent.Russell-5C7GfCeVMHo@public.gmane.org>
To: "StDenis, Tom" <Tom.StDenis-5C7GfCeVMHo@public.gmane.org>,
	"Christian König"
	<deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: RE: [PATCH] drm/amdgpu: Add sysfs file for VBIOS
Date: Fri, 25 Aug 2017 12:59:59 +0000	[thread overview]
Message-ID: <BN6PR1201MB01806ACF078801D91460C110859B0@BN6PR1201MB0180.namprd12.prod.outlook.com> (raw)
In-Reply-To: <22c4b9e2-67e2-bd0a-1147-6e896843783e-5C7GfCeVMHo@public.gmane.org>

There is GPU Power usage reported through amdgpu_pm_info, which also has some other information as well. I'd like that in sysfs, but I am unsure if we are  allowed to due to the other information reported there.

 Kent

-----Original Message-----
From: StDenis, Tom 
Sent: Friday, August 25, 2017 8:58 AM
To: Christian König; Russell, Kent; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Add sysfs file for VBIOS

On 25/08/17 08:56 AM, Christian König wrote:
> Hi Kent,
> 
> agree on the VBIOS dump file, that clearly belongs to debugsf.
> 
> The power usage stuff I can't say much about cause I'm not deeply into 
> this, but keep in mind the restriction for sysfs:
> 1. It's a stable interface. So it must be very well designed.
> 2. Only one value per file. I think the power stuff doesn't fulfill 
> that requirement at the moment.

What "power" stuff are we talking about?  The sensors interface or the pm_info or something else?

Keep in mind umr uses the sensors debugfs file in --top mode.

Tom
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx