All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Deucher, Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>
To: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "Yu, Xiangliang" <Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org>
Subject: RE: [PATCH 3/3] drm/amdgpu/gfx: free memory of mqd backup
Date: Thu, 16 Feb 2017 14:57:25 +0000	[thread overview]
Message-ID: <BN6PR12MB1652AD249DC72A1244CAE1B5F75A0@BN6PR12MB1652.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1487229920-4897-3-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org>

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Xiangliang Yu
> Sent: Thursday, February 16, 2017 2:25 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Yu, Xiangliang
> Subject: [PATCH 3/3] drm/amdgpu/gfx: free memory of mqd backup
> 
> Need to free mqd backup when destroying ring.
> 
> Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>

Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 2202f02..23cf6fa 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -7379,12 +7379,14 @@ static void
> gfx_v8_0_compute_mqd_soft_fini(struct amdgpu_device *adev)
> 
>  	for (i = 0; i < adev->gfx.num_compute_rings; i++) {
>  		ring = &adev->gfx.compute_ring[i];
> +		kfree(adev->gfx.mec.mqd_backup[i]);
>  		amdgpu_bo_free_kernel(&ring->mqd_obj,
>  				      &ring->mqd_gpu_addr,
>  				      &ring->mqd_ptr);
>  	}
> 
>  	ring = &adev->gfx.kiq.ring;
> +	kfree(adev-
> >gfx.mec.mqd_backup[AMDGPU_MAX_COMPUTE_RINGS]);
>  	amdgpu_bo_free_kernel(&ring->mqd_obj,
>  			      &ring->mqd_gpu_addr,
>  			      &ring->mqd_ptr);
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-02-16 14:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16  7:25 [PATCH 1/3] drm/amdgpu: change pointer of mqd_ptr to void Xiangliang Yu
     [not found] ` <1487229920-4897-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org>
2017-02-16  7:25   ` [PATCH 2/3] drm/amdgpu/virt: fix typo Xiangliang Yu
2017-02-16  7:25   ` [PATCH 3/3] drm/amdgpu/gfx: free memory of mqd backup Xiangliang Yu
     [not found]     ` <1487229920-4897-3-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org>
2017-02-16 14:57       ` Deucher, Alexander [this message]
2017-02-16  9:16   ` [PATCH 1/3] drm/amdgpu: change pointer of mqd_ptr to void Christian König
     [not found]     ` <220014f3-9d36-95e8-58cf-f504c0a0588a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-02-16 10:37       ` 答复: " Liu, Monk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR12MB1652AD249DC72A1244CAE1B5F75A0@BN6PR12MB1652.namprd12.prod.outlook.com \
    --to=alexander.deucher-5c7gfcevmho@public.gmane.org \
    --cc=Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.