From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Deucher, Alexander" Subject: Re: [PATCH 2/2] drm/amd/powerplay: correct data type to avoid overflow Date: Tue, 26 Mar 2019 12:59:59 +0000 Message-ID: References: <20190322180630.19021-1-evan.quan@amd.com> <20190322180630.19021-2-evan.quan@amd.com>, Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1216458277==" Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Quan, Evan" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" --===============1216458277== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR12MB18090D618069382420423226F75F0BN6PR12MB1809namp_" --_000_BN6PR12MB18090D618069382420423226F75F0BN6PR12MB1809namp_ Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Series is: Reviewed-by: Alex Deucher ________________________________ From: amd-gfx on behalf of Quan, Ev= an Sent: Tuesday, March 26, 2019 6:15 AM To: Quan, Evan; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Subject: RE: [PATCH 2/2] drm/amd/powerplay: correct data type to avoid over= flow Ping.. > -----Original Message----- > From: Evan Quan > Sent: 2019=1B$BG/=1B(B3=1B$B7n=1B(B23=1B$BF|=1B(B 2:07 > To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > Cc: Quan, Evan > Subject: [PATCH 2/2] drm/amd/powerplay: correct data type to avoid > overflow > > Avoid left shift overflow. > > Change-Id: If03f4f4d440b6d742d8eaa23d0bae6ddd21c01ea > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h > b/drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h > index b90089a4fb6a..195c4ae67058 100644 > --- a/drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h > +++ b/drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h > @@ -165,7 +165,7 @@ > #define FEATURE_DS_FCLK_MASK (1 << FEATURE_DS_FCLK_BIT = ) > #define FEATURE_DS_MP1CLK_MASK (1 << > FEATURE_DS_MP1CLK_BIT ) > #define FEATURE_DS_MP0CLK_MASK (1 << > FEATURE_DS_MP0CLK_BIT ) > -#define FEATURE_XGMI_MASK (1 << FEATURE_XGMI_BIT = ) > +#define FEATURE_XGMI_MASK (1ULL << > FEATURE_XGMI_BIT ) > #define FEATURE_ECC_MASK (1ULL << FEATURE_ECC_BIT = ) > > #define DPM_OVERRIDE_DISABLE_SOCCLK_PID 0x00000001 > -- > 2.21.0 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --_000_BN6PR12MB18090D618069382420423226F75F0BN6PR12MB1809namp_ Content-Type: text/html; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable
Series is:
Reviewed-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
From: amd-gfx <amd-gfx-b= ounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Quan, Evan <Evan.Quan@amd.= com>
Sent: Tuesday, March 26, 2019 6:15 AM
To: Quan, Evan; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: RE: [PATCH 2/2] drm/amd/powerplay: correct data type to avo= id overflow
 
Ping..

> -----Original Message-----
> From: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org>
> Sent: 2019=1B$BG/=1B(B3=1B$B7n=1B(B23=1B$BF|=1B(B 2:07
> To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> Cc: Quan, Evan <Evan.Quan-5C7GfCeVMHo@public.gmane.org>
> Subject: [PATCH 2/2] drm/amd/powerplay: correct data type to avoid
> overflow
>
> Avoid left shift overflow.
>
> Change-Id: If03f4f4d440b6d742d8eaa23d0bae6ddd21c01ea
> Signed-off-by: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org>
> ---
>  drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h
> b/drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h
> index b90089a4fb6a..195c4ae67058 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h<= br> > @@ -165,7 +165,7 @@
>  #define FEATURE_DS_FCLK_MASK      =       (1 << FEATURE_DS_FCLK_BIT  &= nbsp;         )
>  #define FEATURE_DS_MP1CLK_MASK     &nbs= p;    (1 <<
> FEATURE_DS_MP1CLK_BIT        &= nbsp; )
>  #define FEATURE_DS_MP0CLK_MASK     &nbs= p;    (1 <<
> FEATURE_DS_MP0CLK_BIT        &= nbsp; )
> -#define FEATURE_XGMI_MASK       &n= bsp;       (1 << FEATURE_XGMI_BIT =             &nb= sp; )
> +#define FEATURE_XGMI_MASK      &nbs= p;        (1ULL <<
> FEATURE_XGMI_BIT         =       )
>  #define FEATURE_ECC_MASK      &nbs= p;         (1ULL << FEATURE_E= CC_BIT           &nb= sp;    )
>
>  #define DPM_OVERRIDE_DISABLE_SOCCLK_PID    &= nbsp;        0x00000001
> --
> 2.21.0

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://= lists.freedesktop.org/mailman/listinfo/amd-gfx
--_000_BN6PR12MB18090D618069382420423226F75F0BN6PR12MB1809namp_-- --===============1216458277== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 --===============1216458277==--