From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Deucher, Alexander" Subject: Re: [PATCH] drm/amdgpu: Don't default to DC support for Kaveri and older Date: Mon, 7 May 2018 18:38:06 +0000 Message-ID: References: <20180503194530.3150-1-harry.wentland@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0600935597==" Return-path: In-Reply-To: <20180503194530.3150-1-harry.wentland-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Wentland, Harry" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" --===============0600935597== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN6PR12MB18098603FFEA18B60616AFFFF79B0BN6PR12MB1809namp_" --_000_BN6PR12MB18098603FFEA18B60616AFFFF79B0BN6PR12MB1809namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Alex Deucher ________________________________ From: amd-gfx on behalf of Harry We= ntland Sent: Thursday, May 3, 2018 3:45:30 PM To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Wentland, Harry Subject: [PATCH] drm/amdgpu: Don't default to DC support for Kaveri and old= er We've had a number of users report failures to detect and light up display with DC with LVDS and VGA. These connector types are not currently supported with DC. I'd like to add support but unfortunately don't have a system with LVDS or VGA available. In order not to cause regressions we should probably fallback to the non-DC driver for ASICs that support VGA and LVDS. These ASICs are: * Hawaii * Bonaire * Kabini * Kaveri ASIC support can always be force enabled with amdgpu.dc=3D1 Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_device.c index 887f7c9e84e0..66d8b96a04ac 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -2144,6 +2144,14 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic= _type asic_type) case CHIP_HAWAII: case CHIP_KAVERI: case CHIP_KABINI: + /* + * We have systems in the wild with these ASICs that requir= e + * LVDS and VGA support which is not supported with DC. + * + * Fallback to the non-DC driver here by default so as not = to + * cause regressions. + */ + return amdgpu_dc > 0; case CHIP_MULLINS: case CHIP_CARRIZO: case CHIP_STONEY: -- 2.17.0 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --_000_BN6PR12MB18098603FFEA18B60616AFFFF79B0BN6PR12MB1809namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Alex Deucher <ale= xander.deucher-5C7GfCeVMHo@public.gmane.org>

From: amd-gfx <amd-gfx-b= ounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Harry Wentland <harry.went= land-5C7GfCeVMHo@public.gmane.org>
Sent: Thursday, May 3, 2018 3:45:30 PM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Wentland, Harry
Subject: [PATCH] drm/amdgpu: Don't default to DC support for Kaveri = and older
 
We've had a number of users report failures to det= ect and light up
display with DC with LVDS and VGA. These connector types are not
currently supported with DC. I'd like to add support but unfortunately
don't have a system with LVDS or VGA available.

In order not to cause regressions we should probably fallback to the
non-DC driver for ASICs that support VGA and LVDS.

These ASICs are:
 * Hawaii
 * Bonaire
 * Kabini
 * Kaveri

ASIC support can always be force enabled with amdgpu.dc=3D1

Signed-off-by: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++++&#= 43;+++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_device.c
index 887f7c9e84e0..66d8b96a04ac 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2144,6 +2144,14 @@ bool amdgpu_device_asic_has_dc_support(enum amd_= asic_type asic_type)
         case CHIP_HAWAII:
         case CHIP_KAVERI:
         case CHIP_KABINI:
+           &nbs= p;   /*
+           &nbs= p;    * We have systems in the wild with these ASICs that re= quire
+           &nbs= p;    * LVDS and VGA support which is not supported with DC.=
+           &nbs= p;    *
+           &nbs= p;    * Fallback to the non-DC driver here by default so as = not to
+           &nbs= p;    * cause regressions.
+           &nbs= p;    */
+           &nbs= p;   return amdgpu_dc > 0;
         case CHIP_MULLINS:
         case CHIP_CARRIZO:
         case CHIP_STONEY:
--
2.17.0

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://= lists.freedesktop.org/mailman/listinfo/amd-gfx
--_000_BN6PR12MB18098603FFEA18B60616AFFFF79B0BN6PR12MB1809namp_-- --===============0600935597== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============0600935597==--