All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Deucher, Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>
To: "Qu, Jim" <Jim.Qu-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amd/powerplay: correct code style
Date: Wed, 7 Nov 2018 14:48:11 +0000	[thread overview]
Message-ID: <BN6PR12MB1809E321DAF57F20F4ADA833F7C40@BN6PR12MB1809.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20181107104212.14131-1-Jim.Qu-5C7GfCeVMHo@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 8365 bytes --]

Reviewed-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Jim Qu <Jim.Qu-5C7GfCeVMHo@public.gmane.org>
Sent: Wednesday, November 7, 2018 5:42:12 AM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Qu, Jim
Subject: [PATCH] drm/amd/powerplay: correct code style

Change-Id: I844949ae1738adae3dfad431a270913d04832f56
Signed-off-by: Jim Qu <Jim.Qu-5C7GfCeVMHo@public.gmane.org>
---
 .../drm/amd/powerplay/hwmgr/vega20_hwmgr.c    | 135 ++++++------------
 1 file changed, 45 insertions(+), 90 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
index cb3c3d69c3d3..f2daf00cc911 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
@@ -3454,109 +3454,64 @@ static int vega20_get_thermal_temperature_range(struct pp_hwmgr *hwmgr,

 static const struct pp_hwmgr_func vega20_hwmgr_funcs = {
         /* init/fini related */
-       .backend_init =
-               vega20_hwmgr_backend_init,
-       .backend_fini =
-               vega20_hwmgr_backend_fini,
-       .asic_setup =
-               vega20_setup_asic_task,
-       .power_off_asic =
-               vega20_power_off_asic,
-       .dynamic_state_management_enable =
-               vega20_enable_dpm_tasks,
-       .dynamic_state_management_disable =
-               vega20_disable_dpm_tasks,
+       .backend_init = vega20_hwmgr_backend_init,
+       .backend_fini = vega20_hwmgr_backend_fini,
+       .asic_setup = vega20_setup_asic_task,
+       .power_off_asic = vega20_power_off_asic,
+       .dynamic_state_management_enable = vega20_enable_dpm_tasks,
+       .dynamic_state_management_disable = vega20_disable_dpm_tasks,
         /* power state related */
-       .apply_clocks_adjust_rules =
-               vega20_apply_clocks_adjust_rules,
-       .pre_display_config_changed =
-               vega20_pre_display_configuration_changed_task,
-       .display_config_changed =
-               vega20_display_configuration_changed_task,
+       .apply_clocks_adjust_rules = vega20_apply_clocks_adjust_rules,
+       .pre_display_config_changed = vega20_pre_display_configuration_changed_task,
+       .display_config_changed = vega20_display_configuration_changed_task,
         .check_smc_update_required_for_display_configuration =
                 vega20_check_smc_update_required_for_display_configuration,
         .notify_smc_display_config_after_ps_adjustment =
                 vega20_notify_smc_display_config_after_ps_adjustment,
         /* export to DAL */
-       .get_sclk =
-               vega20_dpm_get_sclk,
-       .get_mclk =
-               vega20_dpm_get_mclk,
-       .get_dal_power_level =
-               vega20_get_dal_power_level,
-       .get_clock_by_type_with_latency =
-               vega20_get_clock_by_type_with_latency,
-       .get_clock_by_type_with_voltage =
-               vega20_get_clock_by_type_with_voltage,
-       .set_watermarks_for_clocks_ranges =
-               vega20_set_watermarks_for_clocks_ranges,
-       .display_clock_voltage_request =
-               vega20_display_clock_voltage_request,
-       .get_performance_level =
-               vega20_get_performance_level,
+       .get_sclk = vega20_dpm_get_sclk,
+       .get_mclk = vega20_dpm_get_mclk,
+       .get_dal_power_level = vega20_get_dal_power_level,
+       .get_clock_by_type_with_latency = vega20_get_clock_by_type_with_latency,
+       .get_clock_by_type_with_voltage = vega20_get_clock_by_type_with_voltage,
+       .set_watermarks_for_clocks_ranges = vega20_set_watermarks_for_clocks_ranges,
+       .display_clock_voltage_request = vega20_display_clock_voltage_request,
+       .get_performance_level = vega20_get_performance_level,
         /* UMD pstate, profile related */
-       .force_dpm_level =
-               vega20_dpm_force_dpm_level,
-       .get_power_profile_mode =
-               vega20_get_power_profile_mode,
-       .set_power_profile_mode =
-               vega20_set_power_profile_mode,
+       .force_dpm_level = vega20_dpm_force_dpm_level,
+       .get_power_profile_mode = vega20_get_power_profile_mode,
+       .set_power_profile_mode = vega20_set_power_profile_mode,
         /* od related */
-       .set_power_limit =
-               vega20_set_power_limit,
-       .get_sclk_od =
-               vega20_get_sclk_od,
-       .set_sclk_od =
-               vega20_set_sclk_od,
-       .get_mclk_od =
-               vega20_get_mclk_od,
-       .set_mclk_od =
-               vega20_set_mclk_od,
-       .odn_edit_dpm_table =
-               vega20_odn_edit_dpm_table,
+       .set_power_limit = vega20_set_power_limit,
+       .get_sclk_od = vega20_get_sclk_od,
+       .set_sclk_od = vega20_set_sclk_od,
+       .get_mclk_od = vega20_get_mclk_od,
+       .set_mclk_od = vega20_set_mclk_od,
+       .odn_edit_dpm_table = vega20_odn_edit_dpm_table,
         /* for sysfs to retrive/set gfxclk/memclk */
-       .force_clock_level =
-               vega20_force_clock_level,
-       .print_clock_levels =
-               vega20_print_clock_levels,
-       .read_sensor =
-               vega20_read_sensor,
+       .force_clock_level = vega20_force_clock_level,
+       .print_clock_levels = vega20_print_clock_levels,
+       .read_sensor = vega20_read_sensor,
         /* powergate related */
-       .powergate_uvd =
-               vega20_power_gate_uvd,
-       .powergate_vce =
-               vega20_power_gate_vce,
+       .powergate_uvd = vega20_power_gate_uvd,
+       .powergate_vce = vega20_power_gate_vce,
         /* thermal related */
-       .start_thermal_controller =
-               vega20_start_thermal_controller,
-       .stop_thermal_controller =
-               vega20_thermal_stop_thermal_controller,
-       .get_thermal_temperature_range =
-               vega20_get_thermal_temperature_range,
-       .register_irq_handlers =
-               smu9_register_irq_handlers,
-       .disable_smc_firmware_ctf =
-               vega20_thermal_disable_alert,
+       .start_thermal_controller = vega20_start_thermal_controller,
+       .stop_thermal_controller = vega20_thermal_stop_thermal_controller,
+       .get_thermal_temperature_range = vega20_get_thermal_temperature_range,
+       .register_irq_handlers = smu9_register_irq_handlers,
+       .disable_smc_firmware_ctf = vega20_thermal_disable_alert,
         /* fan control related */
-       .get_fan_speed_percent =
-               vega20_fan_ctrl_get_fan_speed_percent,
-       .set_fan_speed_percent =
-               vega20_fan_ctrl_set_fan_speed_percent,
-       .get_fan_speed_info =
-               vega20_fan_ctrl_get_fan_speed_info,
-       .get_fan_speed_rpm =
-               vega20_fan_ctrl_get_fan_speed_rpm,
-       .set_fan_speed_rpm =
-               vega20_fan_ctrl_set_fan_speed_rpm,
-       .get_fan_control_mode =
-               vega20_get_fan_control_mode,
-       .set_fan_control_mode =
-               vega20_set_fan_control_mode,
+       .get_fan_speed_percent = vega20_fan_ctrl_get_fan_speed_percent,
+       .set_fan_speed_percent = vega20_fan_ctrl_set_fan_speed_percent,
+       .get_fan_speed_info = vega20_fan_ctrl_get_fan_speed_info,
+       .get_fan_speed_rpm = vega20_fan_ctrl_get_fan_speed_rpm,
+       .set_fan_speed_rpm = vega20_fan_ctrl_set_fan_speed_rpm,
+       .get_fan_control_mode = vega20_get_fan_control_mode,
+       .set_fan_control_mode = vega20_set_fan_control_mode,
         /* smu memory related */
-       .notify_cac_buffer_info =
-               vega20_notify_cac_buffer_info,
-       .enable_mgpu_fan_boost =
-               vega20_enable_mgpu_fan_boost,
+       .notify_cac_buffer_info = vega20_notify_cac_buffer_info,
+       .enable_mgpu_fan_boost = vega20_enable_mgpu_fan_boost,
 };

 int vega20_hwmgr_init(struct pp_hwmgr *hwmgr)
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[-- Attachment #1.2: Type: text/html, Size: 16661 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply	other threads:[~2018-11-07 14:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 10:42 [PATCH] drm/amd/powerplay: correct code style Jim Qu
     [not found] ` <20181107104212.14131-1-Jim.Qu-5C7GfCeVMHo@public.gmane.org>
2018-11-07 14:48   ` Deucher, Alexander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR12MB1809E321DAF57F20F4ADA833F7C40@BN6PR12MB1809.namprd12.prod.outlook.com \
    --to=alexander.deucher-5c7gfcevmho@public.gmane.org \
    --cc=Jim.Qu-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.