From: "Bean Huo (beanhuo)" <beanhuo@micron.com>
To: Bart Van Assche <bvanassche@acm.org>,
Avri Altman <avri.altman@wdc.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Yaniv Gardi <ygardi@codeaurora.org>,
Subhash Jadavani <subhashj@codeaurora.org>,
Stanley Chu <stanley.chu@mediatek.com>,
Tomas Winkler <tomas.winkler@intel.com>
Subject: RE: [EXT] [PATCH RFC v2 2/5] ufs: Use reserved tags for TMFs
Date: Tue, 5 Nov 2019 21:47:11 +0000 [thread overview]
Message-ID: <BN7PR08MB56841C9F0D42B50A8CBDE0F5DB7E0@BN7PR08MB5684.namprd08.prod.outlook.com> (raw)
In-Reply-To: <11e7ba67-84ca-2f86-0bce-78646ced9612@acm.org>
>
> On 11/5/19 3:58 AM, Bean Huo (beanhuo) wrote:
> >> host = cmd->device->host;
> >> hba = shost_priv(host);
> >> - tag = cmd->request->tag;
> >> + tag = cmd->request->tag - hba->nutmrs;
> >> + WARN_ON_ONCE(!ufshcd_valid_tag(hba, tag));
> >
> > Changing request tag number here is not proper way, we have trace tool
> > using this tag to track request from block, SCSI to UFS layer. If tags being
> changed in UFS driver, there will be a confusion.
>
> Hi Bean,
>
> Thanks for having taken a look. Which information is used by the tracing tool?
> cmd->request->tag or the variable called 'tag' above? The latter should not be
> modified by this patch. cmd->request->tag is modified however for every
> command that is not a TMF. Preserving the block layer tag value is possible but
> would require to introduce a new tag set for TMFs.
>
> Thanks,
>
> Bart.
Hi, Bart
We are using latter variable 'tag'.
What I concern is that cmd->request->tag and variable tag(UFS driver uses this variable tag)
are consistent without this patch, and now we should change our tag tracking handling mechanism.
But it is not big deal, we can plus hba->nutmrs subtracted before in order to in line with block/scsi tag.
Thanks,
//Bean
next prev parent reply other threads:[~2019-11-05 21:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 0:42 [PATCH RFC v2 0/5] Simplify and optimize the UFS driver Bart Van Assche
2019-11-05 0:42 ` [PATCH RFC v2 1/5] Allow SCSI LLDs to reserve block layer tags Bart Van Assche
2019-11-05 0:42 ` [PATCH RFC v2 2/5] ufs: Use reserved tags for TMFs Bart Van Assche
2019-11-05 0:57 ` Christoph Hellwig
2019-11-05 1:03 ` Bart Van Assche
2019-11-05 11:58 ` [EXT] " Bean Huo (beanhuo)
2019-11-05 17:02 ` Bart Van Assche
2019-11-05 21:47 ` Bean Huo (beanhuo) [this message]
2019-11-05 0:42 ` [PATCH RFC v2 3/5] ufs: Avoid busy-waiting by eliminating tag conflicts Bart Van Assche
2019-11-05 0:42 ` [PATCH RFC v2 4/5] ufs: Use blk_{get,put}_request() to allocate and free TMFs Bart Van Assche
2019-11-05 13:50 ` [EXT] " Bean Huo (beanhuo)
2019-11-05 17:05 ` Bart Van Assche
2019-11-05 21:59 ` Bean Huo (beanhuo)
2019-11-05 0:42 ` [PATCH RFC v2 5/5] ufs: Simplify the clock scaling mechanism implementation Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN7PR08MB56841C9F0D42B50A8CBDE0F5DB7E0@BN7PR08MB5684.namprd08.prod.outlook.com \
--to=beanhuo@micron.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=subhashj@codeaurora.org \
--cc=tomas.winkler@intel.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.