From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FFFC33CA8 for ; Mon, 13 Jan 2020 09:58:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C17FD2080D for ; Mon, 13 Jan 2020 09:58:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=micron.com header.i=@micron.com header.b="xRNgMX61" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726934AbgAMJ6z (ORCPT ); Mon, 13 Jan 2020 04:58:55 -0500 Received: from mail-mw2nam12on2074.outbound.protection.outlook.com ([40.107.244.74]:65153 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725992AbgAMJ6z (ORCPT ); Mon, 13 Jan 2020 04:58:55 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HOz/eEFrG1inWPOM1JJcLgsv4JBMX1suVKQn5dE4h65JIwvEWQOmtxS+piOe9RV+rTxdG42rbnc7R/ox0PUHn4vzHN/ORrAgGyi+AyGJ5nCSY2s+aQ1zPyT70HuxGR4ItL/WuNstqu/xIu6A+d86ZX2iXPKxCeqHUp/ZU7SkTT2/YOETchRBoWvqhlWsWQu15OtE1DQHqT3K6TWi5gvpC6IE2XgTPDYMLX64z3YjHO+7FdwDbSsVnQdJtbSSVMP5VYjfxSqDuNjpHrBB8qgR2/CVtm4JufQHn6IgRHhKMy5vk8CUnfQp1Ct1cFuGJLygkDGZlO0s7Ws94669nt421A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkzh2HqmbmY1jtwx3yTyry6Lixdo5GjU70EYVHBqcZI=; b=Kx8weRhF4MLXzGE3A5r2jRxXxjMcvBATMgwNZ3s/dfQ1wCn3z/YnWD6cDWeKDs5ROdG0dopFGZNxP5vZPRTeR313HMAHvKIC779BYOaXP/0K4T22cJ4Qq4+ujxpO82iZ0D9YJ75qLbz3ZcpO9Ao98q9edJJ1pX8tvw4DgrKIqMtqFrXul0QPL+Gfiv521T0Uy5ya8YQBYsIdA3ptVZF+I3iBR3cFB+5/4DBNiCfkUOh1jNIOA2WcF1CGYprQTY+tsC/XL/yIJ3XrV20ClqSH2uLpBTks29N65rwQJFWIrZKFDck2q6j+FJr67lzu1F/jwXU0in9pvRN9rwKdhQLHPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=micron.com; dmarc=pass action=none header.from=micron.com; dkim=pass header.d=micron.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=micron.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkzh2HqmbmY1jtwx3yTyry6Lixdo5GjU70EYVHBqcZI=; b=xRNgMX619b8LJzLAVJHBEl9NVPl0K/FdIT5TIVK7aAYi7ACN50UsZDdntrXZL6g/OZ/LpHtIAZ0jVIRiZPqHE4IQJKYaNMWqebNus4AydKQ271avkxHpqK+iGyPf07zoviqISfWmnp8KjcVp1M9CjcfxNEJY4PXY1EWAPh4Nmew= Received: from BN7PR08MB5684.namprd08.prod.outlook.com (20.176.179.87) by BN7PR08MB5089.namprd08.prod.outlook.com (20.176.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Mon, 13 Jan 2020 09:58:52 +0000 Received: from BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::981f:90d7:d45f:fd11]) by BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::981f:90d7:d45f:fd11%7]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 09:58:52 +0000 From: "Bean Huo (beanhuo)" To: Stanley Chu CC: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "avri.altman@wdc.com" , "alim.akhtar@samsung.com" , "jejb@linux.ibm.com" , "asutoshd@codeaurora.org" , "cang@codeaurora.org" , "matthias.bgg@gmail.com" , "bvanassche@acm.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kuohong.wang@mediatek.com" , "peter.wang@mediatek.com" , "chun-hung.wu@mediatek.com" , "andy.teng@mediatek.com" Subject: RE: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history Thread-Topic: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history Thread-Index: AQHVwwrtYdyISOHmvEWfKtFqbPPmzqfoX2LQgAAGaICAAABC0A== Date: Mon, 13 Jan 2020 09:58:51 +0000 Message-ID: References: <1578147968-30938-1-git-send-email-stanley.chu@mediatek.com> <1578147968-30938-2-git-send-email-stanley.chu@mediatek.com> <1578908621.17435.18.camel@mtkswgap22> In-Reply-To: <1578908621.17435.18.camel@mtkswgap22> Accept-Language: en-150, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYmVhbmh1b1xhcHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJhMjllMzViXG1zZ3NcbXNnLTQ5ZWNkZDY2LTM1ZWItMTFlYS04Yjg4LWRjNzE5NjFmOWRkM1xhbWUtdGVzdFw0OWVjZGQ2Ny0zNWViLTExZWEtOGI4OC1kYzcxOTYxZjlkZDNib2R5LnR4dCIgc3o9IjE3MjkiIHQ9IjEzMjIzMzgzMTI3MjU3NzA3MCIgaD0iR29mQVgwaU90MEJUTmtzY0FBenVqZFdncnhNPSIgaWQ9IiIgYmw9IjAiIGJvPSIxIi8+PC9tZXRhPg== x-dg-rorf: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=beanhuo@micron.com; x-originating-ip: [195.89.176.137] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3551af9-03c7-4af9-e0cb-08d7980f31df x-ms-traffictypediagnostic: BN7PR08MB5089:|BN7PR08MB5089:|BN7PR08MB5089: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(136003)(376002)(346002)(366004)(396003)(189003)(199004)(4326008)(54906003)(71200400001)(86362001)(8936002)(9686003)(55016002)(8676002)(7696005)(81156014)(2906002)(6916009)(66946007)(33656002)(66556008)(76116006)(66446008)(64756008)(66476007)(478600001)(81166006)(7416002)(5660300002)(6506007)(52536014)(26005)(186003)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR08MB5089;H:BN7PR08MB5684.namprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: micron.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6zrUJ3uxkhrShR1eBkUvsN2fwy2LNolvKQwC/GgTAkgQx2mUepfSOkeoDlFo3aVnKjUkL+2JEe6Eo84Gn+JfRvE0Dxrav2q4nlJpGR6tBGyO9mP81/I2KvyTRWCIov03SH09KbLDtyupnk+JiOOy9GTHvkkSwdSBqCc6ZnRZP4Vzvk36cbGglo/nqdHhQsxCd2drhN89Vl4cGBp6XvJDGc3JucXmZ1LUfXtlJ8Zr/4WWjJrmyQMr2ZwPMoLRduDUVk6/oq6XRbywOOvQAxqfJNmtecJicWu5m5NdDn+muwDBe4dQIeIg1TBgXaWSXH7weMHCfNITGARk2MEAWGbppja9r5rTU08PLOMUPFpPn6FGTnPYLPI171adMBTVRWH81pQiX97qV2mMlS+izGIPYADcbRS5L5GQ9ajeDBaME5qfXA8e5cz1iw7LXGS7lTet Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: micron.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3551af9-03c7-4af9-e0cb-08d7980f31df X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 09:58:52.2715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kpVHKFgO4HKMqNpgRCfInpjUdg5mAM31h63RDvRDe400+3SHFjbOqc26FfMPdry3pRqRZCaPotwaWFeh6DrDug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR08MB5089 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiBTdWJqZWN0OiBSRTogW0VYVF0gW1BBVENIIHYxIDEvM10gc2NzaTogdWZzOiBmaXggZW1wdHkg Y2hlY2sgb2YgZXJyb3IgaGlzdG9yeQ0KPiANCj4gSGkgQmVhbiwNCj4gDQo+IE9uIE1vbiwgMjAy MC0wMS0xMyBhdCAwOToyOCArMDAwMCwgQmVhbiBIdW8gKGJlYW5odW8pIHdyb3RlOg0KPiA+IEhp LCBTdGFubGV5DQo+ID4NCj4gPiA+DQo+ID4gPiBDdXJyZW50bHkgY2hlY2tpbmcgaWYgYW4gZXJy b3IgaGlzdG9yeSBlbGVtZW50IGlzIGVtcHR5IG9yIG5vdCBpcyBieQ0KPiA+ID4gaXRzICJ2YWx1 ZSIuIEluIG1vc3QgY2FzZXMsIHZhbHVlIGlzIGVycm9yIGNvZGUuDQo+ID4gPg0KPiA+ID4gSG93 ZXZlciB0aGlzIGNoZWNraW5nIGlzIG5vdCBjb3JyZWN0IGJlY2F1c2Ugc29tZSBlcnJvcnMgb3Ig ZXZlbnRzDQo+ID4gPiBkbyBub3Qgc3BlY2lmeSBhbnkgdmFsdWVzIGluIGVycm9yIGhpc3Rvcnkg c28gdmFsdWVzIHJlbWFpbiBhcyAwLA0KPiA+ID4gYW5kIHRoaXMgd2lsbCBsZWFkIHRvIGluY29y cmVjdCBlbXB0eSBjaGVja2luZy4NCj4gPiA+DQo+ID4gRG8geW91IHRoaW5rIHRoaXMgaXMgYSBi dWcgb2YgVUZTIGhvc3QgY29udHJvbGxlcj8gQWNjb3JkaW5nIHRvIHRoZQ0KPiA+IFVGUyBob3N0 IFNwZWMsIElmIHRoZXJlIGhhZCBlcnJvciBkZXRlY3RlZCBpbiBlYWNoIGxheWVyLCBhdCBsZWFz dA0KPiA+IGJpdDMxIGluIGl0cyBlcnJvciBjb2RlIHJlZ2lzdGVyIFNob3VsZCBiZSBzZXQgdG8g MS4NCj4gPg0KPiA+IFdoeSB0aGVyZSB3YXMgYW4gZXJyb3IgaGFwcGVuaW5nLCBidXQgaG9zdCBk aWRuJ3Qgc2V0IHRoaXMgYml0MzE/DQo+ID4NCj4gDQo+IFRoYW5rcyBzbyBtdWNoIGZvciByZXZp ZXcuDQo+IA0KPiBZZXMsIHRoZSBjYXNlIGJpdFszMV0gc2V0IGlzIHRydWUgZm9yIFVJQyBlcnJv cnMuDQo+IA0KPiBIb3dldmVyIHRoZSB1c2VycyBvZiBVRlMgZXJyb3IgaGlzdG9yeSwgaS5lLiwg dXNlcnMgb2YgdWZzaGNkX3VwZGF0ZV9yZWdfaGxpc3QoKSwNCj4gYXJlIG5vdCBvbmx5IFVJQyBl cnJvcnMuIFNvbWUgb3RoZXIgZXNzZW50aWFsIGV2ZW50cyB3aWxsIHVwZGF0ZSBoaXN0b3J5IHRv bywgZm9yDQo+IGV4YW1wbGUsIGRldmljZSByZXNldCBldmVudHMgYW5kIGFib3J0IGV2ZW50cy4N Cj4gDQo+IFRha2UgImRldmljZSByZXNldCBldmVudHMiIGFzIGV4YW1wbGU6IHBhcmFtZXRlciAi dmFsIiBtYXkgYmUgMCB3aGlsZSBpbnZva2luZw0KPiB1ZnNoY2RfdXBkYXRlX3JlZ19obGlzdCgp LiBJZiB0aGlzIGhhcHBlbnMsIHRoZSBkZXZpY2UgcmVzZXQgZXZlbnQgd2lsbCBub3QgYmUNCj4g cHJpbnRlZCBvdXQgYmVjYXVzZSBpdHMgZXJyX2hpc3QtPnJlZ1twXSBpcyAwIGFjY29yZGluZyB0 byB0aGUgb3JpZ2luYWwgbG9naWMgaW4NCj4gdWZzaGNkX3ByaW50X2Vycl9oaXN0KCkuDQo+IA0K PiBGZWVsIGZyZWUgdG8gY29ycmVjdCBhYm92ZSBkZXNjcmlwdGlvbiBpZiBpdCBpcyB3cm9uZy4N Cj4gDQo+IFRoYW5rcywNCj4gU3RhbmxleQ0KDQpIaSwgU3RhbmxleQ0KVGhhbmtzLCBub3cgY2xl YXIsIGl0IGlzIG5vdCBjb250cm9sbGVyIG5lZ2F0aXZlIGFjdCBpc3N1ZS4NCg0KUmV2aWV3ZWQt Ynk6IEJlYW4gSHVvIDxiZWFuaHVvQG1pY3Jvbi5jb20+DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2574C33CA8 for ; Mon, 13 Jan 2020 09:59:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9005C2080D for ; Mon, 13 Jan 2020 09:59:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uUzVp4mi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=micron.com header.i=@micron.com header.b="xRNgMX61" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9005C2080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=micron.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O+uPaNbqkUEQctRV1fnXzjfEhMf4TDaYOCGeIsFku78=; b=uUzVp4mid4Yj7V GRn2cmjRzH5h3dE6opjhD9X0xZ9WNzzDNPORnTJVpbU0QsNcLCgya5YphE2+CqX9T1atIOcyuxou2 0o9xeo57bjwr2YiZ4HFRBUXbpSFwHChWHP4iZJFC27zlOanfofQl80d7A/uPRgpsz4N7ir78WaNv8 j2uqikFV1sh5/ce0TkmHY8M2Crrk+Y5pDEMFbRW5gLP/FYlmgw9avPc/BfjHal1Kq/C9e7nAz9N6r gdS3N69xcLkvvzdbsqTL86EqOaRmEgnlK8i2eIpclaVR6pyyaxwgGkr4YCI2sYX6lO5Mn9waaBgRk 5lE87CdaRPuE+7i4/Xxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqwUr-00080c-SN; Mon, 13 Jan 2020 09:58:57 +0000 Received: from mail-mw2nam12on2078.outbound.protection.outlook.com ([40.107.244.78] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqwUp-0007zS-BF; Mon, 13 Jan 2020 09:58:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HOz/eEFrG1inWPOM1JJcLgsv4JBMX1suVKQn5dE4h65JIwvEWQOmtxS+piOe9RV+rTxdG42rbnc7R/ox0PUHn4vzHN/ORrAgGyi+AyGJ5nCSY2s+aQ1zPyT70HuxGR4ItL/WuNstqu/xIu6A+d86ZX2iXPKxCeqHUp/ZU7SkTT2/YOETchRBoWvqhlWsWQu15OtE1DQHqT3K6TWi5gvpC6IE2XgTPDYMLX64z3YjHO+7FdwDbSsVnQdJtbSSVMP5VYjfxSqDuNjpHrBB8qgR2/CVtm4JufQHn6IgRHhKMy5vk8CUnfQp1Ct1cFuGJLygkDGZlO0s7Ws94669nt421A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkzh2HqmbmY1jtwx3yTyry6Lixdo5GjU70EYVHBqcZI=; b=Kx8weRhF4MLXzGE3A5r2jRxXxjMcvBATMgwNZ3s/dfQ1wCn3z/YnWD6cDWeKDs5ROdG0dopFGZNxP5vZPRTeR313HMAHvKIC779BYOaXP/0K4T22cJ4Qq4+ujxpO82iZ0D9YJ75qLbz3ZcpO9Ao98q9edJJ1pX8tvw4DgrKIqMtqFrXul0QPL+Gfiv521T0Uy5ya8YQBYsIdA3ptVZF+I3iBR3cFB+5/4DBNiCfkUOh1jNIOA2WcF1CGYprQTY+tsC/XL/yIJ3XrV20ClqSH2uLpBTks29N65rwQJFWIrZKFDck2q6j+FJr67lzu1F/jwXU0in9pvRN9rwKdhQLHPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=micron.com; dmarc=pass action=none header.from=micron.com; dkim=pass header.d=micron.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=micron.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkzh2HqmbmY1jtwx3yTyry6Lixdo5GjU70EYVHBqcZI=; b=xRNgMX619b8LJzLAVJHBEl9NVPl0K/FdIT5TIVK7aAYi7ACN50UsZDdntrXZL6g/OZ/LpHtIAZ0jVIRiZPqHE4IQJKYaNMWqebNus4AydKQ271avkxHpqK+iGyPf07zoviqISfWmnp8KjcVp1M9CjcfxNEJY4PXY1EWAPh4Nmew= Received: from BN7PR08MB5684.namprd08.prod.outlook.com (20.176.179.87) by BN7PR08MB5089.namprd08.prod.outlook.com (20.176.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Mon, 13 Jan 2020 09:58:52 +0000 Received: from BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::981f:90d7:d45f:fd11]) by BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::981f:90d7:d45f:fd11%7]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 09:58:52 +0000 From: "Bean Huo (beanhuo)" To: Stanley Chu Subject: RE: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history Thread-Topic: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history Thread-Index: AQHVwwrtYdyISOHmvEWfKtFqbPPmzqfoX2LQgAAGaICAAABC0A== Date: Mon, 13 Jan 2020 09:58:51 +0000 Message-ID: References: <1578147968-30938-1-git-send-email-stanley.chu@mediatek.com> <1578147968-30938-2-git-send-email-stanley.chu@mediatek.com> <1578908621.17435.18.camel@mtkswgap22> In-Reply-To: <1578908621.17435.18.camel@mtkswgap22> Accept-Language: en-150, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYmVhbmh1b1xhcHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJhMjllMzViXG1zZ3NcbXNnLTQ5ZWNkZDY2LTM1ZWItMTFlYS04Yjg4LWRjNzE5NjFmOWRkM1xhbWUtdGVzdFw0OWVjZGQ2Ny0zNWViLTExZWEtOGI4OC1kYzcxOTYxZjlkZDNib2R5LnR4dCIgc3o9IjE3MjkiIHQ9IjEzMjIzMzgzMTI3MjU3NzA3MCIgaD0iR29mQVgwaU90MEJUTmtzY0FBenVqZFdncnhNPSIgaWQ9IiIgYmw9IjAiIGJvPSIxIi8+PC9tZXRhPg== x-dg-rorf: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=beanhuo@micron.com; x-originating-ip: [195.89.176.137] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3551af9-03c7-4af9-e0cb-08d7980f31df x-ms-traffictypediagnostic: BN7PR08MB5089:|BN7PR08MB5089:|BN7PR08MB5089: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(376002)(346002)(366004)(396003)(189003)(199004)(4326008)(54906003)(71200400001)(86362001)(8936002)(9686003)(55016002)(8676002)(7696005)(81156014)(2906002)(6916009)(66946007)(33656002)(66556008)(76116006)(66446008)(64756008)(66476007)(478600001)(81166006)(7416002)(5660300002)(6506007)(52536014)(26005)(186003)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR08MB5089; H:BN7PR08MB5684.namprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: micron.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6zrUJ3uxkhrShR1eBkUvsN2fwy2LNolvKQwC/GgTAkgQx2mUepfSOkeoDlFo3aVnKjUkL+2JEe6Eo84Gn+JfRvE0Dxrav2q4nlJpGR6tBGyO9mP81/I2KvyTRWCIov03SH09KbLDtyupnk+JiOOy9GTHvkkSwdSBqCc6ZnRZP4Vzvk36cbGglo/nqdHhQsxCd2drhN89Vl4cGBp6XvJDGc3JucXmZ1LUfXtlJ8Zr/4WWjJrmyQMr2ZwPMoLRduDUVk6/oq6XRbywOOvQAxqfJNmtecJicWu5m5NdDn+muwDBe4dQIeIg1TBgXaWSXH7weMHCfNITGARk2MEAWGbppja9r5rTU08PLOMUPFpPn6FGTnPYLPI171adMBTVRWH81pQiX97qV2mMlS+izGIPYADcbRS5L5GQ9ajeDBaME5qfXA8e5cz1iw7LXGS7lTet MIME-Version: 1.0 X-OriginatorOrg: micron.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3551af9-03c7-4af9-e0cb-08d7980f31df X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 09:58:52.2715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kpVHKFgO4HKMqNpgRCfInpjUdg5mAM31h63RDvRDe400+3SHFjbOqc26FfMPdry3pRqRZCaPotwaWFeh6DrDug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR08MB5089 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200113_015855_388614_C8933D53 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "avri.altman@wdc.com" , "cang@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "bvanassche@acm.org" , "linux-arm-kernel@lists.infradead.org" , "asutoshd@codeaurora.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org > Subject: RE: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history > > Hi Bean, > > On Mon, 2020-01-13 at 09:28 +0000, Bean Huo (beanhuo) wrote: > > Hi, Stanley > > > > > > > > Currently checking if an error history element is empty or not is by > > > its "value". In most cases, value is error code. > > > > > > However this checking is not correct because some errors or events > > > do not specify any values in error history so values remain as 0, > > > and this will lead to incorrect empty checking. > > > > > Do you think this is a bug of UFS host controller? According to the > > UFS host Spec, If there had error detected in each layer, at least > > bit31 in its error code register Should be set to 1. > > > > Why there was an error happening, but host didn't set this bit31? > > > > Thanks so much for review. > > Yes, the case bit[31] set is true for UIC errors. > > However the users of UFS error history, i.e., users of ufshcd_update_reg_hlist(), > are not only UIC errors. Some other essential events will update history too, for > example, device reset events and abort events. > > Take "device reset events" as example: parameter "val" may be 0 while invoking > ufshcd_update_reg_hlist(). If this happens, the device reset event will not be > printed out because its err_hist->reg[p] is 0 according to the original logic in > ufshcd_print_err_hist(). > > Feel free to correct above description if it is wrong. > > Thanks, > Stanley Hi, Stanley Thanks, now clear, it is not controller negative act issue. Reviewed-by: Bean Huo _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 299C6C33CA8 for ; Mon, 13 Jan 2020 09:59:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCC1F2080D for ; Mon, 13 Jan 2020 09:59:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aDubF8Tn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=micron.com header.i=@micron.com header.b="xRNgMX61" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCC1F2080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=micron.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oHEB8C6HS7WeeiEEbfEYRSdrH3Ux1sYY8TaYuPFjM4s=; b=aDubF8Tn6emr2O fM0pf5sjbUQ/roSXGPmx8Qu3lSmzuazaXTaQ998BNm7zgLPFUntlbR5fPNLa18qMMHcFHeVRMwHrd v+UXQxt53XEvp62T5lYVt6VRLoc5mQhbAAuRYrQUTd7Xn4A5C7f6+NNbpmjlsGmDF29Fl7RfSbYu+ mrE4Y/kbsrSyo3qG5wWkZKHyIJ4HprT3p0FTM/swNloLFazMtBq1etUcxMcrDOA8OY2gkzIG+n1CQ R7lOFaqI+cl0JeVwq5QXcQRpopSBg5+neSOdUnqgSRMyBhJLEpfl5ywP65LMLKpqguPSQYUWJhKW5 P1KfmmrI729kdpyuLBig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqwUt-00081S-2f; Mon, 13 Jan 2020 09:58:59 +0000 Received: from mail-mw2nam12on2078.outbound.protection.outlook.com ([40.107.244.78] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqwUp-0007zS-BF; Mon, 13 Jan 2020 09:58:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HOz/eEFrG1inWPOM1JJcLgsv4JBMX1suVKQn5dE4h65JIwvEWQOmtxS+piOe9RV+rTxdG42rbnc7R/ox0PUHn4vzHN/ORrAgGyi+AyGJ5nCSY2s+aQ1zPyT70HuxGR4ItL/WuNstqu/xIu6A+d86ZX2iXPKxCeqHUp/ZU7SkTT2/YOETchRBoWvqhlWsWQu15OtE1DQHqT3K6TWi5gvpC6IE2XgTPDYMLX64z3YjHO+7FdwDbSsVnQdJtbSSVMP5VYjfxSqDuNjpHrBB8qgR2/CVtm4JufQHn6IgRHhKMy5vk8CUnfQp1Ct1cFuGJLygkDGZlO0s7Ws94669nt421A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkzh2HqmbmY1jtwx3yTyry6Lixdo5GjU70EYVHBqcZI=; b=Kx8weRhF4MLXzGE3A5r2jRxXxjMcvBATMgwNZ3s/dfQ1wCn3z/YnWD6cDWeKDs5ROdG0dopFGZNxP5vZPRTeR313HMAHvKIC779BYOaXP/0K4T22cJ4Qq4+ujxpO82iZ0D9YJ75qLbz3ZcpO9Ao98q9edJJ1pX8tvw4DgrKIqMtqFrXul0QPL+Gfiv521T0Uy5ya8YQBYsIdA3ptVZF+I3iBR3cFB+5/4DBNiCfkUOh1jNIOA2WcF1CGYprQTY+tsC/XL/yIJ3XrV20ClqSH2uLpBTks29N65rwQJFWIrZKFDck2q6j+FJr67lzu1F/jwXU0in9pvRN9rwKdhQLHPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=micron.com; dmarc=pass action=none header.from=micron.com; dkim=pass header.d=micron.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=micron.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkzh2HqmbmY1jtwx3yTyry6Lixdo5GjU70EYVHBqcZI=; b=xRNgMX619b8LJzLAVJHBEl9NVPl0K/FdIT5TIVK7aAYi7ACN50UsZDdntrXZL6g/OZ/LpHtIAZ0jVIRiZPqHE4IQJKYaNMWqebNus4AydKQ271avkxHpqK+iGyPf07zoviqISfWmnp8KjcVp1M9CjcfxNEJY4PXY1EWAPh4Nmew= Received: from BN7PR08MB5684.namprd08.prod.outlook.com (20.176.179.87) by BN7PR08MB5089.namprd08.prod.outlook.com (20.176.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Mon, 13 Jan 2020 09:58:52 +0000 Received: from BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::981f:90d7:d45f:fd11]) by BN7PR08MB5684.namprd08.prod.outlook.com ([fe80::981f:90d7:d45f:fd11%7]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 09:58:52 +0000 From: "Bean Huo (beanhuo)" To: Stanley Chu Subject: RE: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history Thread-Topic: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history Thread-Index: AQHVwwrtYdyISOHmvEWfKtFqbPPmzqfoX2LQgAAGaICAAABC0A== Date: Mon, 13 Jan 2020 09:58:51 +0000 Message-ID: References: <1578147968-30938-1-git-send-email-stanley.chu@mediatek.com> <1578147968-30938-2-git-send-email-stanley.chu@mediatek.com> <1578908621.17435.18.camel@mtkswgap22> In-Reply-To: <1578908621.17435.18.camel@mtkswgap22> Accept-Language: en-150, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYmVhbmh1b1xhcHBkYXRhXHJvYW1pbmdcMDlkODQ5YjYtMzJkMy00YTQwLTg1ZWUtNmI4NGJhMjllMzViXG1zZ3NcbXNnLTQ5ZWNkZDY2LTM1ZWItMTFlYS04Yjg4LWRjNzE5NjFmOWRkM1xhbWUtdGVzdFw0OWVjZGQ2Ny0zNWViLTExZWEtOGI4OC1kYzcxOTYxZjlkZDNib2R5LnR4dCIgc3o9IjE3MjkiIHQ9IjEzMjIzMzgzMTI3MjU3NzA3MCIgaD0iR29mQVgwaU90MEJUTmtzY0FBenVqZFdncnhNPSIgaWQ9IiIgYmw9IjAiIGJvPSIxIi8+PC9tZXRhPg== x-dg-rorf: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=beanhuo@micron.com; x-originating-ip: [195.89.176.137] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3551af9-03c7-4af9-e0cb-08d7980f31df x-ms-traffictypediagnostic: BN7PR08MB5089:|BN7PR08MB5089:|BN7PR08MB5089: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(376002)(346002)(366004)(396003)(189003)(199004)(4326008)(54906003)(71200400001)(86362001)(8936002)(9686003)(55016002)(8676002)(7696005)(81156014)(2906002)(6916009)(66946007)(33656002)(66556008)(76116006)(66446008)(64756008)(66476007)(478600001)(81166006)(7416002)(5660300002)(6506007)(52536014)(26005)(186003)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR08MB5089; H:BN7PR08MB5684.namprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: micron.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6zrUJ3uxkhrShR1eBkUvsN2fwy2LNolvKQwC/GgTAkgQx2mUepfSOkeoDlFo3aVnKjUkL+2JEe6Eo84Gn+JfRvE0Dxrav2q4nlJpGR6tBGyO9mP81/I2KvyTRWCIov03SH09KbLDtyupnk+JiOOy9GTHvkkSwdSBqCc6ZnRZP4Vzvk36cbGglo/nqdHhQsxCd2drhN89Vl4cGBp6XvJDGc3JucXmZ1LUfXtlJ8Zr/4WWjJrmyQMr2ZwPMoLRduDUVk6/oq6XRbywOOvQAxqfJNmtecJicWu5m5NdDn+muwDBe4dQIeIg1TBgXaWSXH7weMHCfNITGARk2MEAWGbppja9r5rTU08PLOMUPFpPn6FGTnPYLPI171adMBTVRWH81pQiX97qV2mMlS+izGIPYADcbRS5L5GQ9ajeDBaME5qfXA8e5cz1iw7LXGS7lTet MIME-Version: 1.0 X-OriginatorOrg: micron.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3551af9-03c7-4af9-e0cb-08d7980f31df X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 09:58:52.2715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kpVHKFgO4HKMqNpgRCfInpjUdg5mAM31h63RDvRDe400+3SHFjbOqc26FfMPdry3pRqRZCaPotwaWFeh6DrDug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR08MB5089 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200113_015855_388614_C8933D53 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "avri.altman@wdc.com" , "cang@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "bvanassche@acm.org" , "linux-arm-kernel@lists.infradead.org" , "asutoshd@codeaurora.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Subject: RE: [EXT] [PATCH v1 1/3] scsi: ufs: fix empty check of error history > > Hi Bean, > > On Mon, 2020-01-13 at 09:28 +0000, Bean Huo (beanhuo) wrote: > > Hi, Stanley > > > > > > > > Currently checking if an error history element is empty or not is by > > > its "value". In most cases, value is error code. > > > > > > However this checking is not correct because some errors or events > > > do not specify any values in error history so values remain as 0, > > > and this will lead to incorrect empty checking. > > > > > Do you think this is a bug of UFS host controller? According to the > > UFS host Spec, If there had error detected in each layer, at least > > bit31 in its error code register Should be set to 1. > > > > Why there was an error happening, but host didn't set this bit31? > > > > Thanks so much for review. > > Yes, the case bit[31] set is true for UIC errors. > > However the users of UFS error history, i.e., users of ufshcd_update_reg_hlist(), > are not only UIC errors. Some other essential events will update history too, for > example, device reset events and abort events. > > Take "device reset events" as example: parameter "val" may be 0 while invoking > ufshcd_update_reg_hlist(). If this happens, the device reset event will not be > printed out because its err_hist->reg[p] is 0 according to the original logic in > ufshcd_print_err_hist(). > > Feel free to correct above description if it is wrong. > > Thanks, > Stanley Hi, Stanley Thanks, now clear, it is not controller negative act issue. Reviewed-by: Bean Huo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel