From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Jun Yang <jun.yang@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support unequal number of RXQ and TXQ
Date: Wed, 11 Dec 2019 09:59:19 +0000 [thread overview]
Message-ID: <BN7PR11MB2547351B8955754B08C5A3529A5A0@BN7PR11MB2547.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20191211053009.14906-1-hemant.agrawal@nxp.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Hemant Agrawal
> Sent: Wednesday, December 11, 2019 5:30 AM
> To: dev@dpdk.org
> Cc: Jun Yang <jun.yang@nxp.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: support unequal number of RXQ and TXQ
>
> From: Jun Yang <jun.yang@nxp.com>
>
> The existing forwarding mode usages the total number of
> queues as the minimum of rxq and txq.
> It finds the txq as the same index as rxq.
> However in some scenarios, specially for flow control
> the number of rxq and txq can be different.
> This patch maxes the txq and function of rxq for all such
> scenario instead of keeping 1:1 relationship between the two.
>
> Now packets from all RXQs can be forwarded to TXQs
>
> Signed-off-by: Jun Yang <jun.yang@nxp.com>
> ---
> app/test-pmd/config.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index d59968278..efa409453 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -2130,8 +2130,6 @@ rss_fwd_config_setup(void)
> streamid_t sm_id;
>
> nb_q = nb_rxq;
> - if (nb_q > nb_txq)
> - nb_q = nb_txq;
> cur_fwd_config.nb_fwd_lcores = (lcoreid_t) nb_fwd_lcores;
> cur_fwd_config.nb_fwd_ports = nb_fwd_ports;
> cur_fwd_config.nb_fwd_streams =
> @@ -2154,7 +2152,7 @@ rss_fwd_config_setup(void)
> fs->rx_port = fwd_ports_ids[rxp];
> fs->rx_queue = rxq;
> fs->tx_port = fwd_ports_ids[txp];
> - fs->tx_queue = rxq;
> + fs->tx_queue = (rxq % nb_txq);
But does it mean that now 2 lcores cah use the same TX queue?
If so, then how it supposed to work?
> fs->peer_addr = fs->tx_port;
> fs->retry_enabled = retry_enabled;
> rxp++;
> --
> 2.17.1
next prev parent reply other threads:[~2019-12-11 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 5:30 [dpdk-dev] [PATCH] app/testpmd: support unequal number of RXQ and TXQ Hemant Agrawal
2019-12-11 9:59 ` Ananyev, Konstantin [this message]
2019-12-11 10:26 ` Jerin Jacob
2019-12-12 11:20 ` Hemant Agrawal
2023-08-20 15:49 ` Stephen Hemminger
2021-09-28 11:08 nipun.gupta
2021-09-30 13:45 ` Ferruh Yigit
2021-10-01 7:22 ` Nipun Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN7PR11MB2547351B8955754B08C5A3529A5A0@BN7PR11MB2547.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jun.yang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.