RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for the quad-uart function in the multi-function endpoint of pci1xxxx device.

[<Kumaravel.Thiagarajan@microchip.com>]

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Wednesday, August 31, 2022 1:28 AM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>; Jiri Slaby <jirislaby@kernel.org>;
> Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>; Andy Shevchenko
> <andy.shevchenko@gmail.com>; Uwe Kleine-König <u.kleine-
> koenig@pengutronix.de>; Johan Hovold <johan@kernel.org>;
> wander@redhat.com; etremblay@distech-controls.com; Maciej W. Rozycki
> <macro@orcam.me.uk>; Jeremy Kerr <jk@ozlabs.org>; Phil Edworthy
> <phil.edworthy@renesas.com>; Lukas Wunner <lukas@wunner.de>; Linux
> Kernel Mailing List <linux-kernel@vger.kernel.org>; open list:SERIAL DRIVERS
> <linux-serial@vger.kernel.org>; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>
> Subject: Re: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for
> the quad-uart function in the multi-function endpoint of pci1xxxx device.
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Hi Kumaravel,
> 
> On Tue, Aug 30, 2022 at 8:01 PM Kumaravel Thiagarajan
> <kumaravel.thiagarajan@microchip.com> wrote:
> > pci1xxxx is a PCIe switch with a multi-function endpoint on one of its
> > downstream ports. Quad-uart is one of the functions in the
> > multi-function endpoint. This driver loads for the quad-uart and
> > enumerates single or multiple instances of uart based on the PCIe
> > subsystem device ID.
> >
> > Signed-off-by: Kumaravel Thiagarajan
> > <kumaravel.thiagarajan@microchip.com>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/drivers/tty/serial/8250/8250_pci1xxxx.c
> 
> > +static struct pci_driver pci1xxxx_pci_driver = {
> > +       .name           = "pci1xxxx serial",
> > +       .probe          = pci1xxxx_serial_probe,
> > +       .remove = pci1xxxx_serial_remove,
> > +       .id_table       = pci1xxxx_pci_tbl,
> > +};
> > +
> > +module_pci_driver(pci1xxxx_pci_driver);
> 
> > --- a/drivers/tty/serial/8250/Kconfig
> > +++ b/drivers/tty/serial/8250/Kconfig
> > @@ -528,6 +528,15 @@ config SERIAL_8250_TEGRA
> >           Select this option if you have machine with an NVIDIA Tegra SoC and
> >           wish to enable 8250 serial driver for the Tegra serial interfaces.
> >
> > +config SERIAL_8250_PCI1XXXX
> > +       tristate "Microchip 8250 based serial port"
> > +       depends on SERIAL_8250
> 
> As this is a PCI driver, I guess it should depend on PCI (|| COMPILE_TEST)?
Ok. I will review this and modify as required.

> 
> > +       help
> > +        Select this option if you have a setup with Microchip PCIe
> > +        Switch with serial port enabled and wish to enable 8250
> > +        serial driver for the serial interface. This driver support
> > +        will ensure to support baud rates upto 1.5Mpbs.
> 

Thank You.

Regards,
Kumaravel