From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC58CC433F5 for ; Sat, 18 Sep 2021 03:19:58 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 5511361076 for ; Sat, 18 Sep 2021 03:19:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5511361076 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 881304014E; Sat, 18 Sep 2021 05:19:57 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 1138A4003D for ; Sat, 18 Sep 2021 05:19:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10110"; a="308453571" X-IronPort-AV: E=Sophos;i="5.85,303,1624345200"; d="scan'208";a="308453571" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2021 20:19:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,303,1624345200"; d="scan'208";a="483270120" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 17 Sep 2021 20:19:53 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 17 Sep 2021 20:19:52 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 17 Sep 2021 20:19:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 17 Sep 2021 20:19:52 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 17 Sep 2021 20:19:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IjKkm3hgG5+1RVvEw5tuF5dkSlluIVlBf3LSoPeQ+eRqQujaN1gx6E9JiO3wbj+kXXw6zu8Lhk4m0OQJm1LNhB3DboKQwJp/Iad1FYBv9nK/KLyiX3vYA8QHTB7rXTgftliEXeA0EGNYsPrIhcwMQeWLz6HUikR7LoG6fzCUV/ciXqxcuQo1fWE0QJIcOxFeaeyu42shpZ2IMoKPxGa6MkX+/bcQy0eDTFZGOQbeyzkHAGy1E36sVT7Nol3F+nyRgOAg1PQvJuw/vBPNYEQzLTLvZTTp0rqhV+zThvYZN6ySF7rcl4bcxpC1x/F3u5a21cx9Yt85pk8sFuPgTfX/oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YHRbx2DHvJKPynYVFj2rA6aTJGXJ6x1wk/4nZcNAOWs=; b=Fqaw8siVmOO0/TvJ5QXsdCILpSsb809z5ZckmblJSuEPR+kCMrj76MbVSjgpeR/T8sMKrK8LTElWUc8KBHsaW11JHMqqUjAWmNQkL7wXoTyyi6LSuOdqjcUn+zIisbafi5ShyggeD1f97nEJ6TsXnMZLOKo4Z/7bLMp6BAeLIOS4DvtQXTT6Fc3jWKQ9pRykc4INsn4LJj6SXJ7+RuazCNpwzwv0TH5zWky4SorC0XKuz1AhQRAvZc+qK1tlW8laEJSbQtoxbY7LG5SDG+ylO7r2wd9H7DB/UuQM5oilRrgnO37wcwUW+JJtRwOous2BuZ458O713di8vzRNLFKlGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YHRbx2DHvJKPynYVFj2rA6aTJGXJ6x1wk/4nZcNAOWs=; b=v5pdxsfxDh4jFKCR83Mb9D2kgdPstzU1CJv82AszWM4xeV+s16tJKCBH9z3ZOdMJqGMUGF9AVXmLUEdhiNfZ5UFfLkKIdyuyITHS9Q839xeDtNTgfXH+F6kHhWRHKh8iLo5JgnxPfLQMN/FfRGWO6SRPN5BzIbx8AeKBkpTqcCU= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN9PR11MB5499.namprd11.prod.outlook.com (2603:10b6:408:104::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Sat, 18 Sep 2021 03:19:48 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7%3]) with mapi id 15.20.4523.018; Sat, 18 Sep 2021 03:19:48 +0000 From: "Wang, Haiyue" To: wangyunjian , "dev@dpdk.org" CC: "Xing, Beilei" , "Yang, Qiming" , "Zhang, Qi Z" , dingxiaoxiong Thread-Topic: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing queues Thread-Index: AQHXq7a08hloAo4rikiLPJx2HfUMYquoXmpwgAC/sICAAAIqYA== Date: Sat, 18 Sep 2021 03:19:47 +0000 Message-ID: References: <139f3a39507570ba56d9220ff2844e7bd875f60d.1631877273.git.wangyunjian@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3bd238fb-d4f1-42cc-0e4e-08d97a532b83 x-ms-traffictypediagnostic: BN9PR11MB5499: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:595; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3h5dIao4h7dEWP7rOhvUNWEYisDr6hXCACmdR1jdcbMmVgM/k+JUTcWK0ReyEL5JyYdCbVhR4qJYJprLfGsxSacAmJbUPy4vrlUUwNSvVbenNGg0aTlErH1cxmyaHgPwtwKgYUpnjE8qRMXrUWssxsMwBldc6hwiHAObZOFe6jsHK45szOqmLuszAnibHI5hAcudSAbY3aNIoUaRgsOYtDt8+hmkdIQlzUySieH28Uq6XEjoaOSloTo+4WckYjgN9HosAbpNBgIi+eVXbrH0OWS/9oSff76swMHU1IvvaHFh1SO/TINHva3xlmmYs942wg5jEYclnqXnHi93jMNaYZztReNytPSWGK7Y8IecntLVkrOCzgQacMYwUYBBQOZ98CLfUo/IftbycZ12Rqpy+CRAlGZZQqvGm7pFx6VHfR3Nyqttu4YrVY1o0i237MGoz1rMAJyak8aR9HGXhOfUQ1KU1ntX/Ug8erDCNkm0vmnymkMYTOTk5b34H45+Oo/SYiquDKYNo0QHjowrB1JPU7PQt9GgWO/4HNKwGCRfYXGKNeOIcDAe5HY1K5QgDkBAH2BxoU+5DfVj6F77V1Rroism7qDNaUiqnUKRov/guzUztY9Z/m6Ohmq1B1Y2jEwJbpkKnKNWTuB19cI9WPmg7UfPGGUnQ6obAsrB4rfea/xPJwncuoS3JRuG0FkixOef9Uu1wAA5lio5upClVzVbHg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(39860400002)(396003)(136003)(366004)(66946007)(66556008)(66476007)(64756008)(66446008)(110136005)(7696005)(53546011)(55016002)(33656002)(76116006)(316002)(478600001)(5660300002)(9686003)(54906003)(38070700005)(83380400001)(8936002)(8676002)(4326008)(122000001)(52536014)(186003)(86362001)(6506007)(38100700002)(2906002)(26005)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ISo+Z//AFAELYY+vIvXhLInZlG85ARUxaZ3V3A/G8aB+4/oujYd3AalgAJdv?= =?us-ascii?Q?Me+rL+bBWqQJQ1gM3Qrm5zHVPNyvNnrY+XOPhMT5R3DbwYDUkw3qNfnr7WiT?= =?us-ascii?Q?FzmjuQ2BI3p7kz65UsKF+1/A2X3AVi0OArXZf1l/DT8CcwwYCR8EXTOFMpmp?= =?us-ascii?Q?GjFXUJj8DV6trAPrrbx1yhTKotl5MQmRm1LNXS2wyQOwytTPDPPiSm8E2R1j?= =?us-ascii?Q?fD9mxIA69+rkFou6anlSOTngoSsvSLfbKZACIcm3XLP32o6yoD/0XZ+i/70J?= =?us-ascii?Q?YL05C2UF0Qjg3rVobWvGnpWsYkyq1Of6xcBb5nPrR6sJaIGMo7pZj56WtY/x?= =?us-ascii?Q?OSzMZPeXkkicqsQiVtXhZ4nxX8TlAHP2XazbgXE47a8rRX9+1AlFmtJCyl1o?= =?us-ascii?Q?0m/5TnA1kVBafpkbrtaWbzCd23RtZCp83ZauYdA4SxjN2uG+VdqSlv4KNamt?= =?us-ascii?Q?rNNqz+J3b5Wi9vGpGQP+rc+whG6Jl/JsK7XEmVNiXr3JeosuW94yumpImopR?= =?us-ascii?Q?F+B63SoqlqGlPoW6RMBausyRMjRCnaqTZMNyy6wv4d94fQRJCcCvlBGQPSvw?= =?us-ascii?Q?k8xSoSpmhSZ7eIZfI8NrCXNprgYWO47uCFapdH9FhfWibBw+cbOIIcN0OWDg?= =?us-ascii?Q?xo4HH2+R+4qWomYfN7f/Q7oKYvdqa4eqd7wC+c4woVzEyIXhE+Dc8J5yswPJ?= =?us-ascii?Q?M5Tv6FfXBsgGjk1Aycb2h7Ajc/b6kNJJuIr6dIvyi+2NnelXTVUslN30SM2S?= =?us-ascii?Q?CihxjaeyszrnohD2M6uFf/j43CX93hGsaJRdVbSZgQW9jO7jZZ4k0H21jNUz?= =?us-ascii?Q?6ZEZNeBuc3UkVCW+7bplloBV8aZV2Sbj/2YMYC45EDVvHCHuDncbcOGHO28C?= =?us-ascii?Q?Ca53lIAEOfgPQnQU0Af07beIFCEYg0vDhl5dMf8JnCyZqE0VW/4aCEcannze?= =?us-ascii?Q?wL+i5eE8q3jlV13bqa/J8CHLamJxQktlK3e+0hPwsdcNJwwS3ewpRGuPws/F?= =?us-ascii?Q?NIgFiDdFFqhzPAjuX1YZbmnQIBPIv89+H9zh7WSl1CehNn9lS8x0Z1wu3aat?= =?us-ascii?Q?LiIdHBj1vAOEWn5j7i/NFF+/7g79y4MSaSYxuV+7w1tbSNjIOnez1jijSC1c?= =?us-ascii?Q?NRwMQy6vNeKej1u1mFWvdZsqm7La+ooQki1GETjaWstFgheHMNUwSaLb4pO/?= =?us-ascii?Q?3uD413eqHaIwKRsb4Pgx1t4O6uiiUh2xL6qRrLAKDkLZi41wNeZfrZwrSBgP?= =?us-ascii?Q?f9v6HQVabB2Xb1da06QJNd/mSBjzYrFh9JzXiLHvA9ZxcA9X87lZjJwZngSb?= =?us-ascii?Q?hgE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bd238fb-d4f1-42cc-0e4e-08d97a532b83 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2021 03:19:47.6321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4W9KKR3nnpufFNfMxBVhlTfp0owJDzXggzt3i5e+lW+IXhVhTnM2lA0Rww6j+GvKSzgqG3l/FC1AFVHSQxes4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5499 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: wangyunjian > Sent: Saturday, September 18, 2021 11:11 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming ; Zhang, Qi Z > ; dingxiaoxiong > Subject: RE: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when relea= sing queues >=20 > > -----Original Message----- > > From: Wang, Haiyue [mailto:haiyue.wang@intel.com] > > Sent: Friday, September 17, 2021 11:47 PM > > To: wangyunjian ; dev@dpdk.org > > Cc: Xing, Beilei ; Yang, Qiming > > ; Zhang, Qi Z ; dingxiaoxi= ong > > > > Subject: RE: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when rel= easing > > queues > > > > > -----Original Message----- > > > From: Yunjian Wang > > > Sent: Friday, September 17, 2021 19:25 > > > To: dev@dpdk.org > > > Cc: Wang, Haiyue ; Xing, Beilei > > > ; Yang, Qiming ; Zhang, > > > Qi Z ; dingxiaoxiong@huawei.com; Yunjian Wang > > > > > > Subject: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when > > > releasing queues > > > > > > Normally when closing the device the queue memzone should be freed. > > > But the memzone will be not freed, when device setup ops like: > > > - rte_eth_bond_slave_remove > > > - rte_eth_dev_internal_reset > > > - eth_dev_rx_queue_config > > > - dev_rx_queue_release > > > - dev_close > > > - dev_free_queues > > > > > > > What's these ops ? function call flow ? And where these names from ? >=20 > The above is simplified, and the original is: > rte_eth_bond_slave_remove > -->__eth_bond_slave_remove_lock_free > ---->slave_remove > ------> rte_eth_dev_internal_reset > --------> rte_eth_dev_rx_queue_config > ----------> eth_dev_rx_queue_config > ------------>i40e_dev_rx_queue_release > rte_eth_dev_close > -->i40e_dev_close > ---->i40e_dev_free_queues > ------>i40e_dev_rx_queue_release(not been called due to nb_rx_queues and = nb_tx_queues are 0) >=20 Yeah, this is better. The patch LGTM, and make sense. Please update it as new commit message. Thanks! > > > > > In order to free the memzone, we can release the memzone > > > when releasing queues. > > > > > > Signed-off-by: Yunjian Wang > > > --- > > > > > > > -- > > > 2.23.0