From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24717C433EF for ; Wed, 22 Sep 2021 13:51:46 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id AF485610A1 for ; Wed, 22 Sep 2021 13:51:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AF485610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80BC7411F6; Wed, 22 Sep 2021 15:51:42 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id F2C8B411A8; Wed, 22 Sep 2021 15:51:39 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="223638287" X-IronPort-AV: E=Sophos;i="5.85,314,1624345200"; d="scan'208";a="223638287" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2021 06:51:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,314,1624345200"; d="scan'208";a="653272994" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 22 Sep 2021 06:51:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 06:51:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 22 Sep 2021 06:51:23 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 22 Sep 2021 06:51:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S3MPpsuZ3I5ziEfBIInECSxaK2EpxAl4tg295daitDOPVWhnNLCSMNG4BqgYmbsh72DaJ1fCm2BOGgkp+WETyHDp85ieYbynYIfq2cKOL9nWx6I2nVWp9+pUhmfrTMbszMRzunSFwv3FY/qOTZZEF+qqtw3dkTWnempIluHh97+n7h8/fmswvQx3uv6dQin2ZV6yxKVgQdQofB4Az0QBIYp771FBAD9r7ibNGMrTvj4R9lT78R+SxbcwubHz23WX4ZXDdVN6n9oh967LmNZbzwhGarqgpKjbZVuNr8xHIhc3S9yWkYekV/b9v7qTSkTXNphw8u2uH4JUHZg64Hv4EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KZI/0Zuo3W+wGH9wI/acX4VfOJUeHXg7s5OYt3gePgQ=; b=cgFcIeqmgxH2aHhFfsFxX4x/rMj1k5WArIlbyaj4z9M6Zf6mffV7L6aHvpYD5EOoYFp80SY1W3OrdMbUoBmyt21KdRI1/EaC5OavFQIr762F+ySgTyby9opg7Mjz449bT4eTNpgs78sEU2LEqcttYG2yTsZz5MKMvAmHaH1ji86R6r3/95DoRlMr54dZE4OUZ7L3u11pd2RWriMTgpf/FkGiZyV896BS4Y0Ke/eA8qJgILVXIKBeAl/ergOEMiEq7jFgUtz5L6bY9DJ59Xpp7SKeF+AQ+sAEMNZf9PZAWTUqZphoMs3vC00qNrnh7iUU+cO0qn0NDzXwjZccJGDJyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KZI/0Zuo3W+wGH9wI/acX4VfOJUeHXg7s5OYt3gePgQ=; b=EdX8kYjzDRdNEZjJZ5RKeSg7LFggJoFrTituXzrRX1GvTVvb8logNXd/hcq7xC0Unf5lxkoO2n/pySReJm4pyvcxXE9YekuFzKQ2k4VreBk6jqsRPyoQlrEksnhJqeeVxlBmpc5hZzY8++ay7EZmSAnqm5nzNYBSNPRLMb04Nwg= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN0PR11MB5743.namprd11.prod.outlook.com (2603:10b6:408:165::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Wed, 22 Sep 2021 13:51:21 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7%3]) with mapi id 15.20.4544.014; Wed, 22 Sep 2021 13:51:21 +0000 From: "Wang, Haiyue" To: Yunjian Wang , "dev@dpdk.org" CC: "Xing, Beilei" , "Yang, Qiming" , "Zhang, Qi Z" , "dingxiaoxiong@huawei.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 2/4] net/ice: fix memzone leak when re-configure the RX/TX queues Thread-Index: AQHXr7XKu0Q/TAkN9UihN2OOsXFVnquwEWkQ Date: Wed, 22 Sep 2021 13:51:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a347b1e4-90e5-44c8-f52a-08d97dd00f71 x-ms-traffictypediagnostic: BN0PR11MB5743: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:989; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /cL1mV0Jiq6niSBuLonopzPXHbARInWh/EkTQvmPuGs71RqJui0BsMboxcCqukVYo6W/EZR+AtJJN7QWJQD/FKmGAIP+CapfF7OwdPAXfNpz17q5bQ1c1dc+idUnitHcLMMODSGjVpXtBivkb8lin1OkcCfVGrSWmqiHdf2BsvvIu/DdZEcYUKdxrtogTs7e4rm2iohkRaaU041YIEzi6YBZGI9qM2ZGqfeOtfGxEfeQTzG3LvDBz+Rih6dSEbX6WBgLje8wcvqT+n8w21ejfnqv+3l+zoF8SwkSyQEuyYjLo9nv3fMgIOvLrh/AHCJgJRpOODGL9ZR6P2jrrRTrvluoTv7hytaSbYh+oljzygC917iyiwtG8Oy8UzuKXdzJAZmc49v3Tzwo+epH5mYjyzTp+28aY/1vKyDPWcDBP5qcNzstxACLIb8HJV/msXoGWYzVWOE/OmdzUbf/ZCYVVJnBjyoCBvQgMeVArCkl2s7Tvg4GAdyWhdPY+0UudC+UkhmbJGldn74EvQFCxfoGRqb2FwFsuGnNd7YDUa2dGw9Vp3yzPSXp9CQxVXvQrCpfaj822BoiwiISM1CXs0KqA56t2qt4L3UNhP6fhsXJqFtNXwqM2Jlm/ejoyKRntm6TXJ4l0Gcv+nx0Bd6E5tMIv75z4MjrUmx+yrasoeITilB73fa+q2U9mD6xotpjr1Zyi4xnhyV2gxF213sOHd1IWg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(9686003)(86362001)(508600001)(8936002)(52536014)(38100700002)(66446008)(66556008)(55016002)(66476007)(76116006)(4326008)(2906002)(33656002)(64756008)(71200400001)(8676002)(38070700005)(316002)(53546011)(110136005)(6506007)(186003)(7696005)(26005)(54906003)(66946007)(5660300002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bS5Gt0fymOf70zLdvUc6V/X7BwgnD9M1HR4LBLjJ9UFGau5wQkRHHy0eLwDc?= =?us-ascii?Q?GG3uemE+feFtOX53I3NS4QSnEaN0Lq8j3ILBm7bnRXZ4H0AYjWRD6+QMh2D1?= =?us-ascii?Q?5pj1VIrCrDppt00tm9DWeobLY/Hde9Bbgij6sYh1gN4wGTcG6XQ1dA+vPOcI?= =?us-ascii?Q?Db7zcfOVjg01wMQmNWq8chmUsQLYdya3B9ayyvetX/2ecJa0aJb3q9sWeWSs?= =?us-ascii?Q?GqlSOz39FnEeAzKYwxoOrjkfBhmCoYFivF8e/pkwFUKnUWGP5LvQ3qvQ+Jfb?= =?us-ascii?Q?NdQvGKlGhDiWCZvoedaLWjEnAnUkARP+ZJz36VRCPaTByeLP7OBIsygtErW6?= =?us-ascii?Q?KJP3liBrC05QMCJmiyWcrrSb1GUJ8L9Da+PYZoHVOhD63iMvHRTtbFSjgwH6?= =?us-ascii?Q?22BMwbKG9hrzyfPw42Po/nBUMCf8KewMkwK+r0wxvx24H/MSsWWLutBCK4wy?= =?us-ascii?Q?9BeRewFzkt76nVE43XGJALjikhmlg4ca6ygneIX8vQPhejbk5JNOg4BpFpfN?= =?us-ascii?Q?DdH1eMZV7//0pvl+mX/WsJrqbxGSb0a1m/UcEzQM+VKU5Wtd7Kh7uCvtQEWt?= =?us-ascii?Q?poWo+WYSGGwSpTwVWGZhP4LZN6n1F4kNOeJI0I7bf1YFlElG6p9wgllCZTAy?= =?us-ascii?Q?CI03BnAdO1KYQftLGMYhFD0gyLg3a2T+sd73lLxXLsL6U09dhKwrCAMkcdmL?= =?us-ascii?Q?LV66B985B0MpK5spET/lOHtBEkqSqPyzuJm0KQ5j6BNGpf92plTq1u4PpSgf?= =?us-ascii?Q?JgJIyI9UYRwsRmZ2MALiaFqBr5nqTIPThM1lPNsn3zlob0wKmk7+sKn2ZMIL?= =?us-ascii?Q?WkPyEtJh0Bj4K/uiZ+ThMK7wDhjux+rjnOHcekOO4O88cwnvtUfeZdGoe0Ii?= =?us-ascii?Q?1RwPpLWpaG1CNHH1UgGuul+U+ifBdePS8ILgWdQgWUOLhIYTFXIK7ry6FPhf?= =?us-ascii?Q?ppnjWRPUPmgquo+faCOxmpYLrqteB1bSQmbD8BZ2tlCUBFNB8mx9dqKHbqTq?= =?us-ascii?Q?Ur68YCtR4uQKXsFJp3qG0J1l3iD5P8f5m4XPdzNj2vL5zxtDI4EqpEd1/ZQ+?= =?us-ascii?Q?eVQrmvzjCOSfpcdNe0KyuyXjBrttGV1oCD0scP16Yxh60mE1UPMcwbnfWMf3?= =?us-ascii?Q?P8jMS74wrlc4RplArcOHncvM6HLAt/5fsN4DxYaGMQB68rttdBXFDafAwLBK?= =?us-ascii?Q?uspiV4HvEU7+IllIO8rdjsIcJPgOonUsP24uy02gNhwzTqiFj8ZGf/48+cJY?= =?us-ascii?Q?VhxLLHdMntkrucma6v2WmGYgfBpSs9qMDuxhp4x6YJcOBs9PgJ2IPnukeoEq?= =?us-ascii?Q?flkkbhnzLdWyK4XQa0Q9jmbM?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a347b1e4-90e5-44c8-f52a-08d97dd00f71 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 13:51:21.4152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YLP1I74by7GP8AKlfXSbTPhOykuwx6KqPoGJYKENnbwQwthZK9VdvUwarEqJ0DSlUdBFJuiVPwKm63s/c6Lavg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5743 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/ice: fix memzone leak when re-configure the RX/TX queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yunjian Wang > Sent: Wednesday, September 22, 2021 21:29 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z ; dingxiaoxion= g@huawei.com; Yunjian Wang > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v3 2/4] net/ice: fix memzone leak when re-conf= igure the RX/TX queues >=20 > Normally when closing the device the queue memzone should be > freed. But the memzone will be not freed, when device setup > ops like: >=20 > rte_eth_bond_slave_remove > -->__eth_bond_slave_remove_lock_free > ---->slave_remove > ------>rte_eth_dev_internal_reset > -------->rte_eth_dev_rx_queue_config > ---------->eth_dev_rx_queue_config > ------------>ice_rx_queue_release > rte_eth_dev_close > -->ice_dev_close > ---->ice_free_queues > ------>ice_rx_queue_release > (not been called due to nb_rx_queues and nb_tx_queues are 0) >=20 > And when queue number is changed to small size, the BIG memzone > queue index will be lost. This will lead to a memory leak. So we > should release the memzone when releasing queues. >=20 > Fixes: 460d1679586e ("drivers/net: delete HW rings while freeing queues") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > --- > drivers/net/ice/ice_fdir_filter.c | 2 -- > drivers/net/ice/ice_rxtx.c | 8 ++++++-- > drivers/net/ice/ice_rxtx.h | 2 ++ > 3 files changed, 8 insertions(+), 4 deletions(-) >=20 Acked-by: Haiyue Wang > -- > 2.23.0