From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C842AC04AAF for ; Mon, 20 May 2019 08:09:18 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 4F8ED20656 for ; Mon, 20 May 2019 08:09:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="SEYfMlxy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="NJGhZaZl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F8ED20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A9802BF3; Mon, 20 May 2019 10:09:17 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id D51259E4 for ; Mon, 20 May 2019 10:09:14 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4K84djn006787; Mon, 20 May 2019 01:09:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=bCfaZ7MtjnK2jWMw3GiXRJWdPuQnsWaSIgHTAzTBWHo=; b=SEYfMlxymdsxz5L1mCMaSOzj5I5StO+2qGw+o+W8//cWM66FJRf2impjHKIGJSbattOK TtkkzdaliXocrPjOvIf050f5ZwPc3hsQFzxSb4AoM/J/f23boUoYC/mq5SDuzDRXegOW mOhWj4u5i2+fTtvoAs1y/H0l+gOQa9KfYM4AmZkAhGrVMSHVXbq3yLflzlaHKIyyJUjO /izw+Vonh1oxRQVyM88LKpRdRGuz3NOUYKxmgY9niZ+e5kmzMeJqeMlWoW88fteOVIJW vrUioQGfhe8SGxDc6m46QbQkRBafgNCA4zH4q4x814mOgjpwrjGAXVKg55g48nisrXVA qA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2skr7m828d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 20 May 2019 01:09:13 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 20 May 2019 01:09:12 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.51) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 20 May 2019 01:09:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bCfaZ7MtjnK2jWMw3GiXRJWdPuQnsWaSIgHTAzTBWHo=; b=NJGhZaZlzPkIgGTsz7oUuM3/5a/wJp7A/YA+8DsP+lsDPvDbzdtRoIrg4gFHPHpFgDsVZRt0OmOpHjfs3xYfxO/7RkRG4az6CDy5mSRXxdNej5Ig/CotB4S/OQSCDrMI6YP7rsHqUQVQNyXNIgJ8vz4CISSzzB1gTSs9pZd/BuI= Received: from BN8PR18MB2691.namprd18.prod.outlook.com (20.179.72.94) by BN8PR18MB3076.namprd18.prod.outlook.com (20.179.75.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.17; Mon, 20 May 2019 08:09:11 +0000 Received: from BN8PR18MB2691.namprd18.prod.outlook.com ([fe80::4df6:7ce8:4a1e:9114]) by BN8PR18MB2691.namprd18.prod.outlook.com ([fe80::4df6:7ce8:4a1e:9114%4]) with mapi id 15.20.1900.020; Mon, 20 May 2019 08:09:11 +0000 From: Sunil Kumar Kori To: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf Thread-Index: AQHVDY1R/NEKgT08I06kOPZY8nrZHKZzqkkg Date: Mon, 20 May 2019 08:09:11 +0000 Message-ID: References: <1558005895-30340-1-git-send-email-skori@marvell.com> <1558006933-32247-1-git-send-email-skori@marvell.com> <1558006933-32247-3-git-send-email-skori@marvell.com> <2601191342CEEE43887BDE71AB97725801616357D4@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725801616357D4@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a6aebe72-23ee-41f5-951e-08d6dcfa7118 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BN8PR18MB3076; x-ms-traffictypediagnostic: BN8PR18MB3076: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 004395A01C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39850400004)(136003)(346002)(366004)(396003)(189003)(13464003)(199004)(25786009)(305945005)(2906002)(99286004)(2501003)(7696005)(486006)(11346002)(476003)(446003)(14444005)(316002)(68736007)(76176011)(74316002)(53936002)(256004)(6246003)(66066001)(71200400001)(71190400001)(6436002)(6506007)(55236004)(186003)(53546011)(3846002)(6116002)(26005)(55016002)(5660300002)(229853002)(102836004)(9686003)(66476007)(8936002)(7736002)(14454004)(81156014)(81166006)(76116006)(66446008)(33656002)(86362001)(52536014)(66556008)(73956011)(110136005)(66946007)(64756008)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR18MB3076; H:BN8PR18MB2691.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0/sW/XKwMNXBEiZmreeroZBYzW/PPy/yiT1RAdE+GZWsV+HWZxVP6UxgOtDRnj/uHZIxDPVReCSVRl0mTeVwnv5cldpUju8snsXHBswSiWpifcB5E6dgq61pQESdqUqFbfHOKZGv5b3WHccAiS2bqHnQC0DR5wFUz7XVaCXSjXBt2XXy+/x/p1DFi24G0W6Jp6bHMclavVHKIA35yVHDxoqpfvBP6ZvjIFtYHutJaS1IovoF4AUS4dSUDpoC04SMcMbb7rcxARCb7zMVunbuSPlv6gJgDNUrHqb0DVTWgYCyESFxenZYPepcKX9qI3GaSOoZZsaJOEVLH/0/PW6NQAcU/sVX4LqPWvd4WqeVLQLWNcxK5JyoPWZpBTku9ezpCnqdqKcRCdRxnpmM0mpc46Pn/TC7r4CcEse1+9pA3bY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a6aebe72-23ee-41f5-951e-08d6dcfa7118 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2019 08:09:11.5345 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB3076 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-20_04:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling IP checksum offload in mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Regards Sunil Kumar Kori >-----Original Message----- >From: Ananyev, Konstantin >Sent: Saturday, May 18, 2019 8:51 PM >To: Sunil Kumar Kori ; dev@dpdk.org >Subject: [EXT] RE: [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: >Enabling IP checksum offload in mbuf > >External Email > >---------------------------------------------------------------------- > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sunil Kumar Kori >> Sent: Thursday, May 16, 2019 12:42 PM >> To: dev@dpdk.org >> Cc: skori@marvell.com >> Subject: [dpdk-dev] [PATCH v2 2/3] examples/ip_fragmentation: Enabling I= P >checksum offload in mbuf >> >> As per the documentation to use any IP offload features, application >> must set required offload flags into mbuf->ol_flags. >> >> Signed-off-by: Sunil Kumar Kori >> --- >> examples/ip_fragmentation/main.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/examples/ip_fragmentation/main.c >b/examples/ip_fragmentation/main.c >> index e90a61e..d821967 100644 >> --- a/examples/ip_fragmentation/main.c >> +++ b/examples/ip_fragmentation/main.c >> @@ -354,10 +354,13 @@ struct rte_lpm6_config lpm6_config =3D { >> >> /* src addr */ >> ether_addr_copy(&ports_eth_addr[port_out], ð_hdr- >>s_addr); >> - if (ipv6) >> + if (ipv6) { >> eth_hdr->ether_type =3D >rte_be_to_cpu_16(ETHER_TYPE_IPv6); >> - else >> + m->ol_flags |=3D PKT_TX_IPV6; > >Is there is any point to do that? >This sample app, as I remember doesn't request any extra HW offloads. >Same comment for patch #3. >Konstantin > > Is this comment valid for IPv6 only ? Otherwise for IPv4, it is required as IP checksum is neither being updated = by library nor by the application. >> + } else { >> eth_hdr->ether_type =3D >rte_be_to_cpu_16(ETHER_TYPE_IPv4); >> + m->ol_flags |=3D (PKT_TX_IPV4 | PKT_TX_IP_CKSUM); >> + } >> } >> >> len +=3D len2; >> -- >> 1.8.3.1