RE: [PATCH 03/10] kvm/vfio: Store the struct file in the kvm_vfio_group

From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: Eric Auger <eric.auger@redhat.com>,
	Christoph Hellwig <hch@lst.de>, "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH 03/10] kvm/vfio: Store the struct file in the kvm_vfio_group
Date: Fri, 15 Apr 2022 03:44:56 +0000	[thread overview]
Message-ID: <BN9PR11MB5276A8591FD649A1C42E520A8CEE9@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3-v1-33906a626da1+16b0-vfio_kvm_no_group_jgg@nvidia.com>

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Friday, April 15, 2022 2:46 AM
> 
> Following patches will chage the APIs to use the struct file as the handle

s/chage/change

> @@ -304,10 +309,10 @@ static int kvm_vfio_group_set_spapr_tce(struct
> kvm_device *dev,
>  		return -EBADF;
> 
>  	vfio_group = kvm_vfio_group_get_external_user(f.file);
> -	fdput(f);
> -
> -	if (IS_ERR(vfio_group))
> -		return PTR_ERR(vfio_group);
> +	if (IS_ERR(vfio_group)) {
> +		ret = PTR_ERR(vfio_group);
> +		goto err_fdput;
> +	}
> 
>  	grp = kvm_vfio_group_get_iommu_group(vfio_group);
>  	if (WARN_ON_ONCE(!grp)) {

move above two external calls into below loop after file is
matched...

> @@ -320,7 +325,7 @@ static int kvm_vfio_group_set_spapr_tce(struct
> kvm_device *dev,
>  	mutex_lock(&kv->lock);
> 
>  	list_for_each_entry(kvg, &kv->group_list, node) {
> -		if (kvg->vfio_group != vfio_group)
> +		if (kvg->filp != f.file)
>  			continue;
> 

... here. Though they will be removed in later patch doing so at
this patch is slightly more reasonable.

otherwise,

Reviewed-by: Kevin Tian <kevin.tian@intel.com>