All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ding, Xuan" <xuan.ding@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] doc: fix vhost multi-queue reconnection
Date: Tue, 29 Mar 2022 13:15:26 +0000	[thread overview]
Message-ID: <BN9PR11MB551349CB2208A3C420B237A1E71E9@BN9PR11MB5513.namprd11.prod.outlook.com> (raw)
In-Reply-To: <475b6a00-ec0a-12a9-d8e6-ac1c1eb68675@redhat.com>

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, March 29, 2022 8:47 PM
> To: Ding, Xuan <xuan.ding@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH v2] doc: fix vhost multi-queue reconnection
> 
> 
> 
> On 2/24/22 07:28, xuan.ding@intel.com wrote:
> > From: Xuan Ding <xuan.ding@intel.com>
> >
> > Since QEMU 5.2.0 fixes the vhost multi-queue reconnection issue in
> > commit f66337bdbfda ("vhost-user: save features of multiqueues if
> > chardev is closed"), this patch removes the previous description from
> > known issue.
> >
> > Fixes: b37e95507e1b ("doc: add vhost multi-queue reconnection issue")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> > ---
> > v2:
> > * Add fixes in commit title and log.
> > ---
> >   doc/guides/rel_notes/known_issues.rst | 21 ---------------------
> >   1 file changed, 21 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/known_issues.rst
> > b/doc/guides/rel_notes/known_issues.rst
> > index 187d9c942e..a8d1401a71 100644
> > --- a/doc/guides/rel_notes/known_issues.rst
> > +++ b/doc/guides/rel_notes/known_issues.rst
> > @@ -884,24 +884,3 @@ Unsuitable IOVA mode may be picked as the
> default
> >
> >   **Driver/Module**:
> >      ALL.
> > -
> > -Vhost multi-queue reconnection failed with QEMU version >= 4.2.0
> > -----------------------------------------------------------------
> > -
> > -**Description**
> > -   It's a QEMU regression bug (bad commit: c6beefd674ff). QEMU only
> saves
> > -   acked features for one vhost-net when vhost quits. When vhost
> reconnects
> > -   to virtio-net/virtio-pmd in multi-queue situations, the features been
> > -   set multiple times are not consistent.
> > -
> > -**Implication**
> > -   Vhost cannot reconnect back to virtio-net/virtio-pmd normally.
> > -
> > -**Resolution/Workaround**:
> > -   It is possible to filter the incorrect acked features at vhost-user side.
> > -
> > -**Affected Environment/Platform**:
> > -   ALL.
> > -
> > -**Driver/Module**:
> > -   Virtual Device Poll Mode Driver (PMD).
> 
> Instead of removing this information, I would rather update it to indicate the
> range of affected QEMU versions.
> 
> What do you think?

That's a good idea, so that users can know which versions are affected.
I will update it in next version.

Thanks,
Xuan

> 
> Thanks,
> Maxime


  reply	other threads:[~2022-03-29 13:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21  7:27 [PATCH] doc: remove multi-queue reconnection known issue xuan.ding
2022-02-24  6:28 ` [PATCH v2] doc: fix vhost multi-queue reconnection xuan.ding
2022-03-29 12:46   ` Maxime Coquelin
2022-03-29 13:15     ` Ding, Xuan [this message]
2022-04-15  2:08 ` [PATCH v3] " xuan.ding
2022-05-06  8:40   ` Xia, Chenbo
2022-05-09  3:07     ` Ding, Xuan
2022-05-09  4:11 ` [PATCH v4] " xuan.ding
2022-05-16 12:44   ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB551349CB2208A3C420B237A1E71E9@BN9PR11MB5513.namprd11.prod.outlook.com \
    --to=xuan.ding@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.