From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C066C43334 for ; Thu, 14 Jul 2022 12:54:46 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 571C342B73; Thu, 14 Jul 2022 14:54:45 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id F24BE42B6D for ; Thu, 14 Jul 2022 14:54:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657803283; x=1689339283; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6VvIh0RB1ta3sV65LUA74cRvDP7IwIAp6lWMtUvhnpQ=; b=mZcEvgDOVCSUQ6yA0d01MT5sx2fBODnkdPb2t64KdEnkFiaewOK/3wdW BYH8kpfCZATYQlMsGEFQybyRbFJz+101XkzRVeZe33lTTggu72KTVcx49 CScjXn3sD1xG4J6D1IAwFNYYrTD+4LLUTEXqRjomVfNx/D5GgzqtBfl9T cLhdlgSvG8k1RRTz3sdH1mqRRK04MB6OKc3Fc10vybAjqszOceJG3N06+ jrqhla9tWbx1VlaoRPRJQa78soqEih8CEaAHXEt5VYT9BtKi8TQlBFwTg WVoz0YX/OsQxDKvawEe7QtvuwGC0bBQ/Q3ccCLdw0CQgqGFgpCGidzvSu g==; X-IronPort-AV: E=McAfee;i="6400,9594,10407"; a="265290430" X-IronPort-AV: E=Sophos;i="5.92,271,1650956400"; d="scan'208";a="265290430" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2022 05:54:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,271,1650956400"; d="scan'208";a="722711175" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 14 Jul 2022 05:54:34 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 14 Jul 2022 05:54:33 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 14 Jul 2022 05:54:33 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 14 Jul 2022 05:54:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k0cfl4KbztxPI6ekuNU4Nk6NJQF0pHt2DHT/mWKw6l7rU0dWW0txPT1n+YKBRJBCZxw/KnyuQMTDDgCNBIbUVoU39dJI64joQaabCRvDcnxA8eC8fW1WkqQEfYC7J3SshPMAFIjCbuM2h1kwU7S2tb8FKQcGy+aviOmULpfPvDyx/324oiQH0PWechqSGNwNLJsdA3VbwpAOyqwuJq5sh1+F0XYOfmIry+hXYAz+cAZ0vZ8hdOuyv2AjU/zfB4MIPU7PqGH0zDAtf59wqfA84DD3cZM/I/tQSDkgBNfil5a6zYAzfo6051SLyAE+TSmucBjHISuQdMCAjzo7KS8M5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=salo/q7P270ph6piQ8Na7UtFifJrIrY/rtzLD7/SHrs=; b=eRF9IX5lcQhu/v4P6HFb0JJEBp0RP/64VWQAhrFEAbgB41EBen1Zpfjxjs9TbJELcUld8e8a20TZEB7VUffQYEX77rNPjZwudQ0W3wYJnuFaov2KULLF96AXP5Rvw+VndCd5QIlIL3Ui18BxZPHfQ6wyNOXMxyWHBjpgfKBoffT5UR6GqbY/yXJmWiDSq07RMln9OgRbqaTwJJ6eVBc3eXrfLoMESFyNIOGpIOHHwoAquTy6EYXJKI8x0KdWzGi0lQ8Zm/UNOYfLmV+lWpa+GdtSFuMQAt4sxRqdwvyYN9xtDlEKy5IZtpGrC0GI68+TVV0IaEPT7ZJL3qaWyJyJEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5513.namprd11.prod.outlook.com (2603:10b6:408:102::11) by MN2PR11MB3680.namprd11.prod.outlook.com (2603:10b6:208:f3::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 12:54:29 +0000 Received: from BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::e0da:195a:2906:2c2]) by BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::e0da:195a:2906:2c2%9]) with mapi id 15.20.5438.013; Thu, 14 Jul 2022 12:54:29 +0000 From: "Ding, Xuan" To: Thomas Monjalon CC: "andrew.rybchenko@oktetlabs.ru" , "mdr@ashroe.eu" , "dev@dpdk.org" , "stephen@networkplumber.org" , "mb@smartsharesystems.com" , "dev@dpdk.org" , "Zhang, Qi Z" , "asekhar@marvell.com" , "pbhagavatula@marvell.com" , "ferruh.yigit@xilinx.com" , "grive@u256.net" Subject: RE: [PATCH] doc: announce header split deprecation Thread-Topic: [PATCH] doc: announce header split deprecation Thread-Index: AQHYbrEPAF9vEYkQVkaCTd0XF6IG4K18XmiAgAFEOOCAADHmAIAASG0w Date: Thu, 14 Jul 2022 12:54:29 +0000 Message-ID: References: <20220523142016.44451-1-xuan.ding@intel.com> <11233520.IZOipudI63@thomas> <6226385.mzcYPaeBD7@thomas> In-Reply-To: <6226385.mzcYPaeBD7@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fed4bbab-036e-4f38-6c88-08da6597fda9 x-ms-traffictypediagnostic: MN2PR11MB3680:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7e/DRUVszDgMOtMf+WDlxcobCFpUQN+t+6n3cDwpwdkysnpYa6K8QSY2OgZI9Pp2LM47MpyuQkg4Qm2teYypD7mIID0VPAhW3ZX5fgksaNf5lLYLk6D2wqvs4cYKWCW5wR1rEbsyXx6dqqJE5pe0FoPbp7y30PSoUOoNfvTmUm3LwIysKI2xtaik2LiqCcoYgEoHljuoh7LGpIkEO+4QcWWS7b2R403n95NgbCSgWFaomFcDFiLhjSb/Lo7/SVqsjgEvu/emY4D5XztoI3s4U5wGn6Te/5p+FON4Wak2/LraTnc7fvK2fbC0ie6+6v7q4vfSaDTa/sQlxfkGqeCTcpbFvhs2aKVdoNabnguh1ZzFZYZmHKZGfR4vRAodm7gLVsDb26F7H/cxY2SSuYm/LnnTuJJpR6iWqCw5Aluuo9iv9zA1fmuL/DaBCH0/2g3ES//sidfwB4R4SwIeB2RLWJrkYCZ2mi3wrYVl+/WWUrGuveayY2iSwxvnv+J9WFecjHitYnoZac8ksVhZj63fo4BpzVLZzjUJ5ADfVmoW7k8O8puKDn90kk2YzvyuqScQvV6QF7cp3Mwg0KljKW0pQMmKkF5tMUvAwz6OdSBfgo0e5i9UewVcK4m9d2EmllZYQ6Fw7sLQM1mc2vDi7557T2PIJdIdYurYT1t6W1jbJktx3LUevKqwWM4HD1awGyqj8INui8j3gEz3jMW8DH2Xi1MLu5lEerh+cdbVapSSfpSp0CvwqQLWk6MCQ67SPz40/QZP3UIUWm+u3yJ7F5x6iLD0XNqHHwKYgMoXcm5H161d4dmOcIfS82lmOWx/GKoczhoCerb5xGZBqUI9FBEPuHip+iBZcWtZ6DnDNrMrN7A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5513.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(376002)(346002)(136003)(396003)(39860400002)(71200400001)(316002)(54906003)(6916009)(186003)(86362001)(83380400001)(966005)(41300700001)(55016003)(478600001)(9686003)(26005)(7696005)(53546011)(6506007)(82960400001)(2906002)(8936002)(5660300002)(7416002)(38070700005)(122000001)(38100700002)(52536014)(76116006)(66476007)(66446008)(66946007)(64756008)(66556008)(8676002)(33656002)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wXfWAlfWXbtDEIOyCgVl3fO5aJMQaeoiP3dZbffm7A9QTdGKlCXSfTV7gW8O?= =?us-ascii?Q?30bFUYEsBM3zVUo7pvAc2/va/BB2nN+IH0dGAfgzn4D+sTfuwDgFrZXBypoo?= =?us-ascii?Q?n0yqM3VlRPZ1yJXiM6lf2Cql5BWfwvD1cDktI+/cv9uBT68cdP3Rr311GWxK?= =?us-ascii?Q?cBUpwwgoPgNQ9X7iD8Hefgu4oYTpi7Y2l8J2wI5ABSjDFufnLswbI64Zf2t9?= =?us-ascii?Q?G5TBCf8CFTnusr8d3ElydasxP2p9sgTKJ1jbxK+7FlUi8unfYEKRk3PI/JhS?= =?us-ascii?Q?WdIemYarOF2ROBFZ/vS5JCbmVoVXl3kMUGFbFplMSttJEYSL82oo9wK8hEf5?= =?us-ascii?Q?z0YAmZ3+SdQnGdsdm0vDPYjqrwfUfKNEe8QPU4fukORWIYfLcGLKvwquTbO7?= =?us-ascii?Q?48EZft47HR44YFnZcbp+PN/s641GpSqUWr/sE3yFIIZypx0MFQbRVqQx1kYS?= =?us-ascii?Q?xares0xuyC3eAZKpYs6hAsLCyef2z49YQf0F2lZq2jss4TpDbmiughiHPhV7?= =?us-ascii?Q?YPQMZZW834r+tovNcEyxzu/EZUKMrQthzxhHJxe+gfk2VGljRhbHez8RtOQZ?= =?us-ascii?Q?v1EkAd6qa8vhqH0h+QVdoxgh+bPhPIHfC5SF9EWgvhmkebrnLsuGh030orrR?= =?us-ascii?Q?1mgDc9cNDhEV3IXlScOku5eEIRP5OGHseI4XE7wJcbZuaWb5fYy0XfWxro0P?= =?us-ascii?Q?FWpw0/KPg772UO7I5ndLSNaLIPYpbJ4PtLuKQQcYkyyR60vBrvV2dPO7eikv?= =?us-ascii?Q?hMkmZvHyRAr9yEhMuvC9kHDE4d8ktPLh+rL8B/IgaYHoNv76dQXklzyhRHaH?= =?us-ascii?Q?J2YSiBDrl1ixoca9u110jfJ8kYMbDdz8vlbNr+kKLQ1lIU+gkpLHaAE2NXpQ?= =?us-ascii?Q?RoSr7ydjGRsoDjfuYhJfJ85S4s+JLKzZSGT33VGrYXj+sQX+kexmfFXjIiPR?= =?us-ascii?Q?OwHHIXlJOHDsU9vAfxzg8rzsTEzPXcGHoGJpdFwrOva5h5pIeUu2kuJOsRou?= =?us-ascii?Q?QIxogjGvwNYTqxs2vUdEsgC90I2I96HCdZPjBmp27GZNfGaVQRA9M+XYWEZ5?= =?us-ascii?Q?LBB8cAM8odWnp2GvCu+l3O/foDRecyKy/lPI7+JnH8szaRj5fDtPK/uMATM9?= =?us-ascii?Q?iveKvyFwz95INZSUPWa+WF5EsZzqQUElhbwPUPbMVWaH9izBFQqq2ZH7YdIC?= =?us-ascii?Q?1O4ZV6P89pUxROOPk95a3crRn6mZ7wtj3h/87FxkhNiJO3W8GdRz+T77X4F/?= =?us-ascii?Q?xGJxoP+25S0DYMJmHLASJb2ycHMzY7GatQkpnSg6dCt78QzrdPftNmX1VzSy?= =?us-ascii?Q?zB4oJgfDYHDDQJM7hrXN7Of3LV3MXvxw5p6Q80vrhkSNw9iQYhe20ehM1Q9U?= =?us-ascii?Q?nfo/AJCxaAp+zUF1h2h6XCw8r7VQz+g7xkztbURoKoG939Srkfd0LoSQ/KRq?= =?us-ascii?Q?FCWJy3g+mPmJJ1/aipRGwqvV44gYGpfnkg+wZ777mCIBOlq8Op5/eB+cKiLR?= =?us-ascii?Q?50k0//buKKhb57K4pse43DAPO7p7wJoh1G9hhk95JjxGj4cv4IkDppKxN0ne?= =?us-ascii?Q?LvUTuJ9pGkZ9vd8T0ZqeYg3sYNUTWHDKHTZqGay5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5513.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fed4bbab-036e-4f38-6c88-08da6597fda9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 12:54:29.5913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mI9yM81CNu2pIPCmtb+S+AxvMHFlfN3hnBv/yZc7mYUDuBiTgJZDzQ6+zX8zGcmMidl2Dmyrpw+HKpvJS8Vk3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3680 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, July 14, 2022 4:09 PM > To: Ding, Xuan > Cc: andrew.rybchenko@oktetlabs.ru; mdr@ashroe.eu; dev@dpdk.org; > stephen@networkplumber.org; mb@smartsharesystems.com; > dev@dpdk.org; Zhang, Qi Z ; asekhar@marvell.com; > pbhagavatula@marvell.com; ferruh.yigit@xilinx.com; grive@u256.net > Subject: Re: [PATCH] doc: announce header split deprecation >=20 > 14/07/2022 07:50, Ding, Xuan: > > From: Thomas Monjalon > > > 23/05/2022 16:20, xuan.ding@intel.com: > > > > From: Xuan Ding > > > > > > > > RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced some > time > > > ago > > > > to substitute bit-field header_split in struct rte_eth_rxmode. It > > > > allows to enable header split offload with the header size > > > > controlled using split_hdr_size in the same structure. > > > > > > > > Right now, no single PMD actually supports > > > > RTE_ETH_RX_OFFLOAD_HEADER_SPLIT with above definition. Many > > > > examples and test apps initialize the field to 0 explicitly. The > > > > most of drivers simply ignore split_hdr_size since the offload is > > > > not advertised, but > > > some double-check that its value is 0. > > > > > > > > So the RTE_ETH_RX_OFFLOAD_HEADER_SPLIT and split_header_size > field > > > > will be removed in DPDK 22.11. > > > > > > > > Signed-off-by: Xuan Ding > > > > --- > > > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > > > b/doc/guides/rel_notes/deprecation.rst > > > > index 4e5b23c53d..b8114f29ed 100644 > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > @@ -125,3 +125,7 @@ Deprecation Notices > > > > applications should be updated to use the ``dmadev`` library ins= tead, > > > > with the underlying HW-functionality being provided by the ``ioa= t`` or > > > > ``idxd`` dma drivers > > > > + > > > > +* ethdev: After bit-field header split was removed, the > > > > +``RTE_ETH_RX_OFFLOAD_HEADER_SPLIT`` > > > > +offload and the ``split_hdr_size`` field in structure > > > > +``rte_eth_rxmode`` to enable header split offload are not > > > > +supported in any > > > PMDs. They will be removed in DPDK 22.11. > > > > > > It would have been good to talk about rte_eth_rxseg_split which is > > > similar and configured per-queue. > > > > Thanks for your suggestion. > > > > But I'm a little confused, are you referring that I need to involve pro= tocol > based buffer split? > > About the deprecation of header split, I haven't realized its connectio= n to > rte_eth_rxseg_split. >=20 > What??? > In old versions of your patch "ethdev: introduce protocol type based head= er > split" > you wrote: > " > A new proto field is introduced in the > rte_eth_rxseg_split structure reserved field to specify header protocol t= ype. > With Rx offload flag RTE_ETH_RX_OFFLOAD_HEADER_SPLIT enabled and > protocol type configured, PMD will split the ingress packets into two sep= arate > regions. It has a long history...=20 It was corrected in v4 that RTE_ETH_RX_OFFLOAD_HEADER_SPLIT is used to enab= le header split offload with the header size controlled using "split_hdr_size". But no single PMD actually supports RTE_ETH_RX_OFFLOAD_HEADER_SPLIT for thi= s purpose. So we finally decide to deprecate this flag. http://patchwork.dpdk.org/project/dpdk/patch/20220402104109.472078-2-wenxua= nx.wu@intel.com/ In following series, I use RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT instead. It is f= or multi-segments packet split. And it still needs a "proto_hdr" field in rte_eth_rxmode to configur= e split location. > " >=20 > > Currently there are 2 acks, add more PMD maintainers to help review > > this deprecation notice for header split, thanks a lot! >=20 > I cannot say my feeling strong enough. So IMO the deprecation for header split is not relevant with buffer split. = But we can still clean the code. Hope it make things clearer. Thanks, Xuan >=20