All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akhil R <akhilrajeev@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
	"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
	"christian.koenig@amd.com" <christian.koenig@amd.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: Shardar Mohammed <smohammed@nvidia.com>
Subject: RE: [PATCH v2] i2c: tegra: Add ACPI support
Date: Wed, 24 Nov 2021 16:40:16 +0000	[thread overview]
Message-ID: <BN9PR12MB5273CA3AA78636EB0500897AC0619@BN9PR12MB5273.namprd12.prod.outlook.com> (raw)
In-Reply-To: <b06a5072-f0f4-c9f9-f9a2-8d76b4432415@gmail.com>

> 24.11.2021 10:18, Akhil R пишет:
> >> *i2c_dev)
> >>>               i2c_dev->is_vi = true;  }
> >> How are you going to differentiate the VI I2C from a non-VI? This
> >> doesn't look right.
> > This patch adds the ACPI support to only non-VI I2C. The device_ids in
> > match table are added accordingly. I suppose, of_device_is_compatible
> > always returns false as there is no device tree.
> > Agree with the other comments.
> 
> Will the VI I2C have a different ACPI ID or how it's going to work?
As there is a different compatible for VI I2C in device tree, I suppose the ACPI
would have a different ID as well. I think the logic would also need an update 
if to have VI I2C using the ACPI. But that wasn't actually considered in this patch.

Best Regards,
Akhil


  reply	other threads:[~2021-11-24 16:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 13:32 [PATCH] i2c: tegra: Add ACPI support Akhil R
2021-11-19 14:48 ` Andy Shevchenko
2021-11-19 14:48   ` Andy Shevchenko
2021-11-20  7:36   ` Akhil R
2021-11-20  7:36     ` Akhil R
2021-11-22 10:33   ` Dmitry Osipenko
2021-11-22 10:33     ` Dmitry Osipenko
2021-11-22 10:40 ` Dmitry Osipenko
2021-11-23  7:15 ` [PATCH v2] " Akhil R
2021-11-23 14:00   ` kernel test robot
2021-11-23 14:00     ` kernel test robot
2021-11-23 14:22   ` Dmitry Osipenko
2021-11-24  7:18     ` Akhil R
2021-11-24 16:05       ` Dmitry Osipenko
2021-11-24 16:40         ` Akhil R [this message]
2021-11-24 17:29           ` Dmitry Osipenko
2021-11-23 17:04   ` kernel test robot
2021-11-23 17:04     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR12MB5273CA3AA78636EB0500897AC0619@BN9PR12MB5273.namprd12.prod.outlook.com \
    --to=akhilrajeev@nvidia.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=smohammed@nvidia.com \
    --cc=sumit.semwal@linaro.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.