All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Pasternak <vadimp@nvidia.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Kunwu Chan" <chentao@kylinos.cn>,
	"David Thompson" <davthompson@nvidia.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	"jiri@resnulli.us" <jiri@resnulli.us>,
	Shravan Ramani <shravankr@nvidia.com>,
	"kunwu.chan@hotmail.com" <kunwu.chan@hotmail.com>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] platform/mellanox: Add a null pointer check in mlxbf_pmc_create_groups
Date: Thu, 30 Nov 2023 16:01:54 +0000	[thread overview]
Message-ID: <BN9PR12MB5381030454E0A19315002F2DAF82A@BN9PR12MB5381.namprd12.prod.outlook.com> (raw)
In-Reply-To: <55c5987b-c991-aa8-a226-c5b1638b474@linux.intel.com>

Hi Ilpo!

> -----Original Message-----
> From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Sent: Thursday, 30 November 2023 17:26
> To: Kunwu Chan <chentao@kylinos.cn>; Vadim Pasternak
> <vadimp@nvidia.com>
> Cc: Hans de Goede <hdegoede@redhat.com>; jiri@resnulli.us; Shravan
> Ramani <shravankr@nvidia.com>; kunwu.chan@hotmail.com; platform-
> driver-x86@vger.kernel.org; LKML <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] platform/mellanox: Add a null pointer check in
> mlxbf_pmc_create_groups
> 
> Hi Vadim,
> 
> Could you please take a look at this and give advice to Kunwu so we can get all
> of them squashed in one go.

It seems there are six calls devm_kasprintf(), which requires checking pointer.

I guess, it is correct to return '-ENOMEM' for any failure.

I see there is another problem in mlxbf_pmc_probe() - it lacks error flow for:
	pmc->hwmon_dev = devm_hwmon_device_register_with_groups(
		dev, "bfperf", pmc, pmc->groups);
	
Need to add:
	if (IS_ERR(pmc->hwmon_dev))
		return PTR_ERR(pmc->hwmon_dev);

Sharvan, David,
Could you, please, have look?

> 
> On Thu, 30 Nov 2023, Kunwu Chan wrote:
> 
> > Thanks for your reply.
> >
> > Cause i don't know how to deal with in some scenario,such as in
> > 'mlxbf_pmc_init_perftype_counter', when 'attr->dev_attr.attr.name' is
> > null, should return '-ENOMEM' or 'continue' the loop?
> 
> I'd have thought returning -ENOMEM would be safe because it just ends up
> failing probe()? ...And it's not that likely to occur in the first place.
> 
> --
>  i.
> 
> >
> > So I'm going to solve it one by one.
> >
> > Thanks again,
> > Kunwu
> >
> > On 2023/11/28 17:51, Ilpo Järvinen wrote:
> > > On Mon, 27 Nov 2023, Kunwu Chan wrote:
> > >
> > > > devm_kasprintf() returns a pointer to dynamically allocated memory
> > > > which can be NULL upon failure.
> > > >
> > > > Fixes: 1a218d312e65 ("platform/mellanox: mlxbf-pmc: Add Mellanox
> > > > BlueField PMC driver")
> > > > Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> > > > ---
> > > >   drivers/platform/mellanox/mlxbf-pmc.c | 2 ++
> > > >   1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/platform/mellanox/mlxbf-pmc.c
> > > > b/drivers/platform/mellanox/mlxbf-pmc.c
> > > > index 0b427fc24a96..59bbe5e13f6b 100644
> > > > --- a/drivers/platform/mellanox/mlxbf-pmc.c
> > > > +++ b/drivers/platform/mellanox/mlxbf-pmc.c
> > > > @@ -1882,6 +1882,8 @@ static int mlxbf_pmc_create_groups(struct
> > > > device *dev, int blk_num)
> > > >   	pmc->block[blk_num].block_attr_grp.attrs =
> > > > pmc->block[blk_num].block_attr;
> > > >   	pmc->block[blk_num].block_attr_grp.name = devm_kasprintf(
> > > >   		dev, GFP_KERNEL, pmc->block_name[blk_num]);
> > > > +	if (!pmc->block[blk_num].block_attr_grp.name)
> > > > +		return -ENOMEM;
> > > >   	pmc->groups[pmc->group_num] = &pmc-
> >block[blk_num].block_attr_grp;
> > > >   	pmc->group_num++;
> > >
> > > I'm totally lost, why did you fix only one devm_kasprintf() location?
> > > Don't all of them need this check?
> > >
> >

  reply	other threads:[~2023-11-30 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27  6:34 [PATCH] platform/mellanox: Add a null pointer check in mlxbf_pmc_create_groups Kunwu Chan
2023-11-27 12:24 ` Hans de Goede
2023-11-28  9:51 ` Ilpo Järvinen
     [not found] ` <1701224213463629.329.seg@mailgw>
2023-11-30  9:43   ` Kunwu Chan
2023-11-30 15:25     ` Ilpo Järvinen
2023-11-30 16:01       ` Vadim Pasternak [this message]
2023-12-01  3:20         ` Kunwu Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR12MB5381030454E0A19315002F2DAF82A@BN9PR12MB5381.namprd12.prod.outlook.com \
    --to=vadimp@nvidia.com \
    --cc=chentao@kylinos.cn \
    --cc=davthompson@nvidia.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jiri@resnulli.us \
    --cc=kunwu.chan@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=shravankr@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.