From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sharma Bhupesh Subject: RE: [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO mode Date: Thu, 14 May 2015 15:44:19 +0000 Message-ID: References: <1431603215-25546-1-git-send-email-bhupesh.sharma@freescale.com> <1431603215-25546-6-git-send-email-bhupesh.sharma@freescale.com> <5554C244.80809@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-bl2on0135.outbound.protection.outlook.com ([65.55.169.135]:59760 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934261AbbENPoW (ORCPT ); Thu, 14 May 2015 11:44:22 -0400 In-Reply-To: <5554C244.80809@pengutronix.de> Content-Language: en-US Sender: linux-can-owner@vger.kernel.org List-ID: To: Marc Kleine-Budde , "arnd@arndb.de" , "linux-can@vger.kernel.org" Cc: "bhupesh.linux@gmail.com" , Arora Sakar , "linux-arm-kernel@lists.infradead.org" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBNYXJjIEtsZWluZS1CdWRkZSBb bWFpbHRvOm1rbEBwZW5ndXRyb25peC5kZV0NCj4gU2VudDogVGh1cnNkYXksIE1heSAxNCwgMjAx NSA5OjEyIFBNDQo+IFRvOiBTaGFybWEgQmh1cGVzaC1CNDUzNzA7IGFybmRAYXJuZGIuZGU7IGxp bnV4LWNhbkB2Z2VyLmtlcm5lbC5vcmcNCj4gQ2M6IGJodXBlc2gubGludXhAZ21haWwuY29tOyBB cm9yYSBTYWthci1CNDUyMDU7IGxpbnV4LWFybS0NCj4ga2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiA1LzVdIGNhbjogZmxleGNhbjogQWRkIHN1cHBv cnQgZm9yIG5vbiBSWC1GSUZPDQo+IG1vZGUNCj4gDQo+IE9uIDA1LzE0LzIwMTUgMDE6MzMgUE0s IEJodXBlc2ggU2hhcm1hIHdyb3RlOg0KPiA+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBu b24gUlgtRklGTyAobGVnYWN5KSBtb2RlIGluIHRoZSBmbGV4Y2FuDQo+ID4gZHJpdmVyLg0KPiA+ DQo+ID4gT24gY2VydGFpbiBTb0NzLCB0aGUgUlgtRklGTyBzdXBwb3J0IG1pZ2h0IGJlIGJyb2tl biwgYXMgYSByZXN1bHQgd2UNCj4gPiBuZWVkIHRvIGZhbGwtYmFjayBvbiB0aGUgbGVnYWN5IChu b24gUlgtRklGTykgbW9kZSB0byByZWNlaXZlIENBTg0KPiA+IGZyYW1lcy4NCj4gPg0KPiA+IFNp Z25lZC1vZmYtYnk6IEJodXBlc2ggU2hhcm1hIDxiaHVwZXNoLnNoYXJtYUBmcmVlc2NhbGUuY29t Pg0KPiA+IFNpZ25lZC1vZmYtYnk6IFNha2FyIEFyb3JhIDxTYWthci5Bcm9yYUBmcmVlc2NhbGUu Y29tPg0KPiANCj4gVGhlIG5vbiBGSUZPIG1vZGUgZG9lc24ndCBndWFyYW50ZWUgdGhlIG9yZGVy IG9mIHRoZSBpbmNvbWluZyBmcmFtZXMsIG5vdA0KPiBkb2VzIG5vdCBldmVuIHRyeSB0by4uLnRo aXMgaXMgbm90IGFjY2VwdGFibGUuIEknbSBjdXJyZW50bHkgd29ya2luZyBvbiBhDQo+IHBhdGNo IGJ5IERhdmlkIEphbmRlciB0aGF0IGJyaW5ncyBpbiBub24gRklGTyBtb2RlLCBidXQgdHJpZXMg dG8ga2VlcCB0aGUNCj4gb3JkZXIgb2YgdGhlIGZyYW1lcy4NCg0KVGhhdCBpcyBhbHJlYWR5IFdJ UCBhdCBvdXIgZW5kLiBWMyB3aWxsIGNvbnRhaW4gdGhlIHNhbWUgY2hhbmdlLg0KSWYgeW91IGFy ZSBhbHJlYWR5IHdvcmtpbmcgb24gaXQsIEkgZG9uJ3Qga25vdyBob3cgdG8gcHJvY2VlZCBmdXJ0 aGVyDQphcyB3ZSBoYWQgYWxyZWFkeSB2MSBvZiB0aGlzIHBhdGNoc2V0IHdpdGggdGhlIG5vbiBG SUZPIG1vZGUgb3V0DQpzaW5jZSBhIG1vbnRoIG9yIHNvLg0KDQpSZWdhcmRzLA0KQmh1cGVzaA0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: bhupesh.sharma@freescale.com (Sharma Bhupesh) Date: Thu, 14 May 2015 15:44:19 +0000 Subject: [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO mode In-Reply-To: <5554C244.80809@pengutronix.de> References: <1431603215-25546-1-git-send-email-bhupesh.sharma@freescale.com> <1431603215-25546-6-git-send-email-bhupesh.sharma@freescale.com> <5554C244.80809@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Marc Kleine-Budde [mailto:mkl at pengutronix.de] > Sent: Thursday, May 14, 2015 9:12 PM > To: Sharma Bhupesh-B45370; arnd at arndb.de; linux-can at vger.kernel.org > Cc: bhupesh.linux at gmail.com; Arora Sakar-B45205; linux-arm- > kernel at lists.infradead.org > Subject: Re: [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO > mode > > On 05/14/2015 01:33 PM, Bhupesh Sharma wrote: > > This patch adds support for non RX-FIFO (legacy) mode in the flexcan > > driver. > > > > On certain SoCs, the RX-FIFO support might be broken, as a result we > > need to fall-back on the legacy (non RX-FIFO) mode to receive CAN > > frames. > > > > Signed-off-by: Bhupesh Sharma > > Signed-off-by: Sakar Arora > > The non FIFO mode doesn't guarantee the order of the incoming frames, not > does not even try to...this is not acceptable. I'm currently working on a > patch by David Jander that brings in non FIFO mode, but tries to keep the > order of the frames. That is already WIP at our end. V3 will contain the same change. If you are already working on it, I don't know how to proceed further as we had already v1 of this patchset with the non FIFO mode out since a month or so. Regards, Bhupesh