From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH v2 4/5] scsi: Add scsi_restart_hctx()
Date: Tue, 4 Apr 2017 15:56:34 +0000 [thread overview]
Message-ID: <BY1PR0401MB15322BB999F894A46F40AE5E810B0@BY1PR0401MB1532.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20170404064252.GD9168@lst.de
On 04/03/2017 11:42 PM, Christoph Hellwig wrote:=0A=
>> +static void scsi_restart_hctx(struct request_queue *q,=0A=
>> + struct blk_mq_hw_ctx *hctx)=0A=
>> +{=0A=
>> + struct blk_mq_tags *tags =3D hctx->tags;=0A=
>> + struct blk_mq_tag_set *set =3D q->tag_set;=0A=
>> + int i;=0A=
>> +=0A=
>> + rcu_read_lock();=0A=
>> + list_for_each_entry_rcu(q, &set->tag_list, tag_set_list)=0A=
>> + queue_for_each_hw_ctx(q, hctx, i)=0A=
>> + if (hctx->tags =3D=3D tags)=0A=
>> + blk_mq_sched_restart_hctx(hctx);=0A=
>> + rcu_read_unlock();=0A=
>> +}=0A=
> =0A=
> This looks like generic block layer code, why is it in SCSI?=0A=
=0A=
Hello Christoph,=0A=
=0A=
That's an excellent question. I assume that you are fine with moving=0A=
this code to the block layer?=0A=
=0A=
Bart.=0A=
=0A=
next prev parent reply other threads:[~2017-04-04 15:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 23:22 [PATCH v2 0/5] Avoid that scsi-mq queue processing stalls Bart Van Assche
2017-04-03 23:22 ` [PATCH v2 1/5] blk-mq: Export blk_mq_sched_restart_hctx() Bart Van Assche
2017-04-04 6:40 ` Christoph Hellwig
2017-04-03 23:22 ` [PATCH v2 2/5] blk-mq: Make it safe to use RCU to iterate over blk_mq_tag_set.tag_list Bart Van Assche
2017-04-04 6:40 ` Christoph Hellwig
2017-04-04 15:55 ` Bart Van Assche
2017-04-03 23:22 ` [PATCH v2 3/5] blk-mq: Introduce blk_mq_ops.restart_hctx Bart Van Assche
2017-04-04 6:42 ` Christoph Hellwig
2017-04-05 20:41 ` Omar Sandoval
2017-04-05 20:51 ` Bart Van Assche
2017-04-05 20:54 ` Omar Sandoval
2017-04-03 23:22 ` [PATCH v2 4/5] scsi: Add scsi_restart_hctx() Bart Van Assche
2017-04-04 6:42 ` Christoph Hellwig
2017-04-04 15:56 ` Bart Van Assche [this message]
2017-04-05 6:20 ` Christoph Hellwig
2017-04-05 17:36 ` Bart Van Assche
2017-04-03 23:22 ` [PATCH v2 5/5] scsi: Ensure that scsi_run_queue() runs all hardware queues Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY1PR0401MB15322BB999F894A46F40AE5E810B0@BY1PR0401MB1532.namprd04.prod.outlook.com \
--to=bart.vanassche@sandisk.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.