From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932234AbcHNOex convert rfc822-to-8bit (ORCPT ); Sun, 14 Aug 2016 10:34:53 -0400 Received: from mail-by2nam03on0085.outbound.protection.outlook.com ([104.47.42.85]:59168 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750762AbcHNOew (ORCPT ); Sun, 14 Aug 2016 10:34:52 -0400 From: Bart Van Assche To: Joe Perches , Christophe JAILLET , "linux-scsi@vger.kernel.org" CC: Jayamohan Kallickal , Ketan Mukadam , John Soni Jose , "James E.J. Bottomley" , "Martin K. Petersen" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/2] be2iscsi: Logging neatening Thread-Topic: [PATCH 0/2] be2iscsi: Logging neatening Thread-Index: AQHR9jkCpu9Zs20Pc0K6xjrD6emduw== Date: Sun, 14 Aug 2016 14:34:49 +0000 Message-ID: References: <1471107782.3467.28.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@sandisk.com; x-originating-ip: [73.15.202.106] x-ms-office365-filtering-correlation-id: 2d1008aa-9b53-4b1e-4732-08d3c4502565 x-microsoft-exchange-diagnostics: 1;BY2PR0201MB1861;20:A5/ry5NcJ267UV2dK469DbUhG6tfFvu+Y21ZCmutah0S1sKnII6dnX0sxKfmkmu2dYVbjCBY3rWgwE2kjGXKiCo0prclhe3j4Hah1IQ3WcQI9MejZ6ds9J3RQvCCjjvni94SIpZGw61N2fObN2sN7tVglxz7UDwMacG+8YX51NYTu/IpdMv0frqWwt5NC21osOIF6t/oer7F6cUxBDs7yTEuRS/Lb/UGQv0aA0gPpLCMtZTxCyINXnb9K5WGZogs x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0201MB1861; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BY2PR0201MB1861;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0201MB1861; x-forefront-prvs: 00342DD5BC x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(199003)(24454002)(33656002)(106356001)(122556002)(7736002)(105586002)(11100500001)(7846002)(7696003)(106116001)(77096005)(2900100001)(5002640100001)(305945005)(8676002)(2501003)(97736004)(5001770100001)(92566002)(76576001)(7520500002)(74316002)(81166006)(81156014)(99286002)(76176999)(54356999)(6116002)(3846002)(102836003)(50986999)(3660700001)(8936002)(189998001)(9686002)(3280700002)(66066001)(101416001)(10400500002)(4326007)(68736007)(2906002)(87936001)(586003)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0201MB1861;H:BY2PR0201MB1862.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2016 14:34:49.2553 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1861 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/13/16 13:42, Joe Perches wrote: > Joe Perches (2): > be2iscsi: Coalesce split strings and formats > be2iscsi: Use a standard logging style Hello Joe, As one can see in be_main.h the "level" argument of macro beiscsi_log() is ignored for log levels KERN_EMERG, KERN_ALERT, KERN_CRIT and KERN_ERR. So for these log levels beiscsi_log() is a synonym of shost_printk(). Have you considered to replace beiscsi_log() with shost_printk() for these log levels and additionally to change beiscsi_log() for the other log levels into pr_debug()? pr_debug() statements namely already can be enabled and disabled at runtime. If the BEISCSI_LOG_* log category would be embedded in the log text that would allow to eliminate the phba->attr_log_enable structure member. Additionally, pr_debug() has a facility for displaying the source file name and the line number. That would allow to leave out __LINE__ from be2iscsi log statements. I don't think it is useful to have that line number in non-debug be2iscsi log statements. Thanks, Bart.