From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932872AbcHWN5N (ORCPT ); Tue, 23 Aug 2016 09:57:13 -0400 Received: from mail-sn1nam01on0045.outbound.protection.outlook.com ([104.47.32.45]:32011 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932127AbcHWN5M (ORCPT ); Tue, 23 Aug 2016 09:57:12 -0400 From: Bart Van Assche To: Mikko Rapeli , "linux-kernel@vger.kernel.org" CC: "dm-devel@redhat.com" , Mike Snitzer , Alasdair Kergon Subject: Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Thread-Topic: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Thread-Index: AQHR/UY8kS9VH3eavE6uuEqP0WFEag== Date: Tue, 23 Aug 2016 13:57:08 +0000 Message-ID: References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-5-git-send-email-mikko.rapeli@iki.fi> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@sandisk.com; x-originating-ip: [73.15.202.106] x-ms-office365-filtering-correlation-id: 01e058ed-6b01-4ad5-9c2a-08d3cb5d5fe8 x-microsoft-exchange-diagnostics: 1;BY2PR02MB1687;20:gRCKNdJHBFNM/d04xoV00g/XuPqVZNeYFAp40RUxloiMWf/ZYDN4BFu6HP8c3+O6bBn8mq129ADHCyH71ZL8fFBSoaR8bJZjcVVv6igF/c+CQKiVn/drEv2fUAXbZWLqFpur5mo7E7wfetW7+prjNC2fzi2r4wGAOJmiwUJsKzsLL3bCvzlGkJYmduJRmXs5YfnfRwCI0baJRNsiUF/kYGeQB/LMJu/UJ3v3CG5Wjqcynw3V2JiZ4pX8mOzhAtKI x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB1687; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:BY2PR02MB1687;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB1687; x-forefront-prvs: 004395A01C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(24454002)(199003)(77096005)(189998001)(76176999)(86362001)(50986999)(87936001)(101416001)(4326007)(2906002)(11100500001)(5001770100001)(97736004)(99286002)(5002640100001)(54356999)(33656002)(3280700002)(105586002)(106116001)(2501003)(66066001)(10400500002)(230783001)(92566002)(122556002)(76576001)(8676002)(106356001)(6116002)(81166006)(81156014)(68736007)(3846002)(7736002)(2900100001)(7846002)(3660700001)(305945005)(7696003)(9686002)(5660300001)(8936002)(586003)(102836003)(74316002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR02MB1687;H:BY2PR02MB1686.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2016 13:57:08.7846 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB1687 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u7NDvIro023023 On 08/22/16 11:32, Mikko Rapeli wrote: > - * uint32_t (*get_region_size)(struct dm_dirty_log *log); > + * __u32 (*get_region_size)(struct dm_dirty_log *log); uint32_t is a type that is defined by ANSI C but __u32 not. So this change looks wrong to me. Would it have been sufficient to add "#include " and keep the uint32_t etc. type names? Bart.