All of lore.kernel.org
 help / color / mirror / Atom feed
From: KY Srinivasan <kys@microsoft.com>
To: Sitsofe Wheeler <sitsofe@gmail.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"olaf@aepfle.de" <olaf@aepfle.de>,
	"apw@canonical.com" <apw@canonical.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>
Subject: RE: [PATCH 3/3] Drivers: hv: hv_balloon: Don't post pressure status from interrupt context
Date: Mon, 8 Dec 2014 06:04:35 +0000	[thread overview]
Message-ID: <BY2PR0301MB07114733895C69D3CC61A90AA0640@BY2PR0301MB0711.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20141207080433.GA4531@sucs.org>



> -----Original Message-----
> From: Sitsofe Wheeler [mailto:sitsofe@gmail.com]
> Sent: Sunday, December 7, 2014 12:05 AM
> To: KY Srinivasan
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> jasowang@redhat.com
> Subject: Re: [PATCH 3/3] Drivers: hv: hv_balloon: Don't post pressure status
> from interrupt context
> 
> On Tue, Dec 02, 2014 at 02:29:15PM -0800, K. Y. Srinivasan wrote:
> > We currently release memory (balloon down) in the interrupt context
> > and we also post memory status while releasing memory. Rather than
> > posting the status in the interrupt context, wakeup the status posting
> thread to post the status.
> > This will address the inconsistent lock state that Sitsofe Wheeler
> > <sitsofe@gmail.com>
> > reported:
> 
> Sorry I didn't follow up on this. Things looked better after the patch but I was
> seeing a strange issue where the memory was being reduced to some
> minimum and the balloon would never shrink so the available memory was
> seemingly locked from then on. I ran out of time to investigate this later
> behaviour and didn't have the time to check if it had always been the case
> but I think I see other patches saying you nailed it and other issues. Do you
> have a published git tree with all these pieces in or have they already been
> mainlined?

Greg has not committed these patches yet. One of the patches changes the balloon floor.
This means that the guest will not be ballooned down below the floor. Is this what you are
seeing? In our testing we did not see anything unusual other than the floor being elevated
(as per the design).

K. Y 
> 
> --
> Sitsofe | http://sucs.org/~sits/

  reply	other threads:[~2014-12-08  6:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 22:28 [PATCH 0/3] Drivers: hv: hv_balloon K. Y. Srinivasan
2014-12-02 22:29 ` [PATCH 1/3] Drivers: hv: hv_balloon: Make adjustments in computing the floor K. Y. Srinivasan
2014-12-02 21:51   ` Dan Carpenter
2014-12-02 22:03     ` KY Srinivasan
2014-12-02 22:29   ` [PATCH 2/3] Drivers: hv: hv_balloon: Fix a locking bug in the balloon driver K. Y. Srinivasan
2014-12-02 22:29   ` [PATCH 3/3] Drivers: hv: hv_balloon: Don't post pressure status from interrupt context K. Y. Srinivasan
2014-12-07  8:04     ` Sitsofe Wheeler
2014-12-08  6:04       ` KY Srinivasan [this message]
2014-12-10 20:50         ` Sitsofe Wheeler
2014-12-10 23:43           ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY2PR0301MB07114733895C69D3CC61A90AA0640@BY2PR0301MB0711.namprd03.prod.outlook.com \
    --to=kys@microsoft.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=sitsofe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.