From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Wang Subject: Re: [PATCH] vmxnet3: fix Rx deadlock Date: Wed, 30 Nov 2016 04:59:21 +0000 Message-ID: References: <1479120376-48723-1-git-send-email-stefan.puiu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "mac_leehk@yahoo.com.hk" To: Stefan Puiu , "dev@dpdk.org" Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0055.outbound.protection.outlook.com [104.47.41.55]) by dpdk.org (Postfix) with ESMTP id 5CD1A2C39 for ; Wed, 30 Nov 2016 05:59:38 +0100 (CET) Content-Language: en-US Content-ID: <8F20DF884710DC418D349D404D9BC0A9@namprd05.prod.outlook.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVmYW4gUHVpdSBbbWFpbHRv OnN0ZWZhbi5wdWl1QGdtYWlsLmNvbV0NCj4gU2VudDogTW9uZGF5LCBOb3ZlbWJlciAxNCwgMjAx NiAyOjQ2IEFNDQo+IFRvOiBkZXZAZHBkay5vcmcNCj4gQ2M6IG1hY19sZWVoa0B5YWhvby5jb20u aGs7IFlvbmcgV2FuZyA8eW9uZ3dhbmdAdm13YXJlLmNvbT47DQo+IFN0ZWZhbiBQdWl1IDxzdGVm YW4ucHVpdUBnbWFpbC5jb20+DQo+IFN1YmplY3Q6IFtQQVRDSF0gdm14bmV0MzogZml4IFJ4IGRl YWRsb2NrDQo+IA0KPiBPdXIgdXNlIGNhc2UgaXMgdGhhdCB3ZSBoYXZlIGFuIGFwcCB0aGF0IG5l ZWRzIHRvIGtlZXAgbWJ1ZnMgYXJvdW5kDQo+IGZvciBhIHdoaWxlLiBXZSd2ZSBzZWVuIGNhc2Vz IHdoZW4gY2FsbGluZyB2bXhuZXQzX3Bvc3RfcnhfYnVmcygpIGZyb20NCj4gdm14ZXQzX3JlY3Zf cGt0cygpLCBpdCBtaWdodCBub3Qgc3VjY2VlZCB0byBhZGQgYW55IG1idWZzIHRvIGFueSBSWA0K PiBkZXNjcmlwdG9ycyAod2hlcmUgaXQgcmV0dXJucyAtZXJyKS4gU2luY2UgdGhlcmUgYXJlIG5v IG1idWZzIHRoYXQgdGhlDQo+IHZpcnR1YWwgaGFyZHdhcmUgY2FuIHVzZSwgYW5kIHNpbmNlIG5v Ym9keSBjYWxscw0KPiB2bXhuZXQzX3Bvc3RfcnhfYnVmcygpIGFmdGVyIHRoYXQsIG5vIHBhY2tl dHMgd2lsbCBiZSByZWNlaXZlZCBhZnRlcg0KDQpUaGUgcGF0Y2ggbG9va3MgZ29vZCBvdmVyYWxs Lg0KDQpJIHRoaW5rIGEgbW9yZSBhY2N1cmF0ZSBkZXNjcmlwdGlvbiBpcyB0aGF0IHRoZSBwYXJ0 aWN1bGFyIGRlc2NyaXB0b3IncyBnZW5lcmF0aW9uIGJpdCBuZXZlciBnb3QgZmxpcHBlZCBwcm9w ZXJseSB3aGVuIGFuIG1idWYgZmFpbGVkIHRvIGJlIHJlZmlsbGVkIHdoaWNoIGNhdXNlZCB0aGUg cnggc3R1Y2ssIHJhdGhlciB0aGFuIHZteG5ldDNfcG9zdF9yeF9idWZzKCkgbm90IGJlaW5nIGNh bGxlZCBhZnRlcndhcmRzLg0KDQo+IHRoaXMuIEkgY2FsbCB0aGlzIGEgZGVhZGxvY2sgZm9yIGxh Y2sgb2YgYSBiZXR0ZXIgdGVybSAtIHRoZSB2aXJ0dWFsDQo+IEhXIHdhaXRzIGZvciBmcmVlIG1i dWZzLCB3aGlsZSB0aGUgYXBwIHdhaXRzIGZvciB0aGUgaGFyZHdhcmUgdG8NCj4gbm90aWZ5IGl0 IGZvciBkYXRhLiBOb3RlIHRoYXQgYWZ0ZXIgdGhpcywgdGhlIGFwcCBjYW4ndCByZWNvdmVyLg0K PiANCj4gVGhpcyBmaXggaXMgYSByZXdvcmsgb2YgdGhpcyBwYXRjaCBieSBNYXJjbyBMZWU6DQo+ IGh0dHBzOi8vdXJsZGVmZW5zZS5wcm9vZnBvaW50LmNvbS92Mi91cmw/dT1odHRwLQ0KPiAzQV9f ZHBkay5vcmdfZGV2X3BhdGNod29ya19wYXRjaF82NTc1XyZkPUN3SUJBZyZjPVNxY2wwRXo2TTBY OGENCj4gZU02N0xLSWlESkFYVmVBdy1ZaWhWTU50WHQtDQo+IHVFcyZyPTQ0bVNPNU41eUVzNENl Q2R0UUUweHQwRjdKMHA2N19tQXBZVkF6eVltczAmbT1nMmdpM1pFcmR4DQo+IEFLR1k4ZDN3Ymhr MkQ2VExVVllCczNLLQ0KPiBLTWRpSnd1dkkmcz1ZTHowV3NsX2tRVVhQV2lqODJubk85Uk9CNjRB SzVadERDeVV2SHVVOGpBJmU9IC4gSQ0KPiBoYWQgdG8gZm9yd2FyZCBwb3J0IGl0LA0KPiBhZGRy ZXNzIHJldmlldyBjb21tZW50cyBhbmQgYWxzbyByZXZlcnRlZCB0aGUgYWxsb2NhdGlvbiBmYWls dXJlDQo+IGhhbmRpbmcgdG8gdGhlIGZpcnN0IHZlcnNpb24gb2YgdGhlIHBhdGNoDQoNCnMvaGFu ZGluZy9oYW5kbGluZw0KDQo+IChodHRwczovL3VybGRlZmVuc2UucHJvb2Zwb2ludC5jb20vdjIv dXJsP3U9aHR0cC0NCj4gM0FfX2RwZGsub3JnX21sX2FyY2hpdmVzX2Rldl8yMDE1LQ0KPiAyREp1 bHlfMDIyMDc5Lmh0bWwmZD1Dd0lCQWcmYz1TcWNsMEV6Nk0wWDhhZU02N0xLSWlESkFYVmVBdy0N Cj4gWWloVk1OdFh0LQ0KPiB1RXMmcj00NG1TTzVONXlFczRDZUNkdFFFMHh0MEY3SjBwNjdfbUFw WVZBenlZbXMwJm09ZzJnaTNaRXJkeA0KPiBBS0dZOGQzd2JoazJENlRMVVZZQnMzSy0NCj4gS01k aUp3dXZJJnM9NUhrc1pWOHM5OWIzalZWN1BlYTYwZDE4aEtxWHhwNGVScEpXano2c1dMYyZlPSAp LA0KPiBzaW5jZSB0aGF0J3MNCj4gdGhlIG9ubHkgYXBwcm9hY2ggdGhhdCBzZWVtcyB0byB3b3Jr LCBhbmQgc2VlbXMgdG8gYmUgd2hhdCBvdGhlcg0KPiBkcml2ZXJzIGFyZSBkb2luZyAoSSBjaGVj a2VkIGl4Z2JlIGFuZCBlbSkuIFJldXNpbmcgdGhlIG1idWYgdGhhdCdzDQo+IGdldHRpbmcgcGFz c2VkIHRvIHRoZSBhcHBsaWNhdGlvbiBkb2Vzbid0IHNlZW0gdG8gbWFrZSBzZW5zZSwgYW5kIGl0 DQo+IHdhcyBjYXVzaW5nIHdlaXJkIGlzc3VlcyBpbiBvdXIgYXBwLiBBbHNvLCByZXVzaW5nIHJ4 bSB3aXRob3V0DQo+IGNoZWNraW5nIGlmIGl0J3MgTlVMTCBjb3VsZCBjYXVzZSB0aGUgY29kZSB0 byBjcmFzaC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbiBQdWl1IDxzdGVmYW4ucHVpdUBn bWFpbC5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9uZXQvdm14bmV0My92bXhuZXQzX3J4dHguYyB8 IDM4DQo+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tDQo+ICAxIGZpbGUg Y2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL25ldC92bXhuZXQzL3ZteG5ldDNfcnh0eC5jDQo+IGIvZHJpdmVycy9uZXQv dm14bmV0My92bXhuZXQzX3J4dHguYw0KPiBpbmRleCBiMTA5MTY4Li5jOWQyNDg4IDEwMDY0NA0K PiAtLS0gYS9kcml2ZXJzL25ldC92bXhuZXQzL3ZteG5ldDNfcnh0eC5jDQo+ICsrKyBiL2RyaXZl cnMvbmV0L3ZteG5ldDMvdm14bmV0M19yeHR4LmMNCj4gQEAgLTUxOCw2ICs1MTgsMzIgQEANCj4g IAlyZXR1cm4gbmJfdHg7DQo+ICB9DQo+IA0KPiArc3RhdGljIGlubGluZSB2b2lkDQo+ICt2bXhu ZXQzX3JlbmV3X2Rlc2Modm14bmV0M19yeF9xdWV1ZV90ICpyeHEsIHVpbnQ4X3QgcmluZ19pZCwN Cj4gKwkJc3RydWN0IHJ0ZV9tYnVmICptYnVmKQ0KDQpOaXQ6IGFsaWduIHRoZSBwYXJhbXMgaGVy ZSB0byBiZSBjb25zaXN0ZW50IHdpdGggb3RoZXIgZnVuY3Rpb25zLg0KDQo+ICt7DQo+ICsJdWlu dDMyX3QgIHZhbCA9IDA7DQoNCk5pdDogZXh0cmEgc3BhY2UgYmVmb3JlICJ2YWwiDQoNCj4gKwlz dHJ1Y3Qgdm14bmV0M19jbWRfcmluZyAqcmluZyA9ICZyeHEtPmNtZF9yaW5nW3JpbmdfaWRdOw0K PiArCXN0cnVjdCBWbXhuZXQzX1J4RGVzYyAqcnhkID0NCj4gKwkJKHN0cnVjdCBWbXhuZXQzX1J4 RGVzYyAqKShyaW5nLT5iYXNlICsgcmluZy0+bmV4dDJmaWxsKTsNCj4gKwl2bXhuZXQzX2J1Zl9p bmZvX3QgKmJ1Zl9pbmZvID0gJnJpbmctPmJ1Zl9pbmZvW3JpbmctPm5leHQyZmlsbF07DQo+ICsN Cj4gKwlpZiAocmluZ19pZCA9PSAwKQ0KPiArCQl2YWwgPSBWTVhORVQzX1JYRF9CVFlQRV9IRUFE Ow0KPiArCWVsc2UNCj4gKwkJdmFsID0gVk1YTkVUM19SWERfQlRZUEVfQk9EWTsNCj4gKw0KPiAr CWJ1Zl9pbmZvLT5tID0gbWJ1ZjsNCj4gKwlidWZfaW5mby0+bGVuID0gKHVpbnQxNl90KShtYnVm LT5idWZfbGVuIC0NCj4gUlRFX1BLVE1CVUZfSEVBRFJPT00pOw0KPiArCWJ1Zl9pbmZvLT5idWZQ QSA9IHJ0ZV9tYnVmX2RhdGFfZG1hX2FkZHJfZGVmYXVsdChtYnVmKTsNCj4gKw0KPiArCXJ4ZC0+ YWRkciA9IGJ1Zl9pbmZvLT5idWZQQTsNCj4gKwlyeGQtPmJ0eXBlID0gdmFsOw0KPiArCXJ4ZC0+ bGVuID0gYnVmX2luZm8tPmxlbjsNCj4gKwlyeGQtPmdlbiA9IHJpbmctPmdlbjsNCj4gKw0KPiAr CXZteG5ldDNfY21kX3JpbmdfYWR2X25leHQyZmlsbChyaW5nKTsNCj4gK30NCj4gIC8qDQo+ICAg KiAgQWxsb2NhdGVzIG1idWZzIGFuZCBjbHVzdGVycy4gUG9zdCByeCBkZXNjcmlwdG9ycyB3aXRo IGJ1ZmZlciBkZXRhaWxzDQo+ICAgKiAgc28gdGhhdCBkZXZpY2UgY2FuIHJlY2VpdmUgcGFja2V0 cyBpbiB0aG9zZSBidWZmZXJzLg0KPiBAQCAtNjU3LDkgKzY4MywxNyBAQA0KPiAgCX0NCj4gDQo+ ICAJd2hpbGUgKHJjZC0+Z2VuID09IHJ4cS0+Y29tcF9yaW5nLmdlbikgew0KPiArCQlzdHJ1Y3Qg cnRlX21idWYgKm5ld207DQoNCk5pdDogYWRkIGEgYmxhbmsgbGluZSBoZXJlLg0KDQo+ICAJCWlm IChuYl9yeCA+PSBuYl9wa3RzKQ0KPiAgCQkJYnJlYWs7DQo+IA0KPiArCQluZXdtID0gcnRlX21i dWZfcmF3X2FsbG9jKHJ4cS0+bXApOw0KPiArCQlpZiAodW5saWtlbHkobmV3bSA9PSBOVUxMKSkg ew0KPiArCQkJUE1EX1JYX0xPRyhFUlIsICJFcnJvciBhbGxvY2F0aW5nIG1idWYiKTsNCj4gKwkJ CXJ4cS0+c3RhdHMucnhfYnVmX2FsbG9jX2ZhaWx1cmUrKzsNCj4gKwkJCWJyZWFrOw0KPiArCQl9 DQo+ICsNCj4gIAkJaWR4ID0gcmNkLT5yeGRJZHg7DQo+ICAJCXJpbmdfaWR4ID0gKHVpbnQ4X3Qp KChyY2QtPnJxSUQgPT0gcnhxLT5xaWQxKSA/IDAgOiAxKTsNCj4gIAkJcnhkID0gKFZteG5ldDNf UnhEZXNjICopcnhxLT5jbWRfcmluZ1tyaW5nX2lkeF0uYmFzZSArDQo+IGlkeDsNCj4gQEAgLTc1 OSw4ICs3OTMsOCBAQA0KPiAgCQlWTVhORVQzX0lOQ19SSU5HX0lEWF9PTkxZKHJ4cS0NCj4gPmNt ZF9yaW5nW3JpbmdfaWR4XS5uZXh0MmNvbXAsDQo+ICAJCQkJCSAgcnhxLT5jbWRfcmluZ1tyaW5n X2lkeF0uc2l6ZSk7DQo+IA0KPiAtCQkvKiBJdCdzIHRpbWUgdG8gYWxsb2NhdGUgc29tZSBuZXcg YnVmIGFuZCByZW5ldyBkZXNjcmlwdG9ycw0KPiAqLw0KPiAtCQl2bXhuZXQzX3Bvc3RfcnhfYnVm cyhyeHEsIHJpbmdfaWR4KTsNCj4gKwkJLyogSXQncyB0aW1lIHRvICByZW5ldyBkZXNjcmlwdG9y cyAqLw0KDQpOaXQ6IGV4dHJhIHNwYWNlIGJlZm9yZSAicmVuZXciDQoNCj4gKwkJdm14bmV0M19y ZW5ld19kZXNjKHJ4cSwgcmluZ19pZHgsIG5ld20pOw0KPiAgCQlpZiAodW5saWtlbHkocnhxLT5z aGFyZWQtPmN0cmwudXBkYXRlUnhQcm9kKSkgew0KPiAgCQkJVk1YTkVUM19XUklURV9CQVIwX1JF RyhodywNCj4gcnhwcm9kX3JlZ1tyaW5nX2lkeF0gKyAocnhxLT5xdWV1ZV9pZCAqIFZNWE5FVDNf UkVHX0FMSUdOKSwNCj4gIAkJCQkJICAgICAgIHJ4cS0+Y21kX3JpbmdbcmluZ19pZHhdLm5leHQy ZmlsbCk7DQo+IC0tDQo+IDEuOS4xDQoNCg==