On Mon, Dec 19, 2016 at 6:17 AM, Christian König
<deathsimple@vodafone.de> wrote:
> Yeah, agree totally with Monk here.
>
> If you find that you need some KIQ helpers which are independent of the
> hardware generation you can put them into amdgpu_kiq.c.
>
> Monk, David or maybe even Michel and Nicolai could you guys take a closer
> look at the patches.
>
> I'm currently to busy with private issues, so I just briefly skimmed over
> them, but still found some issues.
>
> The VA update stuff seems incorrectly handled to me for example. You only
> update the page tables once and then assume that everything stays as it is.
>

I agree with all of Christian and Monk's comments.  Please see my
comments on the patches.

Alex

> Regards,
> Christian.
>
>
> Am 19.12.2016 um 08:13 schrieb Liu, Monk:
>>
>> Sorry, NAK for the KIQ implement patches.
>>
>> KIQ is just another compute queue, and each  generation of compute queue
>> initialization is different, so there is no need of a amdgpu_kiq.c file to
>> cover the function of kiq,
>>
>> Kiq is good enough to be in each gfx_x_x.c file .e.g :
>> KIQ  for VI is in gfx_v8_0.c
>> And KIQ for AI is in gfx_v9_0.c
>>
>> Most important is that the "queue_init" routine of above two chips on KIQ
>> is different (MQD descriptor as well as registers need programing ... ),
>> please just align with the previous patch style in amd-sriov-4.6 for KIQ
>> part
>>
>> BR Monk
>>
>> -----邮件原件-----
>> 发件人: Yu, Xiangliang
>> 发送时间: Sunday, December 18, 2016 9:47 AM
>> 收件人: dl.SRDC_SW_GPUVirtualization
>> 主题: FW: [PATCH 02/23] drm/amdgpu: add kiq into compiling
>>
>>
>>
>> -----Original Message-----
>> From: Xiangliang Yu [mailto:Xiangliang.Yu@amd.com]
>> Sent: Sunday, December 18, 2016 12:16 AM
>> To: amd-gfx@lists.freedesktop.org; dl.SRDC_SW_GPUVirtualization
>> <dl.SRDC_SW_GPUVirtualization@amd.com>
>> Cc: Yu, Xiangliang <Xiangliang.Yu@amd.com>
>> Subject: [PATCH 02/23] drm/amdgpu: add kiq into compiling
>>
>> Add support KIQ in Makefile to make it into module.
>>
>> Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile
>> b/drivers/gpu/drm/amd/amdgpu/Makefile
>> index dd0b6db..635ff94 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/Makefile
>> +++ b/drivers/gpu/drm/amd/amdgpu/Makefile
>> @@ -30,7 +30,7 @@ amdgpu-y += amdgpu_device.o amdgpu_kms.o \
>>         atombios_encoders.o amdgpu_sa.o atombios_i2c.o \
>>         amdgpu_prime.o amdgpu_vm.o amdgpu_ib.o amdgpu_pll.o \
>>         amdgpu_ucode.o amdgpu_bo_list.o amdgpu_ctx.o amdgpu_sync.o \
>> -       amdgpu_gtt_mgr.o amdgpu_vram_mgr.o
>> +       amdgpu_gtt_mgr.o amdgpu_vram_mgr.o amdgpu_kiq.o
>>     # add asic specific block
>>   amdgpu-$(CONFIG_DRM_AMDGPU_CIK)+= cik.o cik_ih.o kv_smc.o kv_dpm.o \
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx