From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Matthew Wilcox To: Jeff Layton , "Darrick J. Wong" , "jlayton@kernel.org" CC: Andrew Morton , Al Viro , Jan Kara , "tytso@mit.edu" , "axboe@kernel.dk" , "ross.zwisler@linux.intel.com" , "corbet@lwn.net" , Chris Mason , Josef Bacik , David Sterba , Carlos Maiolino , Eryu Guan , David Howells , Christoph Hellwig , Liu Bo , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-ext4@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-block@vger.kernel.org" Subject: RE: [PATCH v8 12/18] Documentation: flesh out the section in vfs.txt on storing and reporting writeback errors Date: Thu, 29 Jun 2017 18:21:50 +0000 Message-ID: References: <20170629131954.28733-1-jlayton@kernel.org> <20170629131954.28733-13-jlayton@kernel.org> <20170629171137.GE5874@birch.djwong.org> <1498760014.22569.13.camel@poochiereds.net> In-Reply-To: <1498760014.22569.13.camel@poochiereds.net> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: RnJvbTogSmVmZiBMYXl0b24gW21haWx0bzpqbGF5dG9uQHBvb2NoaWVyZWRzLm5ldF0NCj4gT24g VGh1LCAyMDE3LTA2LTI5IGF0IDEwOjExIC0wNzAwLCBEYXJyaWNrIEouIFdvbmcgd3JvdGU6DQo+ ID4gT24gVGh1LCBKdW4gMjksIDIwMTcgYXQgMDk6MTk6NDhBTSAtMDQwMCwgamxheXRvbkBrZXJu ZWwub3JnIHdyb3RlOg0KPiA+ID4gK0hhbmRsaW5nIGVycm9ycyBkdXJpbmcgd3JpdGViYWNrDQo+ ID4gPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiA+ICtNb3N0IGFwcGxp Y2F0aW9ucyB0aGF0IHV0aWxpemUgdGhlIHBhZ2VjYWNoZSB3aWxsIHBlcmlvZGljYWxseSBjYWxs DQo+ID4gPiArZnN5bmMgdG8gZW5zdXJlIHRoYXQgZGF0YSB3cml0dGVuIGhhcyBtYWRlIGl0IHRv IHRoZSBiYWNraW5nIHN0b3JlLg0KPiA+DQo+ID4gL21lIHdvbmRlcnMgaWYgdGhpcyBzZW50ZW5j ZSBvdWdodCB0byBiZSB3b3JkZWQgbW9yZSBzdHJvbmdseSwgZS5nLg0KPiA+DQo+ID4gIkFwcGxp Y2F0aW9ucyB0aGF0IHV0aWxpemUgdGhlIHBhZ2VjYWNoZSBtdXN0IGNhbGwgYSBkYXRhDQo+ID4g c3luY2hyb25pemF0aW9uIHN5c2NhbGwgc3VjaCBhcyBmc3luYywgZmRhdGFzeW5jLCBvciBtc3lu YyB0byBlbnN1cmUNCj4gPiB0aGF0IGRhdGEgd3JpdHRlbiBoYXMgbWFkZSBpdCB0byB0aGUgYmFj a2luZyBzdG9yZS4iDQo+IA0KPiBXZWxsLi4ub25seSBpZiB0aGV5IGNhcmUgYWJvdXQgdGhlIGRh dGEuIFRoZXJlIGFyZSBzb21lIHRoYXQgZG9uJ3QuIDopDQoNCkFsc28sIGFwcGxpY2F0aW9ucyBk b24ndCAidXRpbGl6ZSB0aGUgcGFnZWNhY2hlIjsgZmlsZXN5c3RlbXMgdXNlIHRoZSBwYWdlY2Fj aGUuDQpBcHBsaWNhdGlvbnMgbWF5IG9yIG1heSBub3QgdXNlIGNhY2hlZCBJL08uICBIb3cgYWJv dXQgdGhpczoNCg0KQXBwbGljYXRpb25zIHdoaWNoIGNhcmUgYWJvdXQgZGF0YSBpbnRlZ3JpdHkg YW5kIHVzZSBjYWNoZWQgSS9PIHdpbGwNCnBlcmlvZGljYWxseSBjYWxsIGZzeW5jKCksIG1zeW5j KCkgb3IgZmRhdGFzeW5jKCkgdG8gZW5zdXJlIHRoYXQgdGhlaXINCmRhdGEgaXMgZHVyYWJsZS4N Cg0KPiBXaGF0IHNob3VsZCB3ZSBkbyBhYm91dCBzeW5jX2ZpbGVfcmFuZ2UgaGVyZT8gSXQgZG9l c24ndCBjdXJyZW50bHkgY2FsbA0KPiBhbnkgZmlsZXN5c3RlbSBvcGVyYXRpb25zIGRpcmVjdGx5 LCBzbyB3ZSBkb24ndCBoYXZlIGEgZ29vZCB3YXkgdG8gbWFrZQ0KPiBpdCBzZWxlY3RpdmVseSB1 c2UgZXJyc2VxX3QgaGFuZGxpbmcgdGhlcmUuDQo+IA0KPiBJIGNvdWxkIHJlc3VycmVjdCB0aGUg RlNfKiBmbGFnIGZvciB0aGF0LCB0aG91Z2ggSSBkb24ndCByZWFsbHkgbGlrZQ0KPiB0aGF0LiBT aG91bGQgSSBqdXN0IGdvIGFoZWFkIGFuZCBjb252ZXJ0IGl0IG92ZXIgdG8gdXNlIGVycnNlcV90 IHVuZGVyDQo+IHRoZSB0aGVvcnkgdGhhdCBtb3N0IGNhbGxlcnMgd2lsbCBldmVudHVhbGx5IHdh bnQgdGhhdCBhbnl3YXk/DQoNCkkgdGhpbmsgc28uDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-co1nam03on0135.outbound.protection.outlook.com ([104.47.40.135]:58272 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752689AbdF2SV4 (ORCPT ); Thu, 29 Jun 2017 14:21:56 -0400 From: Matthew Wilcox To: Jeff Layton , "Darrick J. Wong" , "jlayton@kernel.org" CC: Andrew Morton , Al Viro , Jan Kara , "tytso@mit.edu" , "axboe@kernel.dk" , "ross.zwisler@linux.intel.com" , "corbet@lwn.net" , Chris Mason , Josef Bacik , David Sterba , Carlos Maiolino , Eryu Guan , David Howells , Christoph Hellwig , Liu Bo , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-ext4@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-block@vger.kernel.org" Subject: RE: [PATCH v8 12/18] Documentation: flesh out the section in vfs.txt on storing and reporting writeback errors Date: Thu, 29 Jun 2017 18:21:50 +0000 Message-ID: References: <20170629131954.28733-1-jlayton@kernel.org> <20170629131954.28733-13-jlayton@kernel.org> <20170629171137.GE5874@birch.djwong.org> <1498760014.22569.13.camel@poochiereds.net> In-Reply-To: <1498760014.22569.13.camel@poochiereds.net> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org List-ID: From: Jeff Layton [mailto:jlayton@poochiereds.net] > On Thu, 2017-06-29 at 10:11 -0700, Darrick J. Wong wrote: > > On Thu, Jun 29, 2017 at 09:19:48AM -0400, jlayton@kernel.org wrote: > > > +Handling errors during writeback > > > +-------------------------------- > > > +Most applications that utilize the pagecache will periodically call > > > +fsync to ensure that data written has made it to the backing store. > > > > /me wonders if this sentence ought to be worded more strongly, e.g. > > > > "Applications that utilize the pagecache must call a data > > synchronization syscall such as fsync, fdatasync, or msync to ensure > > that data written has made it to the backing store." > > Well...only if they care about the data. There are some that don't. :) Also, applications don't "utilize the pagecache"; filesystems use the pagecache. Applications may or may not use cached I/O. How about this: Applications which care about data integrity and use cached I/O will periodically call fsync(), msync() or fdatasync() to ensure that their data is durable. > What should we do about sync_file_range here? It doesn't currently call > any filesystem operations directly, so we don't have a good way to make > it selectively use errseq_t handling there. > > I could resurrect the FS_* flag for that, though I don't really like > that. Should I just go ahead and convert it over to use errseq_t under > the theory that most callers will eventually want that anyway? I think so. {.n++%ݶw{.n+{k~^nrzh&zzޗ++zfh~iz_j:+v)ߣm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: RE: [PATCH v8 12/18] Documentation: flesh out the section in vfs.txt on storing and reporting writeback errors Date: Thu, 29 Jun 2017 18:21:50 +0000 Message-ID: References: <20170629131954.28733-1-jlayton@kernel.org> <20170629131954.28733-13-jlayton@kernel.org> <20170629171137.GE5874@birch.djwong.org> <1498760014.22569.13.camel@poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Andrew Morton , Al Viro , Jan Kara , "tytso@mit.edu" , "axboe@kernel.dk" , "ross.zwisler@linux.intel.com" , "corbet@lwn.net" , Chris Mason , Josef Bacik , David Sterba , Carlos Maiolino , Eryu Guan , David Howells , Christoph Hellwig , Liu Bo , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-ext4@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-block@vger.kernel.org" To: Jeff Layton , "Darrick J. Wong" , "jlayton@kernel.org" Return-path: In-Reply-To: <1498760014.22569.13.camel@poochiereds.net> Content-Language: en-US Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org RnJvbTogSmVmZiBMYXl0b24gW21haWx0bzpqbGF5dG9uQHBvb2NoaWVyZWRzLm5ldF0NCj4gT24g VGh1LCAyMDE3LTA2LTI5IGF0IDEwOjExIC0wNzAwLCBEYXJyaWNrIEouIFdvbmcgd3JvdGU6DQo+ ID4gT24gVGh1LCBKdW4gMjksIDIwMTcgYXQgMDk6MTk6NDhBTSAtMDQwMCwgamxheXRvbkBrZXJu ZWwub3JnIHdyb3RlOg0KPiA+ID4gK0hhbmRsaW5nIGVycm9ycyBkdXJpbmcgd3JpdGViYWNrDQo+ ID4gPiArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiA+ICtNb3N0IGFwcGxp Y2F0aW9ucyB0aGF0IHV0aWxpemUgdGhlIHBhZ2VjYWNoZSB3aWxsIHBlcmlvZGljYWxseSBjYWxs DQo+ID4gPiArZnN5bmMgdG8gZW5zdXJlIHRoYXQgZGF0YSB3cml0dGVuIGhhcyBtYWRlIGl0IHRv IHRoZSBiYWNraW5nIHN0b3JlLg0KPiA+DQo+ID4gL21lIHdvbmRlcnMgaWYgdGhpcyBzZW50ZW5j ZSBvdWdodCB0byBiZSB3b3JkZWQgbW9yZSBzdHJvbmdseSwgZS5nLg0KPiA+DQo+ID4gIkFwcGxp Y2F0aW9ucyB0aGF0IHV0aWxpemUgdGhlIHBhZ2VjYWNoZSBtdXN0IGNhbGwgYSBkYXRhDQo+ID4g c3luY2hyb25pemF0aW9uIHN5c2NhbGwgc3VjaCBhcyBmc3luYywgZmRhdGFzeW5jLCBvciBtc3lu YyB0byBlbnN1cmUNCj4gPiB0aGF0IGRhdGEgd3JpdHRlbiBoYXMgbWFkZSBpdCB0byB0aGUgYmFj a2luZyBzdG9yZS4iDQo+IA0KPiBXZWxsLi4ub25seSBpZiB0aGV5IGNhcmUgYWJvdXQgdGhlIGRh dGEuIFRoZXJlIGFyZSBzb21lIHRoYXQgZG9uJ3QuIDopDQoNCkFsc28sIGFwcGxpY2F0aW9ucyBk b24ndCAidXRpbGl6ZSB0aGUgcGFnZWNhY2hlIjsgZmlsZXN5c3RlbXMgdXNlIHRoZSBwYWdlY2Fj aGUuDQpBcHBsaWNhdGlvbnMgbWF5IG9yIG1heSBub3QgdXNlIGNhY2hlZCBJL08uICBIb3cgYWJv dXQgdGhpczoNCg0KQXBwbGljYXRpb25zIHdoaWNoIGNhcmUgYWJvdXQgZGF0YSBpbnRlZ3JpdHkg YW5kIHVzZSBjYWNoZWQgSS9PIHdpbGwNCnBlcmlvZGljYWxseSBjYWxsIGZzeW5jKCksIG1zeW5j KCkgb3IgZmRhdGFzeW5jKCkgdG8gZW5zdXJlIHRoYXQgdGhlaXINCmRhdGEgaXMgZHVyYWJsZS4N Cg0KPiBXaGF0IHNob3VsZCB3ZSBkbyBhYm91dCBzeW5jX2ZpbGVfcmFuZ2UgaGVyZT8gSXQgZG9l c24ndCBjdXJyZW50bHkgY2FsbA0KPiBhbnkgZmlsZXN5c3RlbSBvcGVyYXRpb25zIGRpcmVjdGx5 LCBzbyB3ZSBkb24ndCBoYXZlIGEgZ29vZCB3YXkgdG8gbWFrZQ0KPiBpdCBzZWxlY3RpdmVseSB1 c2UgZXJyc2VxX3QgaGFuZGxpbmcgdGhlcmUuDQo+IA0KPiBJIGNvdWxkIHJlc3VycmVjdCB0aGUg RlNfKiBmbGFnIGZvciB0aGF0LCB0aG91Z2ggSSBkb24ndCByZWFsbHkgbGlrZQ0KPiB0aGF0LiBT aG91bGQgSSBqdXN0IGdvIGFoZWFkIGFuZCBjb252ZXJ0IGl0IG92ZXIgdG8gdXNlIGVycnNlcV90 IHVuZGVyDQo+IHRoZSB0aGVvcnkgdGhhdCBtb3N0IGNhbGxlcnMgd2lsbCBldmVudHVhbGx5IHdh bnQgdGhhdCBhbnl3YXk/DQoNCkkgdGhpbmsgc28uDQoNCg== -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org