RE: [PATCH 2/3] kernel: pid_namespace: Fix line over 80 characters

[Matthew Wilcox <mawilcox@microsoft.com>]

Ooh, no, don't split it here.  People grep for 'struct pid_namespace' and this split will mean they don't find it.  I would probably split it between the '*' and the 'create'.  You could also split it between the 'static' and the 'struct'.

> -----Original Message-----
> From: Gargi Sharma [mailto:gs051095@gmail.com]
> Sent: Sunday, March 26, 2017 10:48 AM
> To: Matthew Wilcox <mawilcox@microsoft.com>
> Cc: outreachy-kernel@googlegroups.com; Gargi Sharma
> <gs051095@gmail.com>
> Subject: [PATCH 2/3] kernel: pid_namespace: Fix line over 80 characters
> 
> Line over 80 characters are split to fix the following checkpatch
> issue:
> WARNING: line over 80 characters
> 
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
>  kernel/pid_namespace.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
> index 6ace1e3..18f5385 100644
> --- a/kernel/pid_namespace.c
> +++ b/kernel/pid_namespace.c
> @@ -92,8 +92,9 @@ static void dec_pid_namespaces(struct ucounts *ucounts)
>  	dec_ucount(ucounts, UCOUNT_PID_NAMESPACES);
>  }
> 
> -static struct pid_namespace *create_pid_namespace(struct user_namespace
> *user_ns,
> -	struct pid_namespace *parent_pid_ns)
> +static struct
> +pid_namespace *create_pid_namespace(struct user_namespace *user_ns,
> +				    struct pid_namespace *parent_pid_ns)
>  {
>  	struct pid_namespace *ns;
>  	unsigned int level = parent_pid_ns->level + 1;
> --
> 2.7.4