All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sai Pavan Boddu <saipava@xilinx.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: RE: [PATCH-for-5.2 2/5] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI)
Date: Sun, 8 Nov 2020 13:40:52 +0000	[thread overview]
Message-ID: <BY5PR02MB6772E37593614B04214ED690CAEB0@BY5PR02MB6772.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20201107111307.262263-3-philmd@redhat.com>

Thanks, good fix.

Reviewed-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>

Regards,
Sai Pavan
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Saturday, November 7, 2020 4:43 PM
> To: qemu-devel@nongnu.org
> Cc: Gerd Hoffmann <kraxel@redhat.com>; Sai Pavan Boddu
> <saipava@xilinx.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
> Subject: [PATCH-for-5.2 2/5] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on
> USB_XHCI_PCI)
> 
> Since commit 755fba11fbc and 8ddab8dd3d8 we can not build USB_XHCI_NEC
> without USB_XHCI_PCI. Correct the Kconfig dependency.
> 
> Fixes: 755fba11fbc ("usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/usb/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index
> a674ce4c542..6a213b04758 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -42,9 +42,7 @@ config USB_XHCI_PCI
> 
>  config USB_XHCI_NEC
>      bool
> -    default y if PCI_DEVICES
> -    depends on PCI
> -    select USB_XHCI
> +    select USB_XHCI_PCI
> 
>  config USB_XHCI_SYSBUS
>      bool
> --
> 2.26.2


  reply	other threads:[~2020-11-08 13:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-07 11:13 [PATCH-for-5.2 0/5] hw/usb/hcd-xhci: Fix xhci-pci devices Philippe Mathieu-Daudé
2020-11-07 11:13 ` [PATCH-for-5.2 1/5] hw/usb/hcd-xhci: Make xhci base model abstract Philippe Mathieu-Daudé
2020-11-08 13:38   ` Sai Pavan Boddu
2020-11-09  9:51   ` Gerd Hoffmann
2020-11-09 11:00     ` Philippe Mathieu-Daudé
2020-11-09 11:30       ` Gerd Hoffmann
2020-11-09 13:40         ` Philippe Mathieu-Daudé
2020-11-07 11:13 ` [PATCH-for-5.2 2/5] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI) Philippe Mathieu-Daudé
2020-11-08 13:40   ` Sai Pavan Boddu [this message]
2020-11-09 11:08   ` Gerd Hoffmann
2020-11-07 11:13 ` [PATCH-for-6.0 3/5] hw/usb/hcd-xhci: Rename "base-xhci" as TYPE_XHCI_COMMON Philippe Mathieu-Daudé
2020-11-07 11:13 ` [PATCH-for-6.0 4/5] hw/usb/hcd-xhci-pci: Use OBJECT_DECLARE_SIMPLE_TYPE() macro Philippe Mathieu-Daudé
2020-11-07 11:13 ` [PATCH-for-6.0 5/5] hw/usb/hcd-xhci-pci: Rename "pci-xhci" as TYPE_XHCI_PCI_COMMON Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR02MB6772E37593614B04214ED690CAEB0@BY5PR02MB6772.namprd02.prod.outlook.com \
    --to=saipava@xilinx.com \
    --cc=kraxel@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.